MIME-Version: 1.0
References: 
 <CAP53Pky29GWAVVk3oBgKBDqhND0BRBN6yTPeguV_qSivFL5N_g@mail.gmail.com>
 <CA+TgmobDHmaNTqi5yLPJoW6fTCuiWOgF9CSCSHX_OTLmGxYRUQ@mail.gmail.com>
 <CAApHDvqYL3OVvOsyvEPsDJ7h4zQh=LEygQgcQSN-TemRJLMb6Q@mail.gmail.com>
 <3ea66a50-e4b0-4f20-ae0c-4d9cbaf81cfb@tantorlabs.com>
 <CAApHDvpuM8jW-BGu7B=i6uv+jmndEo-2z_BYvj5JNmx=qV-uSQ@mail.gmail.com>
 <0e8dc4fa-3655-4e9f-9424-9b32a15e6acd@tantorlabs.com>
 <CAApHDvqmyHuEt7rdFLJr4cZecbhno5OZ6iL5EQNNu9Oi1f93sQ@mail.gmail.com>
 <7e995158-157e-4ec6-a7c8-266c1a6f7b43@tantorlabs.com>
 <CAApHDvq0Zz3+nh9hPRBP-oAocFZETfhdE_jcN8aG+Thc24Zk5g@mail.gmail.com>
 <06840539-e321-4930-9f89-cfc783c5b80a@tantorlabs.com>
 <15e0422a-31ec-4e82-b0cf-0839f636b185@tantorlabs.com>
 <5c7034c4-c48b-428b-ab3f-67f14d9f542e@tantorlabs.com>
 <CAApHDvq+uqf3MRFb+Ai3W1k3fMnrwWBLhzUAYj3_+MM8jK32fA@mail.gmail.com>
 <34407b2d-946b-40cd-a665-49ca6af62fb9@gmail.com>
 <CAApHDvr-0MLz58OPgzFdOfVouCGFm23iO4Bn_4hLBgCLzG+==w@mail.gmail.com>
 <3a4bff1b-f6d5-41d4-b956-2da25bed0aae@tantorlabs.com>
In-Reply-To: <3a4bff1b-f6d5-41d4-b956-2da25bed0aae@tantorlabs.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Tue, 29 Jul 2025 15:25:50 +1200
Message-ID: 
 <CAApHDvp2nD4zndtHRfk30LzAXHPm7jorDo0SVtqaQiLtppFjaA@mail.gmail.com>
Subject: Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost
 adjustment
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: Andrei Lepikhov <lepihov@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Lukas Fittl <lukas@fittl.com>,
 Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nikolay Samokhvalov <samokhvalov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvp2nD4zndtHRfk30LzAXHPm7jorDo0SVtqaQiLtppFjaA%40mail.gmail.com>
Precedence: bulk

On Wed, 23 Jul 2025 at 23:08, Ilia Evdokimov
<ilya.evdokimov@tantorlabs.com> wrote:
> Given that, patch v11 still looks like the most appropriate version to me.

I spent a bit more time cleaning a few things up in this. With all the
complexity from the extra fields, I felt that a round of adjusting the
"double" types so they use the "Cardinality" typedef where appropriate
was in order. costsize.c isn't very good at doing that, but I didn't
see that as a reason to make the problem worse. The only other change
was in explain.c where I added a local "Memoize *" variable rather
than casting the "plan" variable to the subclass type in each usage.

I understand not everyone got what they wanted here, but I hope what's
been added is ok for the majority of people.

Thanks for working on this Ilia and Lukas.

David