Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v6wOi-00CH3o-6B
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Oct 2025 19:33:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v6wOZ-008GUs-Q5
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Oct 2025 19:33:48 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v6wOZ-008GUh-Fy
	for pgsql-hackers@lists.postgresql.org; Thu, 09 Oct 2025 19:33:48 +0000
Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v6wOX-000ugP-2W
	for pgsql-hackers@lists.postgresql.org;
	Thu, 09 Oct 2025 19:33:47 +0000
Received: by mail-lj1-x234.google.com with SMTP id
 38308e7fff4ca-3761e5287c9so11352631fa.2
        for <pgsql-hackers@lists.postgresql.org>;
 Thu, 09 Oct 2025 12:33:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1760038425; x=1760643225;
 darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=z75T6E/0szNWIdYAK8ZaPclax2LjTLtKWa2A2AnDN9Y=;
        b=G6Jn6gSiyMkfu5f7TbBz0Nx9gLnBOIomuK39AfUnG7/yALVPJ790F2/RoF9SlcaD9f
         iUgIzIsvQvpsgWbfzywCD4stlxIisrJF6IRHAty1J50KOlEDtnV+/6CIeNzrqdmURxLT
         cYvM+9LnFkPIOf4kJp+b0paOUz3cSeUN0rqwvCAsOtZ2PPtOQv+lzyugucyTlhhQbZLq
         maon1g4ut32zSNlG3k0H2ICmruCsnbw7T+ctWFc5RskbLDCC53YoXq0/1lFKfF/gaARs
         PSjvcC1V9+rWotNaPmbllSSKzcSvee6KFST7iC9EfYT6Q1cDlGffu6PNyQfAPe29B/eS
         xZiw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1760038425; x=1760643225;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=z75T6E/0szNWIdYAK8ZaPclax2LjTLtKWa2A2AnDN9Y=;
        b=sRdOv/63kbc7hnxiB8g3ywI6rp3hoZhUT47r5dUndVRoSwtYN9GD4knT4qUd6a4ugs
         dNUouOxj8UlwQaIAtzMy96xcW/M7KDLYzwWwg8lkIdi/A4KBfkERnlxHt2h3gTtIo4Lo
         dfVGwFIMC5lumU0nSQXVMdN6HWyHYEB0ypHLAiyMBh275jeu3YqriN6F/gG06UcCN4SS
         cGZF61F0Ctbco7cJQ9sLJ7tzwaWpV2eGMU1s4e6/4HsHLxmPBCYeXQ9UAh7NcoqksTry
         FiEPaPYO62ETW3jS5Pz46l5hPyskY9iOJKRexElUQ9RnbCmWUY+ubFaPVdcIXsXVL+8U
         EYtQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCVSNUOqLZOo/K9Ckq8OM1qi+yGlU9kqC3AOB5nk+v7qsfOYK6gP/6WAul59isZ4Hr/WePcii9Zgls4rr/XP@lists.postgresql.org
X-Gm-Message-State: AOJu0YxYZ4w+FHEIildQM4HSyoNtbuVSztQNcPlxAJF5wq8lkJzgHzmu
	xPyf1t0eZCuyPsA0ODd2XHSvF6gkD9fImG08veAUpkakMxb0UTnWJM5LHM/GSHyJDmxbQ6LnRmv
	K8JBzST0opp6Q1UXuqj/btGkEI7Z6zyg=
X-Gm-Gg: ASbGncv9dtk7oSUBO+G5QHzz3jA1Lf4DFRVaAxd4xAezpCAXrWpM4lrTt9JfvBmrg3A
	SpS8LiUwLhP2QtsNGgCo2YGKHqgyxK0B5N9Pk6EHW18+jYEg7+pyUmU4qyMF46bjLLCqpfuXXnJ
	5z55DV0/boHPI9fdVvxyb9ZKyQEFjc/iUl1gphwtaplDuvUo0wJpwQvw+kvcooOWEEvrD1JmIoz
	5of+EXfiWbymk+elBhrQIlmjydqsA1M0AHpur9Sr1mwQbMHz+5RdbMWaaqEfAo/9v52bD510m1E
	lPxCyb58b8qiRqwX3LifgO7CF7SzL+kq
X-Google-Smtp-Source: 
 AGHT+IHKu3y1KOAeeqE6OUanIySDmnFLNTOZk6tDYUfrq7l93IhCQqcQvPZR1YZTNTTVzEUQrY1L6sWBb7MudY/tNLI=
X-Received: by 2002:a2e:bcc7:0:b0:368:6a3f:35e9 with SMTP id
 38308e7fff4ca-37609e4d4c3mr22379471fa.36.1760038424906; Thu, 09 Oct 2025
 12:33:44 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CAEudQAq_zOSA2NUQSWePTGV_=90Uw0WcXxGOWnN-vwF046OOqA@mail.gmail.com>
 <2D90FFB0-C80A-4189-A5BF-C37F05E271D7@greg.burd.me>
 <CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a+XLQ@mail.gmail.com>
 <aOcaIr8QKMvbIlnA@paquier.xyz>
 <CAApHDvpn3bshX+_2t0NbJ263r1etcBdmkROjuJw8DvyZkMcXqg@mail.gmail.com>
 <aOcwU_0-U3zbNDki@paquier.xyz>
In-Reply-To: <aOcwU_0-U3zbNDki@paquier.xyz>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 10 Oct 2025 08:33:33 +1300
X-Gm-Features: AS18NWAIs8nP8eBUT0ttwJgnlTRIFBaLtvxT54sTMEbvJ2cHRnx7XaPq5E1LoDo
Message-ID: 
 <CAApHDvp=pEkO6LKfXKDjRNeQ1LkV7A5fsTn29ahUBXxmjyWPHg@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Michael Paquier <michael@paquier.xyz>
Cc: Greg Burd <greg@burd.me>, Ranier Vilela <ranier.vf@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvp%3DpEkO6LKfXKDjRNeQ1LkV7A5fsTn29ahUBXxmjyWPHg%40mail.gmail.com>
Precedence: bulk

On Thu, 9 Oct 2025 at 16:47, Michael Paquier <michael@paquier.xyz> wrote:
> Yes, a comment can be adapted here.  Sounds good to me.

Thanks. v3 looks good to me.

David