Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wF8sl-004mhn-0s for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Apr 2026 11:03:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wF8sk-008DXM-0d for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Apr 2026 11:03:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wF8sj-008DXE-2p for pgsql-hackers@lists.postgresql.org; Tue, 21 Apr 2026 11:03:05 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wF8sd-000000024aE-2n5h for pgsql-hackers@lists.postgresql.org; Tue, 21 Apr 2026 11:03:04 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-43d0deb7ad5so3310182f8f.2 for ; Tue, 21 Apr 2026 04:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776769377; cv=none; d=google.com; s=arc-20240605; b=ajW6B8JuiahY6wxLSWZ/10C8L80VAko8HjKzVNJRkPYpQTZJiSCgl4+8gcfbDyJmMy ZyZALvmOzeZSytq4ICRRhH5gKYirAi0+AXANB/rdemXbr5/NvA68740yuIIXnRAdZVnE aYuNIYSUsyQst2mxuShechde6N396tderxqTAEqCNTbZTUP8UQpxlfUBSSVOd1UMhLUx 0OJl5leNFOZJxvD+JbX5wH4yFayrIn1i2/4FoW1/LXcNgIt65xXQYLKAZ38mRJMwdfNO hsKfGnnbTINugTRsnTpAY9AeIqwE4icntUxkOPrwAmNS9OeCgw5YvmIDBg9x6MereHwS 1b/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=3ovWtMDEW4xH2WyPCKYmlgWW5AL6+i/Ex69Aj7/Ty84=; fh=hL9cAwQzUZi/GEM6HfW8wguQZ3ruWgZsWL0IeX0eV1c=; b=UCkEKx8Id99bRa5SQAl+FyyF1SBiRyhJRcqlONFGhw4TtEqmy5NwyNQxCQz4aczqZy y0SoD8aHoTiPeR4dhkzQLcCf424/rDeeyj4BL/Izzyn69t9T6T2jLdDsUbpiqHbrx9kS honnXhbYIdK9oFhI+ktouhzx9LTcFYA4dzh9jU/aC7XskoDyYdTlsgmzlLVivLa3Y5hL YolQVQM0hKcxwbbsb+Au1STkLAmuZeqNcZOq2dClcTgikFZ47E52K1hCxEbSDXIFEmZS hZtYrjfApYE1RKfy3PLbLpJ8eEBcM2g/FVCsIpQkOtJHJzZoXzymKaqV0QYv7VqQ6RIh ESQA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776769377; x=1777374177; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3ovWtMDEW4xH2WyPCKYmlgWW5AL6+i/Ex69Aj7/Ty84=; b=n/+IrruyU20/XsrBYy6oQPqEISa43xyZVsDwTCBxWKq7HM13tsjO1YvlExSFSxenDf yhpT8c/gHPTl5gNjzZodRNC8MSSKagMp2Q4VhDtOIBF5NdCqAEh8MMjs0VVxVNhroxnh S9xryDGorCBtEL/BUK48yMTNinBg0pWiOlNyhkmNExqLtrhokRgoqBjf43x0ysNIkNzg B3i5j6s3IZvX20pPHriiJpJkXIPbzkmo+iuEWHEuzO36jfAxIUL8DW5JELeCIDjnCdRi 9XnRC1+jUPcf1HiEhNuGbP5UDmwBf1eO0r7+3oI5g3TBq7aaR4wwYgDJcU5A20S1Nl2O 6s1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776769377; x=1777374177; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3ovWtMDEW4xH2WyPCKYmlgWW5AL6+i/Ex69Aj7/Ty84=; b=KNZBaXoTH5dBP8JiWY/RNU9p+lM7LK7YT0Y1BeYL9NNzvECPYWefKSrJN7nMbuLC+s +hRw8YLvHhQw2dLylljhRm8M/jAbQWC5QNG2Hwq/J+VG2V+3d1O8HiC8l2NbS/z6hg+B aOnq/FS8iYPCzdJl34aHguhay9dW8x/3O2XH2A/LrUSXMHP3R2Vh1gmoFDbhLYARwqXQ LJVZFKPolwf+zSx/m1lYGEFnTfvwpaX2wsRHuJED/OEjDCTdKCXY89UcoEa9pdBLmY4B 0KoOvYjuv06A5SRGErVHWKapf/K0tAa10XMdLzyjYvJ9Ts0eyUVaaevpB74+c3KbKRzo q3Rw== X-Forwarded-Encrypted: i=1; AFNElJ+7rKY0PEuESTHp1ZDA9BuyActRlUayup9gEY7ivhsoXmcoQ2nXvXqF+KvzOzqekmGlN+VwPRat8PhXP1rw@lists.postgresql.org X-Gm-Message-State: AOJu0YwakmyEktcawsRz6f+OFHwCck7sq/BshqcuLTbMdvFj76f+qs5V jd4yqurtXNv+y2IfmGvTgvRF0Iim5H7Dhjwz4Nw2B69Gil9jvyvF0m3kceT+LeyvItv94XaG+3n LP56jCoHAA5ptB+nZN5d1BzGia4Y9p50= X-Gm-Gg: AeBDievXFRrC+tQlFIU5dKTAisItqb+symFYUsIMssoc8fLTPG+K5mHO/uqaFgGyIHe ELS61MA54c4E9ZcuOPOcPKN+CllM5WtNuSphMDbK7pbAOweJULxnennl7upzeJgCWHzNHrqiWjG s9NSjIRGBJn3+54KqQGYv+cXbLGBdiUF6+SIIjovWFXEEg+D+5L+GpedYsaGhjsKsF/q1C2c3l8 CrbSeSAJq3q3E4+4Ms7zXuH0vAerSP3KC4CV1et4CN/QCieXZaQKn0fav7hv8dRMGmeLyA35Not EHTy8TKE9g36HZt8ywHbTgZANwJZIF5udPePbcvCFaNPK1dX+JPkWyvtoim6Sp9B96gzUaAcCZ9 U89GZkreg X-Received: by 2002:a5d:64e7:0:b0:43d:77e1:6a66 with SMTP id ffacd0b85a97d-43fe3db2b89mr27517315f8f.8.1776769377015; Tue, 21 Apr 2026 04:02:57 -0700 (PDT) MIME-Version: 1.0 References: <202603031015.s6lmrgi7x67r@alvherre.pgsql> <43421A9F-BA0D-4BB8-B9DB-61EB5C2D686F@gmail.com> In-Reply-To: <43421A9F-BA0D-4BB8-B9DB-61EB5C2D686F@gmail.com> From: David Rowley Date: Tue, 21 Apr 2026 23:02:44 +1200 X-Gm-Features: AQROBzDYubDZo5c1FyEEEbsIjuMFyox9ZZ5Pcd30sshCLSyP3OYdIZvUeiOaYT0 Message-ID: Subject: Re: Cleanup shadows variable warnings, round 1 To: Chao Li Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= , Postgres hackers , Peter Eisentraut , Peter Smith Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 21 Apr 2026 at 19:02, Chao Li wrote: > PFA v8 - rebased and fixed a few new occurrences. Which of these are new to v19? Can you separate those ones out? IMO, we should commit at least those, as those won't cause any backpatching pain. I recall that I was motivated to commit the -Wshadow=compatible-local ones as there'd been a few bugs with shadowed variables. There'd be more of an argument to cause all this churn if it was for something more than to make things better for clang users. David