public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: James Hunter <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Move clause_sides_match_join() into pathnode.h
Date: Tue, 15 Oct 2024 21:20:48 +1300
Message-ID: <CAApHDvpSBsvTo7wnYYSbx9ixMJnCBSndrvAmLBL--fzST6=9_g@mail.gmail.com> (raw)
In-Reply-To: <CAJVSvF5V0VKna=K3cK5jAnVw1widV1apBA7L1B+UG0YSPn2dyw@mail.gmail.com>
References: <CAJVSvF7Nm_9kgMLOch4c-5fbh3MYg=9BdnDx3Dv7Fcb64zr64Q@mail.gmail.com>
	<CAApHDvocwWdcXZEGRVtL3iv_ZAbaB+Gh7MGk8AovhLCMxskHrA@mail.gmail.com>
	<CAJVSvF5V0VKna=K3cK5jAnVw1widV1apBA7L1B+UG0YSPn2dyw@mail.gmail.com>

On Fri, 11 Oct 2024 at 04:25, James Hunter <[email protected]> wrote:
> Moved into restrictinfo.h, instead, in next revision.

Thanks. Pushed.

> > (I really wonder how much the inlining is giving us given that the
> > function itself calls other non-inlineable functions)
>
> I wondered the same! But, at least the branch can be inlined?

Do you mean function call?  As far as I see it, that's the only
advantage. There are no branches that can be eliminated from
constant-folding.

I imagine the original version was only inlined to help coax the
compiler into inlining, which I imagine it would have done anyway if
there was just a single usage of the static function. Probably the
analyzejoins.c version just copied the original joinpath.c version. I
didn't check the history to know if that's actually true.

David

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Move clause_sides_match_join() into pathnode.h
  In-Reply-To: <CAApHDvpSBsvTo7wnYYSbx9ixMJnCBSndrvAmLBL--fzST6=9_g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox