Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v4QQP-00F1lH-Sg
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 21:01:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v4QQN-009Mgq-Sv
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 21:01:16 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v4QQN-009Mey-Iv
	for pgsql-hackers@lists.postgresql.org; Thu, 02 Oct 2025 21:01:16 +0000
Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v4QQG-00168Y-0F
	for pgsql-hackers@lists.postgresql.org;
	Thu, 02 Oct 2025 21:01:15 +0000
Received: by mail-lf1-x12e.google.com with SMTP id
 2adb3069b0e04-57bd482dfd2so1636574e87.2
        for <pgsql-hackers@lists.postgresql.org>;
 Thu, 02 Oct 2025 14:01:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1759438867; x=1760043667;
 darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=1QSUgGSmCtBeZzDgZJrvPmqkYwSopbpjTu5LckIkLlc=;
        b=HHCxbZiXfHbfdctd6WWDxMeFsrAPbmX752ZZzOGHKPRPq8CYQaFe36gy+NbYcmpwVu
         9IWzg/FgFAskSfPY9N57LTehkAmAsUCTNGnuPFouDYVsjqXHaVrm/co6hU0mBN0995kH
         4hmAoeplOvpOaErvHRNvK8x7Ax84oD7pIoKgkZA2nR6W31/P2WJ4EoKLICdUOOmzYxBB
         S+j/c3TGQWUtbqKegc9C2tMH8r37D8/0FPCRNnO4Gq8pn2Ajbo0Qcwl7jqAx3LzCGt4O
         VGjKt3AiyIIB5PRnsJjTKl5mYQgLerjM7Ea+O6ivgD/IkKsfUiRS8jl0Am6iGkayLjki
         OVEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1759438867; x=1760043667;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=1QSUgGSmCtBeZzDgZJrvPmqkYwSopbpjTu5LckIkLlc=;
        b=bZ6EN+A//88m6xedAAAmQVByar48z17AMque+xf6nhQN0R0ddd1VF/Xbdw/fgPoRAa
         iDfoR6qiJbtPnb70SMq9a2C6lUpa+jqUbYMmamc7uYNMj8c0fw7PxH6k21iU87fvBodG
         hfOBDU2wZqKhxUIkIY4RM3mOfTrkU6VxTb5mL9GbWcYpuXwAwM870XTrHr9uJalEVVkf
         yj5gtC0sfvG4P6x1NWex/5E8dTe0oCBs8JBP9o/vCqBGoL5TGNxAHemlkMlTNyEL7wHd
         uGjaJiSLXpchq3R3DJEfa7PkyHwWgnIz7AoInahJJlqnBuDq/BN7LjAZ8FcvaB8PWZ5x
         IR1A==
X-Forwarded-Encrypted: i=1;
 AJvYcCWuS6NLVKRGWyObz9uoN5jHBNWYn8+lGOa+tc7EJuQnAKyAaIkMkjU/IFMYo6jrtiBy5cv5deySij+kbSes@lists.postgresql.org
X-Gm-Message-State: AOJu0Yz8oTWatJTmIINkufDzGksYPCLeMc/6Wndc4cj8h+C6LyTM6ONz
	f7yVtQ1d/hShBlYOUSI35xnYZF7bcVhb6wfu42B0C/t4ekNs//i7zVbXcR4/zEOHTly04ocW2o0
	25bzdaWo1CP2EITL87QuDX02gAQyqorFPXp9k
X-Gm-Gg: ASbGncvkjryZdHJbwS3pSuwp0gy8SAf3GaTxDyNpH1lWVy478ex0V2kr8/MaWjSAayy
	ABBNbRzZRx8b+CdwozBu0eFtQmb3KLSTvK8HBf9h5yIMOC7He92S9w99ICJQJCb/uu38YXlhhD0
	n/EBfzV1OUNHHNpYPo21urqjmBnLzIXqqIMDlq2mj8OKTlOz8faiS+cExqySgC41eW7O20JpoCS
	304/wh2Ssfr+d1VAzf6BqtsXc+4ADRM1P7KybCZVzFpYsS/jQGv9HQrT5vvyaNuXMW7dUrWTI06
	II6nrkMenUcSqb1UIdF0RMhDlXr3LlEL
X-Google-Smtp-Source: 
 AGHT+IGmc5Yc+IPz3Yokvh3zBgbZLAYOxIsSBtsfOE1RqWQdQ+1+DzaDm7vRVMZafKsjjEYuwupdOIAjMADN84Aw4h0=
X-Received: by 2002:a05:6512:128b:b0:58a:f815:b4d4 with SMTP id
 2adb3069b0e04-58cb9f0b26amr147502e87.25.1759438866894; Thu, 02 Oct 2025
 14:01:06 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
 <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me>
 <CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
 <aNxpxE6a9G3sbfrm@paquier.xyz>
 <CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
 <aNyiu0fKRqihdwpV@paquier.xyz>
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
 <aNy4xV4Fa1m9lyXX@paquier.xyz>
 <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se>
 <CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com>
 <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
In-Reply-To: <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 3 Oct 2025 10:00:54 +1300
X-Gm-Features: AS18NWBtVY5A4q2aGBCL3U4R_-4a6plAvxbtYsO-mxpuLKSmOdTBhpdit3hOk9Q
Message-ID: 
 <CAApHDvpasn7pVYttJ3FZiYLKZaoETBN+VagO5ZMuhFC=8ZM6rg@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Greg Burd <greg@burd.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvpasn7pVYttJ3FZiYLKZaoETBN%2BVagO5ZMuhFC%3D8ZM6rg%40mail.gmail.com>
Precedence: bulk

On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> wrote:
> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
> since that is a STRICT function, making the test for NULL superfluous code:

I didn't notice that was marked as strict. It would be good to get rid
of those lines in that case.

Thanks

David