MIME-Version: 1.0
References: <CAApHDvoCdjo8Cu2zEZF4-AxWG-90S+pYXAnoDDa9J3xH-OrczQ@mail.gmail.com>
 <1104459.1695938385@sss.pgh.pa.us> <CAApHDvoMLP3ZpAE4_zivkT1GJU293BT7Yy-Kmo-kxU+Nc_-EWg@mail.gmail.com>
In-Reply-To: <CAApHDvoMLP3ZpAE4_zivkT1GJU293BT7Yy-Kmo-kxU+Nc_-EWg@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 9 Oct 2023 10:26:38 +1300
Message-ID: <CAApHDvpzRrmzA2nv0N_ehMD1ajDQto+EpjLzfWoOW=qVu6eRRw@mail.gmail.com>
Subject: Re: Does anyone ever use OPTIMIZER_DEBUG?
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvpzRrmzA2nv0N_ehMD1ajDQto%2BEpjLzfWoOW%3DqVu6eRRw%40mail.gmail.com>
Precedence: bulk

On Tue, 3 Oct 2023 at 12:29, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Fri, 29 Sept 2023 at 10:59, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > We could also discuss keeping the "tracing" aspect of it, but
> > replacing debug_print_rel with pprint(rel), which'd still allow
> > removal of all the "DEBUG SUPPORT" stuff at the bottom of allpaths.c.
> > That's pretty much all of the maintenance-requiring stuff in it.
>
> To assist discussion, I've attached a patch for that.

It looks like nobody is objecting to this.  I understand that not
everyone who might object will have read this email thread, so what I
propose to do here is move along and just commit the patch to swap out
debug_print_rel and use pprint instead.  If that's done now then there
are around 10 months where we could realistically revert this again if
someone were to come forward with an objection.

Sound ok?

David