Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v4cg8-002m5W-Ix
	for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Oct 2025 10:06:20 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1v4cg6-00CUbQ-Kx
	for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Oct 2025 10:06:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v4cg6-00CUaB-B0
	for pgsql-hackers@lists.postgresql.org; Fri, 03 Oct 2025 10:06:19 +0000
Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1v4cg4-000BBP-2N
	for pgsql-hackers@lists.postgresql.org;
	Fri, 03 Oct 2025 10:06:18 +0000
Received: by mail-lf1-x131.google.com with SMTP id
 2adb3069b0e04-57e36125e8aso1959477e87.2
        for <pgsql-hackers@lists.postgresql.org>;
 Fri, 03 Oct 2025 03:06:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1759485976; x=1760090776;
 darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=odb8LbS/bR/iIRae5HZO7snFz5Rc5IVq16ST228jdcY=;
        b=dByDAr2eI4jVwIZwkH1S4BuNHP8hIw0Ci4ClkEO0T1ipf24EaR/Uezam8W7goZE+lQ
         1tIqAmte04N2hJiDMXgG5OzmsjT3YCtig92gP4WeDiv17bmmdgTY/ozEJsN66Rs0bjAu
         WXcZEJMAMaB0sZ9++gNcFrjFPpmkvA+vcCk3PgI/LFjF6/Mz74Prsmi3ZjPIkTGOC6Jl
         CPSqjXcQ8SZCGO29U6GosHUHE5TCJvVluQn46AKb7pwxWWaw4JTY1mYMQFa5pBnJhqL8
         l/70GDh01t93B4jkQh8pj9QqVpVhReIiy9s31NYGa/kyTatT7vlBg+lrnm60EB9581Il
         T54w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1759485976; x=1760090776;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=odb8LbS/bR/iIRae5HZO7snFz5Rc5IVq16ST228jdcY=;
        b=gnoVEmzBvqxCuoUuMpZJ8k8eIl93SK7MdOjCj15+u2Qz3e4D57hCr9nFqTybZeagMx
         /a7galSkgCZUJhPV3TcuZq1pamXEwG5tyAQ+BcqTHwb3sqamd1EZL8LcsdP0T/GGPe8+
         kSXlxnpXYhVrIvDM0fKGzriossJpKqd0HMhHJKbM4DxVx6Ao6BGJEHzYfDtAk9tArkGQ
         gcpDNeikYumNvEzrK/HZmoc8oMWBrjmU6f3ibDE0d1nRJALbjKxhZgg8RRkY91zMYxrj
         E5Kw/JFEsUcoBCpJ5GVIN7s9Sj87yxCFM+h5/pS+q7AFlcvB8XH7s3DkIsWPSr179fj3
         SeLw==
X-Forwarded-Encrypted: i=1;
 AJvYcCUc412MG0C0w4VzxWnd2C7HxuUxREgGbLjrPX63SSdq9lR4n9RsRqzroNHdDTOf3mZ70iyeWqeIvUVnPR+f@lists.postgresql.org
X-Gm-Message-State: AOJu0YwZ3mSJhOHpS5dvuOd6RHVbbDzvXP+ARymuFvWcMZ95j1aQPNo4
	iGZ7x/18vKqMQpbKRhl1zU3S6ZuP/A/IO6C+C0L33P0rxVPRsnq2zvus5sFiiuhJPsj6fs9WXqH
	bvXQ0mKOX2Vd1pVZ1H3pi3H0oZMuUCb+ek0sR
X-Gm-Gg: ASbGncvUbX+lS++vZ8JabuLiXi1RWY6O2Oob6XZwf+LJ/x0WM6z2e8Qb+3B6ENmjOUg
	TKgEsQiM3Tkzh9RnMwDJ1K9ebJG2c2dDKU1G1/EI8s/NgWtUaundjMUymxeRHrZ/Y3NT2i6vDEA
	ktWRafpt1pWuo8+70LAGrwEwg2utMECuq7s/uIhDIIfGwglUwfd7mTKPijMfxhMcPc3PXCg8sua
	jd038RKckSBm3LRHjYkUF6AwFyBa6iCfQikEB4b7qdkVQCSckH7wSHiK46mFC+BJEKLP1YyWaWM
	hd2DYkWR/fbtDDeJQQB5Cs6051eYuxzy
X-Google-Smtp-Source: 
 AGHT+IHEhtYDHJFNWNtXd+ErHTKUn1SSKpChS7jdevqOJrrUsi/QrGF0U1sVUEhXCGqo+NXz54+mICKEniXQy/vfI68=
X-Received: by 2002:a05:6512:b27:b0:57e:f60:2330 with SMTP id
 2adb3069b0e04-58cb9d1acf0mr660607e87.21.1759485975431; Fri, 03 Oct 2025
 03:06:15 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
 <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me>
 <CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
 <aNxpxE6a9G3sbfrm@paquier.xyz>
 <CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
 <aNyiu0fKRqihdwpV@paquier.xyz>
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
 <aNy4xV4Fa1m9lyXX@paquier.xyz>
 <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se>
 <CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com>
 <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
 <CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com>
 <197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se>
In-Reply-To: <197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 3 Oct 2025 23:06:02 +1300
X-Gm-Features: AS18NWDzUZFiAyJc9MC_f7WuvcvIc0V8vUdaSi11yHNnmho5X7c2GWZ4MFe6H8c
Message-ID: 
 <CAApHDvq46UbuZF4fuG0r2wZ1raopuhZnGs+b7en_hCaNqbtK8Q@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Greg Burd <greg@burd.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvq46UbuZF4fuG0r2wZ1raopuhZnGs%2Bb7en_hCaNqbtK8Q%40mail.gmail.com>
Precedence: bulk

On Fri, 3 Oct 2025 at 21:26, Daniel Gustafsson <daniel@yesql.se> wrote:
> +1 for removing the NULL checks and
> simplifying the code.

Thank you both for looking. Pushed.

David