MIME-Version: 1.0
References: <A4BC563C-0CA3-4EF3-952A-EA41F9E5BF1E@gmail.com>
 <CAApHDvoQKY8zHb1LZBuYZBRszi0qVmTaV_zFup=A9xqRpJWMRQ@mail.gmail.com>
 <pse3eru75b5skbvc7jjrf7origavqojc6nqtwdrr7z6sjkyxfo@siklvj643v4f>
 <BB69B882-5401-45CE-919E-8A78511EDABC@gmail.com>
 <CAApHDvogTSD_G1nkJqOvO3gZFACQUCbKg6U7yBB48r5RMaR7-Q@mail.gmail.com>
 <CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com>
 <1151393.1781734980@sss.pgh.pa.us> <1174236.1781736349@sss.pgh.pa.us>
 <CAApHDvpE1Jx=NrwUCihrfP+Dmkfn6kUkpCZYC10Yo+wkMu3ssQ@mail.gmail.com>
In-Reply-To: 
 <CAApHDvpE1Jx=NrwUCihrfP+Dmkfn6kUkpCZYC10Yo+wkMu3ssQ@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Thu, 18 Jun 2026 11:37:18 +1200
Message-ID: 
 <CAApHDvq6FaC441C=G4Q9fNZQ-OKmaeW8yP0YjHpjyjBeWhj3+g@mail.gmail.com>
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000000767a706547b8b34"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvq6FaC441C%3DG4Q9fNZQ-OKmaeW8yP0YjHpjyjBeWhj3%2Bg%40mail.gmail.com>
Precedence: bulk

--0000000000000767a706547b8b34
Content-Type: text/plain; charset="UTF-8"

On Thu, 18 Jun 2026 at 11:06, David Rowley <dgrowleyml@gmail.com> wrote:
> Just starting to look now, but I suspect that this code in
> llvmjit_deform.c needs to be updated now that we have virtual
> generated columns.

I've not fully processed all this code yet. I've still not worked out
why the loop that sets guaranteed_column_number doesn't break when it
finds something non-guaranteed.

Here's a draft patch I was experimenting with. It seems to fix the
issue. I need to spend more time to check it's correct.

David

--0000000000000767a706547b8b34
Content-Type: text/plain; charset="US-ASCII";
	name="fix_jit_deform_for_virtual_generated_cols.patch"
Content-Disposition: attachment;
	filename="fix_jit_deform_for_virtual_generated_cols.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mqipn66n0>
X-Attachment-Id: f_mqipn66n0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2ppdC9sbHZtL2xsdm1qaXRfZGVmb3JtLmMgYi9zcmMv
YmFja2VuZC9qaXQvbGx2bS9sbHZtaml0X2RlZm9ybS5jCmluZGV4IDEyNTIxZTNlNDZhLi42MmE3
ZTFjMzdmYiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvaml0L2xsdm0vbGx2bWppdF9kZWZvcm0u
YworKysgYi9zcmMvYmFja2VuZC9qaXQvbGx2bS9sbHZtaml0X2RlZm9ybS5jCkBAIC0xMDksMjIg
KzEwOSwyNyBAQCBzbG90X2NvbXBpbGVfZGVmb3JtKExMVk1KaXRDb250ZXh0ICpjb250ZXh0LCBU
dXBsZURlc2MgZGVzYywKIAkgKi8KIAlmb3IgKGF0dG51bSA9IDA7IGF0dG51bSA8IGRlc2MtPm5h
dHRzOyBhdHRudW0rKykKIAl7Ci0JCUNvbXBhY3RBdHRyaWJ1dGUgKmF0dCA9IFR1cGxlRGVzY0Nv
bXBhY3RBdHRyKGRlc2MsIGF0dG51bSk7CisJCUNvbXBhY3RBdHRyaWJ1dGUgKmNhdHQgPSBUdXBs
ZURlc2NDb21wYWN0QXR0cihkZXNjLCBhdHRudW0pOworCQlGb3JtX3BnX2F0dHJpYnV0ZSBhdHRy
ID0gVHVwbGVEZXNjQXR0cihkZXNjLCBhdHRudW0pOwogCiAJCS8qCiAJCSAqIElmIHRoZSBjb2x1
bW4gaXMgZGVjbGFyZWQgTk9UIE5VTEwgdGhlbiBpdCBtdXN0IGJlIHByZXNlbnQgaW4gZXZlcnkK
IAkJICogdHVwbGUsIHVubGVzcyB0aGVyZSdzIGEgIm1pc3NpbmciIGVudHJ5IHRoYXQgY291bGQg
cHJvdmlkZSBhCi0JCSAqIG5vbi1OVUxMIHZhbHVlIGZvciBpdC4gVGhhdCBpbiB0dXJuIGd1YXJh
bnRlZXMgdGhhdCB0aGUgTlVMTCBiaXRtYXAKLQkJICogLSBpZiB0aGVyZSBhcmUgYW55IE5VTExh
YmxlIGNvbHVtbnMgLSBpcyBhdCBsZWFzdCBsb25nIGVub3VnaCB0bwotCQkgKiBjb3ZlciBjb2x1
bW5zIHVwIHRvIGF0dG51bS4KKwkJICogbm9uLU5VTEwgdmFsdWUgZm9yIGl0IG9yIHRoZSBjb2x1
bW4gaXMgYSB2aXJ0dWFsIGdlbmVyYXRlZCBjb2x1bW4uCisJCSAqIFRoYXQgaW4gdHVybiBndWFy
YW50ZWVzIHRoYXQgdGhlIE5VTEwgYml0bWFwIC0gaWYgdGhlcmUgYXJlIGFueQorCQkgKiBOVUxM
YWJsZSBjb2x1bW5zIC0gaXMgYXQgbGVhc3QgbG9uZyBlbm91Z2ggdG8gY292ZXIgY29sdW1ucyB1
cCB0bworCQkgKiBhdHRudW0uCiAJCSAqCiAJCSAqIEJlIHBhcmFub2lkIGFuZCBhbHNvIGNoZWNr
ICFhdHRpc2Ryb3BwZWQsIGV2ZW4gdGhvdWdoIHRoZQogCQkgKiBjb21iaW5hdGlvbiBvZiBhdHRp
c2Ryb3BwZWQgJiYgYXR0bm90bnVsbCBjb21iaW5hdGlvbiBzaG91bGRuJ3QKIAkJICogZXhpc3Qu
CiAJCSAqLwotCQlpZiAoYXR0LT5hdHRudWxsYWJpbGl0eSA9PSBBVFROVUxMQUJMRV9WQUxJRCAm
JgotCQkJIWF0dC0+YXR0aGFzbWlzc2luZyAmJgotCQkJIWF0dC0+YXR0aXNkcm9wcGVkKQorCQlp
ZiAoYXR0ci0+YXR0Z2VuZXJhdGVkID09IEFUVFJJQlVURV9HRU5FUkFURURfVklSVFVBTCkKKwkJ
CWJyZWFrOworCisJCWlmIChjYXR0LT5hdHRudWxsYWJpbGl0eSA9PSBBVFROVUxMQUJMRV9WQUxJ
RCAmJgorCQkJIWNhdHQtPmF0dGhhc21pc3NpbmcgJiYKKwkJCSFjYXR0LT5hdHRpc2Ryb3BwZWQp
CiAJCQlndWFyYW50ZWVkX2NvbHVtbl9udW1iZXIgPSBhdHRudW07CiAJfQogCkBAIC0zOTIsNiAr
Mzk3LDggQEAgc2xvdF9jb21waWxlX2RlZm9ybShMTFZNSml0Q29udGV4dCAqY29udGV4dCwgVHVw
bGVEZXNjIGRlc2MsCiAJZm9yIChhdHRudW0gPSAwOyBhdHRudW0gPCBuYXR0czsgYXR0bnVtKysp
CiAJewogCQlDb21wYWN0QXR0cmlidXRlICphdHQgPSBUdXBsZURlc2NDb21wYWN0QXR0cihkZXNj
LCBhdHRudW0pOworCQlGb3JtX3BnX2F0dHJpYnV0ZSBhdHRyID0gVHVwbGVEZXNjQXR0cihkZXNj
LCBhdHRudW0pOworCiAJCUxMVk1WYWx1ZVJlZiB2X2luY2J5OwogCQlpbnQJCQlhbGlnbnRvID0g
YXR0LT5hdHRhbGlnbmJ5OwogCQlMTFZNVmFsdWVSZWYgbF9hdHRubyA9IGxfaW50MTZfY29uc3Qo
bGMsIGF0dG51bSk7CkBAIC00MzYsNyArNDQzLDggQEAgc2xvdF9jb21waWxlX2RlZm9ybShMTFZN
Sml0Q29udGV4dCAqY29udGV4dCwgVHVwbGVEZXNjIGRlc2MsCiAJCSAqIGludG8gYWNjb3VudCwg
YmVjYXVzZSBpZiB0aGV5J3JlIHByZXNlbnQgdGhlIGhlYXB0dXBsZSdzIG5hdHRzCiAJCSAqIHdv
dWxkIGhhdmUgaW5kaWNhdGVkIHRoYXQgYSBzbG90X2dldG1pc3NpbmdhdHRycygpIGlzIG5lZWRl
ZC4KIAkJICovCi0JCWlmIChhdHQtPmF0dG51bGxhYmlsaXR5ICE9IEFUVE5VTExBQkxFX1ZBTElE
KQorCQlpZiAoYXR0LT5hdHRudWxsYWJpbGl0eSAhPSBBVFROVUxMQUJMRV9WQUxJRCB8fAorCQkJ
YXR0ci0+YXR0Z2VuZXJhdGVkID09IEFUVFJJQlVURV9HRU5FUkFURURfVklSVFVBTCkKIAkJewog
CQkJTExWTUJhc2ljQmxvY2tSZWYgYl9pZm5vdG51bGw7CiAJCQlMTFZNQmFzaWNCbG9ja1JlZiBi
X2lmbnVsbDsKQEAgLTYxNCw2ICs2MjIsNyBAQCBzbG90X2NvbXBpbGVfZGVmb3JtKExMVk1KaXRD
b250ZXh0ICpjb250ZXh0LCBUdXBsZURlc2MgZGVzYywKIAkJCWtub3duX2FsaWdubWVudCArPSBh
dHQtPmF0dGxlbjsKIAkJfQogCQllbHNlIGlmIChhdHQtPmF0dG51bGxhYmlsaXR5ID09IEFUVE5V
TExBQkxFX1ZBTElEICYmCisJCQkJIGF0dHItPmF0dGdlbmVyYXRlZCAhPSBBVFRSSUJVVEVfR0VO
RVJBVEVEX1ZJUlRVQUwgJiYKIAkJCQkgKGF0dC0+YXR0bGVuICUgYWxpZ250bykgPT0gMCkKIAkJ
ewogCQkJLyoK
--0000000000000767a706547b8b34--