public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: Yura Sokolov <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Subject: Re: Fix BUG #17335: Duplicate result rows in Gather node
Date: Tue, 25 Jan 2022 21:20:25 +1300
Message-ID: <CAApHDvqEnKn_Y4nNPqCPRLkwxZWS3tNPU6VxB9P1QtiN8y3onw@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvrxnqQdqXQ1BxTRP5V+8pxBF+GMMhuJ0Qq8J2bT=Uwi+A@mail.gmail.com>
References: <[email protected]>
	<CAApHDvqMUshyci-F2CZ-jkSbmuhzCudhF5t5_z0shFxd9D_hVg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAApHDvrxnqQdqXQ1BxTRP5V+8pxBF+GMMhuJ0Qq8J2bT=Uwi+A@mail.gmail.com>

On Tue, 25 Jan 2022 at 20:03, David Rowley <[email protected]> wrote:
>
> On Tue, 25 Jan 2022 at 17:35, Yura Sokolov <[email protected]> wrote:
> > And another attempt to fix tests volatility.
>
> FWIW, I had not really seen the point in adding a test for this.   I
> did however see a point in it with your original patch. It seemed
> useful there to verify that Gather and GatherMerge did what we
> expected with 1 worker.

I ended up pushing just the last patch I sent.

The reason I didn't think it was worth adding a new test was that no
tests were added in the original commit.  Existing tests did cover it,
but here we're just restoring the original behaviour for one simple
case.  The test in your patch just seemed a bit more hassle than it
was worth. I struggle to imagine how we'll break this again.

David

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix BUG #17335: Duplicate result rows in Gather node
  In-Reply-To: <CAApHDvqEnKn_Y4nNPqCPRLkwxZWS3tNPU6VxB9P1QtiN8y3onw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox