MIME-Version: 1.0
References: 
 <CAApHDvq=eEdw2Qp+aSzSOtTSe+h0fnVQ55CcTNqBkLDYiRZmxw@mail.gmail.com>
 <278B9FE3-F349-4494-99C5-483105C1C999@gmail.com>
 <CAApHDvoALVPgVSCuGdAfNUbxx_NacnAd0nuj8Hi=_-61AEqzaQ@mail.gmail.com>
 <1900289.1776212948@sss.pgh.pa.us>
 <CAApHDvq4_WDfTaWX6nHU8TV+no+aD1zjLphza685Ek7=xgGzew@mail.gmail.com>
 <1913188.1776220247@sss.pgh.pa.us>
 <CAApHDvp=fhr8ksuGyXkwYPXQpYvJ38YMhHvx6JmdD39cAvNRhw@mail.gmail.com>
 <ee61a3c6-5d99-4b3e-87de-4a01eed449b2@eisentraut.org>
In-Reply-To: <ee61a3c6-5d99-4b3e-87de-4a01eed449b2@eisentraut.org>
From: David Rowley <dgrowleyml@gmail.com>
Date: Sat, 18 Apr 2026 19:53:40 +1200
Message-ID: 
 <CAApHDvqJ_ZpO366cGMS2uheTzy0Kh8Qgk2hx+unfyKy1ifR6xw@mail.gmail.com>
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqJ_ZpO366cGMS2uheTzy0Kh8Qgk2hx%2BunfyKy1ifR6xw%40mail.gmail.com>
Precedence: bulk

On Thu, 16 Apr 2026 at 07:17, Peter Eisentraut <peter@eisentraut.org> wrote:
> Depending on what you end up doing, maybe a sprinkling of pg_nodiscard
> could be appropriate.

Yeah maybe. It wouldn't do any harm, at least.

I didn't do that in the patch I just sent as it felt like something we
should do or not do for all the bitmapset functions it's relevant for.
REALLOCATE_BITMAPSETS is meant to give us a stronger guarantee of
people forgetting to do this, as it would cause a breakage if there
were multiple pointers to the same set and only one of them got
updated.

David