Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tzkah-0067fl-TC
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Apr 2025 23:00:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tzkag-007mtO-I8
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Apr 2025 23:00:18 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1tzkag-007mtG-8S
	for pgsql-hackers@lists.postgresql.org; Tue, 01 Apr 2025 23:00:18 +0000
Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1tzkae-002RQh-16
	for pgsql-hackers@lists.postgresql.org;
	Tue, 01 Apr 2025 23:00:17 +0000
Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-30bfca745c7so53275291fa.0
        for <pgsql-hackers@lists.postgresql.org>; Tue, 01 Apr 2025 16:00:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1743548415; x=1744153215; darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=3RmULpONzPz/L1HOllHgMlNKdl37vwGAb3g2ApDZCvM=;
        b=dEwla2h51tWmcma6/PkcflIpfmGg6gCo4nBNDLnbRqW4sA7NiRF/YJfN29INDq4/iJ
         JttrxKQzjYhBnPvQrZHj0q/+0O6VJDykh4gMAURfO52jcYZks6GMb3u+wXr2k9xvI368
         QTUDvSJOk9BfS7RbS5h7DlD1JpOdt0UN0H8FhSHCmbMJaMobycKLLttypq4B8Hkdhzae
         ILT19HLSD/qI1Ea9HtTxFqqvzLOtqUqKX1nZ44wbs8UTS1+Q4hzmgsDf5SDZ7c8jjxCH
         PmUBUInirXPKrXc8tGWZ74PbXAy9kICVpIXTYGZ5NCWxOmOw9uRghtUk+9uz5ddG2CfW
         ZN3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1743548415; x=1744153215;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=3RmULpONzPz/L1HOllHgMlNKdl37vwGAb3g2ApDZCvM=;
        b=esitPaj/JijT1kg7HNR4cUD+opb+M5yYWnlNNDak7pXCCqcKcDu5865OylBEkXRpQs
         yx0Gcaf0VbywlhcdXYAUbVZtrEe4ddlkw/6nXl9DVS1kc1umttJwxgvI4a/Xc/ttUJoQ
         HoCjzjJU+gRi7X5t1D253ffDSBZNkQEr11NM1l4bBiRsjrtrXU0MZqiDFER7qeEvUPao
         t/cua9yZgYJ+YDcfK3Pg7GMqewCCF77UML0V3N4bKWkiX5Uh7cgemlwRrFq3xu9F/I9W
         ME8gVpKcg5px26dAYdBC7oIzx9dpKAE8/LDRNUkW85I/uv72s+WH8m8gfWGDI+KhqSLm
         fDCg==
X-Gm-Message-State: AOJu0YyHyxszLNOBCPF/XDiZw9U2/MGk4GJR2r/lX/dRXQTZdbg8MlZW
	6L0372wUQlo6gC+s+yCopsjQHORdflCqVIkDeRy1oyrawG+98usB+XydhHjPeZQzNki0iZh+6vJ
	eWv62FNVRK2evsbctt6RowBjU2qiVdA==
X-Gm-Gg: ASbGncsPg1BxUNqWh5Z42WDDCStit7wyWlVvWGim8rtPNdD/r2FCus4EFQf5V+FomZZ
	0nxcbln4C+8ptHmCkS5/RUO0uax4p0sfioNS9BoQi6b6foFOWTAtAGMqZwVssvVSrfukQBtjTuO
	Qs4z/7+NknPIH/hQOGD18NQGbVtyBiLrFuh8hnlYwBrhqI1g3N6+S654xsyDjG
X-Google-Smtp-Source: AGHT+IGtSuGOrHDdRoTFrjA1p0YV20B9zFE8H/pWfhm6CgqO4MCswb0cLrF+BJeMzcTKRhCT0OghGOzvA9INu9psR8g=
X-Received: by 2002:a2e:ab08:0:b0:30b:cc6a:ffe3 with SMTP id
 38308e7fff4ca-30ef90cb077mr1268501fa.3.1743548414355; Tue, 01 Apr 2025
 16:00:14 -0700 (PDT)
MIME-Version: 1.0
References: <29a76f51-97b0-4c07-87b7-ec8e3b5345c9@gmail.com> <CAApHDvpmfXrcWvxpfJ7GtX=rD7L9H8Z5e6r=xXWESbR=HTJCsQ@mail.gmail.com>
In-Reply-To: <CAApHDvpmfXrcWvxpfJ7GtX=rD7L9H8Z5e6r=xXWESbR=HTJCsQ@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 2 Apr 2025 12:00:01 +1300
X-Gm-Features: AQ5f1Jr66d2uksYIA6ePFKRl7yVF1Uu2DFSZ5z8gjZGjsM_edSoG69gLS3nnn0E
Message-ID: <CAApHDvqSFcGvyYVJZAk7BW544cd4KY3B9KofnjkCdpV49hwVGg@mail.gmail.com>
Subject: Re: Hashed IN only applied to first encountered IN
To: David Geier <geidav.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAApHDvqSFcGvyYVJZAk7BW544cd4KY3B9KofnjkCdpV49hwVGg%40mail.gmail.com>
Precedence: bulk

On Wed, 2 Apr 2025 at 01:31, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Wed, 2 Apr 2025 at 00:51, David Geier <geidav.pg@gmail.com> wrote:
> > The hashed IN optimization is only applied to the first encountered
> > ScalarArrayOpExpr during the expression tree traversal in
> > convert_saop_to_hashed_saop_walker(). Reason being that the walker
> > returns true which aborts the traversal.
>
> > I've also attached a patch with a fix.
>
> Thanks for the report and fix.  On first inspection your patch looks
> fine.  I'll have a closer look tomorrow.

I've now pushed and backpatched the relevant portion of this back to v14.

Thanks again.

David