MIME-Version: 1.0
References: 
 <CAEudQAq_zOSA2NUQSWePTGV_=90Uw0WcXxGOWnN-vwF046OOqA@mail.gmail.com>
 <2D90FFB0-C80A-4189-A5BF-C37F05E271D7@greg.burd.me>
In-Reply-To: <2D90FFB0-C80A-4189-A5BF-C37F05E271D7@greg.burd.me>
From: David Rowley <dgrowleyml@gmail.com>
Date: Thu, 9 Oct 2025 14:57:41 +1300
Message-ID: 
 <CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a+XLQ@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Greg Burd <greg@burd.me>
Cc: Ranier Vilela <ranier.vf@gmail.com>, Daniel Gustafsson <daniel@yesql.se>,
	Michael Paquier <michael@paquier.xyz>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a%2BXLQ%40mail.gmail.com>
Precedence: bulk

On Thu, 9 Oct 2025 at 07:48, Greg Burd <greg@burd.me> wrote:
>                      bms = bms_del_member(bms, member);
> +                    num_members--;
> +                    memmove(members + pos, members + pos + 1,
> +                                     (num_members - pos) * sizeof(int));

I don't think there's any need to maintain the order of that members
array, so couldn't you just do this?:

bms = bms_del_member(bms, member);
members[pos] = members[--num_members];

David