MIME-Version: 1.0
References: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
 <eok6kgntbec2vo35xp4eky5ef52ttb7trislyev63ty3ltu533@je4bpifl6spb>
 <CAJDiXgjPGu_cW9nsvciqdgAkqY5o5ugaxDvo3S-rOcqBPcHCPw@mail.gmail.com>
 <CAApHDvqA26O3mnRg=WgASdPrur7bybvGvLesHvnZ0cKQwoEuxA@mail.gmail.com>
 <CAJDiXggJkpxM_uqzwXj=c=q3w7JtShx8K24yeZqbkr_FHmVtUA@mail.gmail.com>
In-Reply-To: 
 <CAJDiXggJkpxM_uqzwXj=c=q3w7JtShx8K24yeZqbkr_FHmVtUA@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 1 Apr 2026 03:07:11 +1300
Message-ID: 
 <CAApHDvqbRe3K-YmqSPfXMxDY==wg9MhSGwKX_Pafw=-pw3w_bg@mail.gmail.com>
Subject: Re: Get rid of redundant StringInfo accumulation
To: Daniil Davydov <3danissimo@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqbRe3K-YmqSPfXMxDY%3D%3Dwg9MhSGwKX_Pafw%3D-pw3w_bg%40mail.gmail.com>
Precedence: bulk

On Wed, 1 Apr 2026 at 02:10, Daniil Davydov <3danissimo@gmail.com> wrote:
> Most of the fixes cannot be noticeable in the flamegraphs. If the client uses
> only WARNING log level in the production then the usefulness of the patch is
> obvious for me. So, I think that at first we should consolidate on the issue
> above.

Do you mean that the new message_level_is_interesting() call isn't
noticeable? Or that the extra work to build the StringInfo can't be
noticed in an unpatched version? If it's the latter, then what's the
point?

Your opening email seems to indicate that you noticed the issue from
looking at the code. So, it appears that you didn't do this because
you noticed that there was an actual measurable overhead and you saw a
way to fix it. If that's the case then perhaps you've just assumed
this will make a meaningful difference. If I've misunderstood that,
please correct me and show us your test cases and the performance
results.

David