MIME-Version: 1.0
References: <aNolInqSzt1d1338@paquier.xyz>
 <791EFF06-DE5A-4E91-83E1-4C35550B55DA@getmailspring.com>
 <aNsYzCYjPV2VQd3o@paquier.xyz>
In-Reply-To: <aNsYzCYjPV2VQd3o@paquier.xyz>
From: David Rowley <dgrowleyml@gmail.com>
Date: Tue, 30 Sep 2025 13:19:05 +1300
Message-ID: 
 <CAApHDvqghMnm_zgSNefto9oaEJ0S-3Cgb3gdsV7XvLC-hMS02Q@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Michael Paquier <michael@paquier.xyz>
Cc: Greg Burd <greg@burd.me>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqghMnm_zgSNefto9oaEJ0S-3Cgb3gdsV7XvLC-hMS02Q%40mail.gmail.com>
Precedence: bulk

On Tue, 30 Sept 2025 at 12:40, Michael Paquier <michael@paquier.xyz> wrote:
> The only two code paths I'm seeing as not covered are:
> - test_bms_add_range() for a bms_free() case.

One question about that:  In cases like [1],  what's the reason that
many of the bms_free() calls check if the set is NULL before calling
the function?

NULL is a valid Bitmapset, so I don't really see the need to check for
an empty set before calling bms_free().  If those were removed, then
you'd not have to care about the coverage of that line.

David

[1] https://coverage.postgresql.org/src/test/modules/test_bitmapset/test_bitmapset.c.gcov.html#699