MIME-Version: 1.0
References: 
 <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
 <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me>
 <CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
 <aNxpxE6a9G3sbfrm@paquier.xyz>
 <CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
 <aNyiu0fKRqihdwpV@paquier.xyz>
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
 <aNy4xV4Fa1m9lyXX@paquier.xyz>
 <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se>
 <CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com>
 <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
In-Reply-To: <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 3 Oct 2025 12:36:57 +1300
Message-ID: 
 <CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Greg Burd <greg@burd.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c8ec5406403576de"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqiN0%2BmbooUOSCDALc%3DGoM8DmTbCdvwnCwak6Wb2O1ZJA%40mail.gmail.com>
Precedence: bulk

--000000000000c8ec5406403576de
Content-Type: text/plain; charset="UTF-8"

On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> wrote:
> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
> since that is a STRICT function, making the test for NULL superfluous code:

I see test_random_operations() is also strict. Is it worth getting rid
of the SQL NULL checks on the inputs there too? Aka, the attached.

David

--000000000000c8ec5406403576de
Content-Type: application/octet-stream;
	name="test_random_operations_is_strict_no_need_to_check_for_null_inputs.patch"
Content-Disposition: attachment;
	filename="test_random_operations_is_strict_no_need_to_check_for_null_inputs.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mga1kkdq0>
X-Attachment-Id: f_mga1kkdq0

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9iaXRtYXBzZXQvdGVzdF9iaXRtYXBz
ZXQuYyBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9iaXRtYXBzZXQvdGVzdF9iaXRtYXBzZXQuYwpp
bmRleCBhY2FhOTNkMmYxMS4uOGJjOWIxZjQ4ZTkgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L21vZHVs
ZXMvdGVzdF9iaXRtYXBzZXQvdGVzdF9iaXRtYXBzZXQuYworKysgYi9zcmMvdGVzdC9tb2R1bGVz
L3Rlc3RfYml0bWFwc2V0L3Rlc3RfYml0bWFwc2V0LmMKQEAgLTU4Nyw3ICs1ODcsNyBAQCB0ZXN0
X2JpdG1hcF9tYXRjaChQR19GVU5DVElPTl9BUkdTKQogICogIm1pbl92YWx1ZSIgaXMgdGhlIG1p
bmltYWwgdmFsdWUgdXNlZCBmb3IgdGhlIG1lbWJlcnMsIHRoYXQgd2lsbCBzdGFuZAogICogdXAg
dG8gYSByYW5nZSBvZiAibWF4X3JhbmdlIi4gICJudW1fb3BzIiBkZWZpbmVzIHRoZSBudW1iZXIg
b2YgdGltZSBlYWNoCiAgKiBvcGVyYXRpb24gaXMgZG9uZS4gICJzZWVkIiBpcyBhIHJhbmRvbSBz
ZWVkIHVzZWQgdG8gY2FsY3VsYXRlIHRoZSBtZW1iZXIKLSAqIHZhbHVlcy4KKyAqIHZhbHVlcy4g
IFdoZW4gInNlZWQiIGlzIDw9IDAsIGEgcmFuZG9tIHNlZWQgd2lsbCBiZSBjaG9zZW4gYXV0b21h
dGljYWxseS4KICAqCiAgKiBUaGUgcmV0dXJuIHZhbHVlIGlzIHRoZSBudW1iZXIgb2YgdGltZXMg
YWxsIG9wZXJhdGlvbnMgaGF2ZSBiZWVuIGV4ZWN1dGVkLgogICovCkBAIC02MDAsMjUgKzYwMCwy
MCBAQCB0ZXN0X3JhbmRvbV9vcGVyYXRpb25zKFBHX0ZVTkNUSU9OX0FSR1MpCiAJQml0bWFwc2V0
ICAqcmVzdWx0ID0gTlVMTDsKIAlwZ19wcm5nX3N0YXRlIHN0YXRlOwogCXVpbnQ2NAkJc2VlZCA9
IEdldEN1cnJlbnRUaW1lc3RhbXAoKTsKLQlpbnQJCQludW1fb3BzID0gNTAwMDsKLQlpbnQJCQl0
b3RhbF9vcHMgPSAwOwotCWludAkJCW1heF9yYW5nZSA9IDIwMDA7Ci0JaW50CQkJbWluX3ZhbHVl
ID0gMDsKKwlpbnQJCQludW1fb3BzOworCWludAkJCW1heF9yYW5nZTsKKwlpbnQJCQltaW5fdmFs
dWU7CiAJaW50CQkJbWVtYmVyOwogCWludAkJICAgKm1lbWJlcnM7CiAJaW50CQkJbnVtX21lbWJl
cnMgPSAwOworCWludAkJCXRvdGFsX29wcyA9IDA7CiAKLQlpZiAoIVBHX0FSR0lTTlVMTCgwKSAm
JiBQR19HRVRBUkdfSU5UMzIoMCkgPiAwKQorCWlmIChQR19HRVRBUkdfSU5UMzIoMCkgPiAwKQog
CQlzZWVkID0gUEdfR0VUQVJHX0lOVDMyKDApOwogCi0JaWYgKCFQR19BUkdJU05VTEwoMSkpCi0J
CW51bV9vcHMgPSBQR19HRVRBUkdfSU5UMzIoMSk7Ci0KLQlpZiAoIVBHX0FSR0lTTlVMTCgyKSkK
LQkJbWF4X3JhbmdlID0gUEdfR0VUQVJHX0lOVDMyKDIpOwotCi0JaWYgKCFQR19BUkdJU05VTEwo
MykpCi0JCW1pbl92YWx1ZSA9IFBHX0dFVEFSR19JTlQzMigzKTsKKwludW1fb3BzID0gUEdfR0VU
QVJHX0lOVDMyKDEpOworCW1heF9yYW5nZSA9IFBHX0dFVEFSR19JTlQzMigyKTsKKwltaW5fdmFs
dWUgPSBQR19HRVRBUkdfSU5UMzIoMyk7CiAKIAlwZ19wcm5nX3NlZWQoJnN0YXRlLCBzZWVkKTsK
IAltZW1iZXJzID0gcGFsbG9jKHNpemVvZihpbnQpICogbnVtX29wcyk7Cg==
--000000000000c8ec5406403576de--