Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4mlW-007Hss-62 for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Apr 2025 20:20:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u4mlT-00GPHp-UL for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Apr 2025 20:20:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4mlT-00GPHh-Kb for pgsql-hackers@lists.postgresql.org; Tue, 15 Apr 2025 20:20:16 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u4mlS-000Fdj-1G for pgsql-hackers@lists.postgresql.org; Tue, 15 Apr 2025 20:20:15 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-54ac9d57173so59969e87.0 for ; Tue, 15 Apr 2025 13:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744748413; x=1745353213; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pg4OjRhgQiNVR7bQ3yQjx4ycBflpB2TvT3Ms1+9Za0o=; b=JWNyOBkILmLAINgcAQx1eHt3ypCgS3QsCDG0xqArc0/00X9zVzT4vVy9OQ5qU1/sVI U9qi2rdawgV75OjNKlbyZcRrPhgfeWf2sVK1amUWtbsFw5jDSAh0/gGFfTDoApIOdHFn kyxHjb+ju+KglO4D3Y9hQ7o5Alw4csoKHSF7cbmI4IBSonsVnek2jeHV9+MLPoxUXLBB WYUi6VNNMwmL8KRi5zvjtbLn9St8zchjICEGdmCXvRow/S5TK5Elvx/iqwWAmHjTCx1G bVQxq7wPpUJmhalpVtsy38IUs0cWur9hnLffwiNsyrDdDIr5fGQRiAL/2YIpob0RJNii TKTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744748413; x=1745353213; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pg4OjRhgQiNVR7bQ3yQjx4ycBflpB2TvT3Ms1+9Za0o=; b=SGXcTbttQ3hjIK0a9mY6Ph9QJJVvv+UsbrrCSf/tXexHm0lcUN8TDQ3XGdL3VmN+rK qzuXMPqX3V1B+ue9c+1xMN9r3ItqFsXJo/udpvJyZ6eXWV1yU12QrbxB3/1lbg/vM5qv JY6uUGk5bvu09Oh29g/hQKIAVgpwJS9HPpRFHMDqZYCpzh5Ia6XpUs1MAEWqoxFfmq1t vlEmyNCH77CSZN47Yo1VKUvYQ5s0zkxGFkErt6I8KP/2Bx+PHvhMWP49xWn6fCSB46N3 5nPa9DFTlsNbIxI99j2ul/elxeFZ+tOlb5TRP6b4TGu/Hb/zTDkrJE0CA2cbSQyNpIRa 2XWg== X-Forwarded-Encrypted: i=1; AJvYcCUIg7PQri92ACuS1+3FCXpac3Febe6RqoFWe1iHwvJFGO/918qQzAMZt9SxCl5UPDkiIETzralkmZby8I1x@lists.postgresql.org X-Gm-Message-State: AOJu0Yx3VK5w2IN9xnyGfdJ2r07bVq5inhtMJsQpS+VSpnZ8JcnJrQxp HwBOzUQ1nYQ5K6FkNzc5Wr9x0pOtmMk6QKpYzlOFJehA6xWzR18DbbC7FnvudTsqJoQi4AkjcFr 3pwTAsQE06g7qD7YSGVqo0jjFgK4= X-Gm-Gg: ASbGncvpcCCfIPSj6aSNosjaUKwer/RMUz4IXxb6sD2aiqsUiYP0mkf/wILm1+0sGtO z2xPYoJ4FLXoNTVFZs94LmABWXwhGZBrpL0TqHYJaGR70L7euz9oIu3Sy81Cs0+KjLs1eso0NCu 3e5A5ByTwAhrSF9GcO1XLbRg== X-Google-Smtp-Source: AGHT+IHm4tHlzn30TJfRiS3NnXHmJg2uaUfP9EBLxidKY8Sz7ifs5EHpSGgnzNmCzHUG6BCvpmDBxDYrXGQ6ksM99LY= X-Received: by 2002:a05:6512:acb:b0:54a:cc10:1050 with SMTP id 2adb3069b0e04-54d5fd53c58mr284100e87.15.1744748412750; Tue, 15 Apr 2025 13:20:12 -0700 (PDT) MIME-Version: 1.0 References: <11c709e1-9b17-4c00-9ead-93609a09b9db@gmail.com> <1161645.1742854534@sss.pgh.pa.us> <1164845.1742856354@sss.pgh.pa.us> <3ba16aa7-3cb2-4289-b773-522ae2f03a77@tantorlabs.com> <81ef0f5a-b6a1-4417-ae3a-2bae9b8d419e@gmail.com> <67b5c84a-dedd-4103-af7e-0117046102fe@tantorlabs.com> <580fe72c-85be-45a8-9e00-6b5417690557@tantorlabs.com> <3ea66a50-e4b0-4f20-ae0c-4d9cbaf81cfb@tantorlabs.com> <0e8dc4fa-3655-4e9f-9424-9b32a15e6acd@tantorlabs.com> In-Reply-To: <0e8dc4fa-3655-4e9f-9424-9b32a15e6acd@tantorlabs.com> From: David Rowley Date: Wed, 16 Apr 2025 08:20:00 +1200 X-Gm-Features: ATxdqUFPQxYLm2AGHorsHR16PV7NFVNmJ9GOl7Ygu_vbO9u2aQCVOYstdzwXK8w Message-ID: Subject: Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment To: Ilia Evdokimov Cc: Robert Haas , Tom Lane , Lukas Fittl , Daniel Gustafsson , PostgreSQL Hackers , Nikolay Samokhvalov , Andrei Lepikhov Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 15 Apr 2025 at 21:44, Ilia Evdokimov wrote: > Wrapping the line in costs or verbose would help with test stability, but doing that only to simplify test output doesn't look like the right reason. Maybe it makes more sense to mask these values in other tests that use Memoize too. What do you think? Disregard what I said about the explain_memoize() function. The new output just shouldn't be shown with EXPLAIN (costs off). David