MIME-Version: 1.0
References: <DM4PR84MB17348EA11FA90A9BE896AF89EE489@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <DM4PR84MB17348EA11FA90A9BE896AF89EE489@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 31 May 2023 18:13:57 +1200
Message-ID: <CAApHDvr2WOUdnvJemheTXtONC6KdWrBwSxLCN8b687+vLFbKyQ@mail.gmail.com>
Subject: Re: [16Beta1][doc] pgstat: Track time of the last scan of a relation
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, "dpage@pgadmin.org" <dpage@pgadmin.org>, 
	"andres@anarazel.de" <andres@anarazel.de>, "bruce@momjian.us" <bruce@momjian.us>, 
	"vik@postgresfriends.org" <vik@postgresfriends.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvr2WOUdnvJemheTXtONC6KdWrBwSxLCN8b687%2BvLFbKyQ%40mail.gmail.com>
Precedence: bulk

On Wed, 31 May 2023 at 15:57, Shinoda, Noriyoshi (PN Japan FSIP)
<noriyoshi.shinoda@hpe.com> wrote:
> According to the documentation [2], the data type of the columns added to these views is 'timestamptz'.
> However, columns of the same data type in pg_stat_all_tables.last_vacuum, last_analyze and other tables are unified to 'timestamp with time zone'. The attached patch changes the data type of the added column from timestamptz to timestamp with time zone.

I agree that it would be good to make those consistently use timestamp
with time zone for all columns of that type in the docs for
pg_stat_all_tables.

More generally, it might be good if we did it for the entire docs:

doc $ git grep "<type>timestamptz</type>" | wc -l
17
doc $ git grep "<type>timestamp with time zone</type>" | wc -l
74

Clearly "timestamp with time zone" is much more commonly used.

The bar is probably set a bit higher for changing the
longer-established ones, however.

David