public inbox for [email protected]  
help / color / mirror / Atom feed
From: David Rowley <[email protected]>
To: PostgreSQL Developers <[email protected]>
Subject: Re: Minor fixes for couple some comments around MERGE RETURNING
Date: Thu, 23 May 2024 15:25:47 +1200
Message-ID: <CAApHDvr3nNZvy6NJDVzm+O0G9jozWFTPYD6wEK39UxBy6p-R4A@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvpqp6vtUzG-_josUEiBGyqnrnVxJ-VdF+hJLXjHdHzsyQ@mail.gmail.com>
References: <CAApHDvpqp6vtUzG-_josUEiBGyqnrnVxJ-VdF+hJLXjHdHzsyQ@mail.gmail.com>

On Sun, 19 May 2024 at 15:20, David Rowley <[email protected]> wrote:
>
> I noticed that PlannedStmt.hasReturning and hasModifyingCTE have an
> outdated comment now that MERGE supports RETURNING (per commit
> c649fa24a)
>
> i.e. these two:
>
> > bool hasReturning; /* is it insert|update|delete RETURNING? */
>
> > bool hasModifyingCTE; /* has insert|update|delete in WITH? */

I've pushed the fix for that.

David






view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Minor fixes for couple some comments around MERGE RETURNING
  In-Reply-To: <CAApHDvr3nNZvy6NJDVzm+O0G9jozWFTPYD6wEK39UxBy6p-R4A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox