Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rku1r-00GHuH-61
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 22:58:27 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rku1p-003zH7-K2
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 22:58:26 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1rku1p-003zGW-AT
	for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2024 22:58:25 +0000
Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1rku1m-004XRi-Bx
	for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2024 22:58:24 +0000
Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5101cd91017so2429505e87.2
        for <pgsql-hackers@lists.postgresql.org>; Thu, 14 Mar 2024 15:58:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1710457102; x=1711061902; darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=0CpC12yGIpt6iy8LRdh2Vu/68dOhUhCEJzLLn4a0J5w=;
        b=LIDuF3LZOrNioAFZ/UUMXbIzaqvGVXcV0mhF54D+AYI9R2CR8JC36KpxxJR2LQ6P8W
         C2CXs7OugM6D4fbKNY+lL5+eCtWEhGzrz3Ibaw+CZf65PT5e5B5CdyuEw2dluRtlrNR3
         nLbi1Dc4EEsYINseq5vWp2TdU2JwtvFG/1yumI/WxmPvvGEM42mHd3Eu0A6dlBL0Ov+N
         7Eux4M2WJap9ErdZw2hPwe5jCRZkVP6V7xnaHhdtiLGZ6zfOy/tHI1lQ4s/pgd1hiU0N
         URz/8wseDK50SHArYfJxnhXN1xxgY9lSzkGcprUmrXNyRyuIW/TErrzArUb93c6lBfJF
         YtYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1710457102; x=1711061902;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=0CpC12yGIpt6iy8LRdh2Vu/68dOhUhCEJzLLn4a0J5w=;
        b=SDUgh8aMDw3j58AyyQXGCFUHXCpykBAn4TXk2xSPbU72mO79SC3Ad26rm+EcQlX0FK
         DeKLGo9OrnAPlTZFIXCN+MgJsVasym/XEy6Ee7w1laNS2OCFdw9KdtysQ5G3h6lq0Qef
         PFHEwFwcuWqHWJVIs16zaqaAhe31WlUYLU3LMl5OSLTKhtabyUTdK9rWkZOpKCa5wcIl
         MTnkqFW1PMkQZ2akXeWl9mpv4Jjr3q83JvVGn5pQNZ731bPcu+1uvbopjSXQLdX8svLm
         HU0y34Pgf8n6MqXFSXiKvDsRG5xcpI2KCn0OsAlLfQZ5fRMI1qjCcJGDqL2WdaLaNEqA
         BSkQ==
X-Forwarded-Encrypted: i=1; AJvYcCXGekRfuy+gussfqGfJrAuGW4edJukkDhwKhpUUteRlSEuFjDtZuig8abXWsTQmaR1J7twTfrePYM2jyQGPwnJMiflJq4y6lq6vsMUdGZkurzdc
X-Gm-Message-State: AOJu0YzglWlQAtzuMuGdu+mVC7vppSpHwLpLK2TlQE9PNE0tcYVjK4IR
	PHv4JtlqLaL2oyju7JhrlHdG9GhBcrGIRjXrpAtUuZm6tNT+gD+6Jo7BmUUFtKEyQY/7bqrxU1v
	W+A0405c3+J4fxNnv+3z7qxkjieE=
X-Google-Smtp-Source: AGHT+IHmWA0uYnM8zNCpmumoREn810+G5t55RQ4E6EYLkAQWzPIZZBYcatYNou7MywDWw6CrL+qclfUKm7rfadFzneY=
X-Received: by 2002:a19:e006:0:b0:513:9b6d:ab0e with SMTP id
 x6-20020a19e006000000b005139b6dab0emr1971381lfg.5.1710457101644; Thu, 14 Mar
 2024 15:58:21 -0700 (PDT)
MIME-Version: 1.0
References: <ZQhYYRhUxpW3PSf9@telsasoft.com> <CAMbWs48X+cK2pEaZDVVjd+nOJzb1dN1CO1OKz+6D0FX2OTCGbg@mail.gmail.com>
 <CAApHDvpJJigQRW29TppTOPYp+Aui0mtd3MpfRxyKv=N-tB62jQ@mail.gmail.com>
 <CAApHDvo7RzcQYw-gnkZr6QCijCqf8vJLkJ4XFk-KawvyAw109Q@mail.gmail.com>
 <CAApHDvqoMf_kxQKON+FLQh8DbMKe62R=OdrZoenb6xDYWmQVUQ@mail.gmail.com>
 <CAMbWs48VKgJyqfDNtKsYnNsPYWqA=stPKenehVz1NN0HTFV9mg@mail.gmail.com>
 <CAApHDvrAHkghCDNFG5+K2adWCDCC9cdZT2KZamVRkqYy31kL9w@mail.gmail.com>
 <CAApHDvqira92LLPbW37azL+fDEm7yvWni89YekB9G751W7nEBw@mail.gmail.com>
 <cf63174c-8c89-3953-cb49-48f41f74941a@gmail.com> <CAApHDvqEdHSMwZt5ngXOBK+rZ=WU5iJdkvf+yD7qQJVu606fNg@mail.gmail.com>
In-Reply-To: <CAApHDvqEdHSMwZt5ngXOBK+rZ=WU5iJdkvf+yD7qQJVu606fNg@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 15 Mar 2024 11:58:09 +1300
Message-ID: <CAApHDvr8Wu1MuK+M5d2hiWujCBkPmacCqfBd-9RVZadrAgA6eA@mail.gmail.com>
Subject: Re: pg16: XX000: could not find pathkey item to sort
To: Alexander Lakhin <exclusion@gmail.com>, Robert Haas <robertmhaas@gmail.com>, 
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAApHDvr8Wu1MuK%2BM5d2hiWujCBkPmacCqfBd-9RVZadrAgA6eA%40mail.gmail.com>
Precedence: bulk

On Thu, 14 Mar 2024 at 12:00, David Rowley <dgrowleyml@gmail.com> wrote:
> I've attached a patch which fixes the problem for me.

I've pushed the patch to fix gather_grouping_paths().  The issue with
the RelOptInfo having the incorrect PathTarget->exprs after the
partial phase of partition-wise aggregate remains.

David