MIME-Version: 1.0
References: 
 <CA+hUKGJkOiOCa+mag4BF+zHo7qo=o9CFheB8=g6uT5TUm2gkvA@mail.gmail.com>
 <CAFiTN-vkrD77SH7JSS_P-07f7H-5uxB4XM_=OVHyumzqJKLqpQ@mail.gmail.com>
 <CA+hUKGLJi+c5jB3j6UvkgMYHky-qu+LPCsiNahUGSa5Z4DvyVA@mail.gmail.com>
 <56bc4ac4-9a9e-4f28-af1e-b6d537bd9a5e@iki.fi>
 <CA+hUKG+2mMiyJEDV-rNb5q__x9VJW5p8oJpGn9ZpovbyoVe1VA@mail.gmail.com>
 <289a1c0e-8444-4009-a8c2-c2d77ced6f07@iki.fi>
 <CA+hUKGJTwrS7F=uJPx3SeigMiQiW+LJaOkjGyZdCntwyMR=uAw@mail.gmail.com>
 <CAAKRu_aHAExA0psUQ6C0DpHrH_tVtjgKDFZCDjFoGdYu04iOpg@mail.gmail.com>
 <CA+hUKG+BqsqOS90Annd6hJoUFwStUrZ=R-5bJFUaoA8ZsLf-cQ@mail.gmail.com>
 <CA+hUKGJ9HgsZmnC7ABs8ZXOL-MtQCfC7Z-oQuHagm++f5O=udw@mail.gmail.com>
 <CA+hUKGLmN=NOL06XmuW9LvMPWnj87xHGvdLeiy9poP7+yOmDdw@mail.gmail.com>
 <CA+hUKGLN8D7sZUaMVf8aNcC17b3Qkncu2Xayb-qym5E3-p5goA@mail.gmail.com>
 <CA+hUKG+5UofvseJWv6YqKmuc_=rguc7VqKcNEG1eawKh3MzHXQ@mail.gmail.com>
 <98f01395-fc60-4d50-89c9-fc3011fa2a45@iki.fi>
 <CA+hUKGLncY4sqa1RwoRwY_qq+2Fd-_0X3mDKk_p15sipmXZOng@mail.gmail.com>
 <d1eb996b-423a-4bcd-bce4-75f5daa12ffa@iki.fi>
 <CA+hUKGLDqKhxOODYD2C0Q5YGM697hWMksMoSN-SsUMRGgcH2+A@mail.gmail.com>
 <CA+hUKGJUFkkOkdVq0hug3h1NXVJ0CSA3XTk8XLP2J0y9353ZGw@mail.gmail.com>
 <CAN55FZ3EGSQ8nGFf6nYyD1gMY7GWD3-weP7aQjmF6RuHmpV6eg@mail.gmail.com>
 <CAN55FZ1k1oQVF++UFGruKqna_hw8bTNPkbx6DVpANqs1=1qLqg@mail.gmail.com>
 <CAN55FZ1yGvCzCW_aufu83VimdEYHbG_zuOY3J9JL-nBptyJyKA@mail.gmail.com>
In-Reply-To: 
 <CAN55FZ1yGvCzCW_aufu83VimdEYHbG_zuOY3J9JL-nBptyJyKA@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 24 Apr 2024 14:32:09 +1200
Message-ID: 
 <CAApHDvr9Un-XpDr_+AFdOGM38O2K8SpfoHimqZ838gguTGYBiQ@mail.gmail.com>
Subject: Re: Streaming I/O, vectored I/O (WIP)
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
	Dilip Kumar <dilipbalaut@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>,
	Melanie Plageman <melanieplageman@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000e8f0f10616ce7a2e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvr9Un-XpDr_%2BAFdOGM38O2K8SpfoHimqZ838gguTGYBiQ%40mail.gmail.com>
Precedence: bulk

--000000000000e8f0f10616ce7a2e
Content-Type: text/plain; charset="UTF-8"

I've attached a patch with a few typo fixes and what looks like an
incorrect type for max_ios. It's an int16 and I think it needs to be
an int. Doing "max_ios = Min(max_ios, PG_INT16_MAX);" doesn't do
anything when max_ios is int16.

David

--000000000000e8f0f10616ce7a2e
Content-Type: text/plain; charset="US-ASCII"; name="read_stream_fixes.patch"
Content-Disposition: attachment; filename="read_stream_fixes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lvd778h70>
X-Attachment-Id: f_lvd778h70

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYWlvL3JlYWRfc3RyZWFtLmMgYi9zcmMv
YmFja2VuZC9zdG9yYWdlL2Fpby9yZWFkX3N0cmVhbS5jCmluZGV4IDYzNGNmNGYwZDEuLjc0Yjli
YWU2MzEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYWlvL3JlYWRfc3RyZWFtLmMK
KysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9haW8vcmVhZF9zdHJlYW0uYwpAQCAtMjYsMTIgKzI2
LDEyIEBACiAgKgogICogQikgSS9PIGlzIG5lY2Vzc2FyeSwgYnV0IGZhZHZpc2UgaXMgdW5kZXNp
cmFibGUgYmVjYXVzZSB0aGUgYWNjZXNzIGlzCiAgKiBzZXF1ZW50aWFsLCBvciBpbXBvc3NpYmxl
IGJlY2F1c2UgZGlyZWN0IEkvTyBpcyBlbmFibGVkIG9yIHRoZSBzeXN0ZW0KLSAqIGRvZXNuJ3Qg
c3VwcG9ydCBhZHZpY2UuICBUaGVyZSBpcyBubyBiZW5lZml0IGluIGxvb2tpbmcgYWhlYWQgbW9y
ZSB0aGFuCi0gKiBpb19jb21iaW5lX2xpbWl0LCBiZWNhdXNlIGluIHRoaXMgY2FzZSBvbmx5IGdv
YWwgaXMgbGFyZ2VyIHJlYWQgc3lzdGVtCisgKiBkb2Vzbid0IHN1cHBvcnQgZmFkdmlzZS4gIFRo
ZXJlIGlzIG5vIGJlbmVmaXQgaW4gbG9va2luZyBhaGVhZCBtb3JlIHRoYW4KKyAqIGlvX2NvbWJp
bmVfbGltaXQsIGJlY2F1c2UgaW4gdGhpcyBjYXNlIHRoZSBvbmx5IGdvYWwgaXMgbGFyZ2VyIHJl
YWQgc3lzdGVtCiAgKiBjYWxscy4gIExvb2tpbmcgZnVydGhlciBhaGVhZCB3b3VsZCBwaW4gbWFu
eSBidWZmZXJzIGFuZCBwZXJmb3JtCiAgKiBzcGVjdWxhdGl2ZSB3b3JrIGxvb2tpbmcgYWhlYWQg
Zm9yIG5vIGJlbmVmaXQuCiAgKgotICogQykgSS9PIGlzIG5lY2Vzc3NhcnksIGl0IGFwcGVhcnMg
cmFuZG9tLCBhbmQgdGhpcyBzeXN0ZW0gc3VwcG9ydHMgZmFkdmlzZS4KKyAqIEMpIEkvTyBpcyBu
ZWNlc3NhcnksIGl0IGFwcGVhcnMgcmFuZG9tLCBhbmQgdGhpcyBzeXN0ZW0gc3VwcG9ydHMgZmFk
dmlzZS4KICAqIFdlJ2xsIGxvb2sgZnVydGhlciBhaGVhZCBpbiBvcmRlciB0byByZWFjaCB0aGUg
Y29uZmlndXJlZCBsZXZlbCBvZiBJL08KICAqIGNvbmN1cnJlbmN5LgogICoKQEAgLTQxOCw3ICs0
MTgsNyBAQCByZWFkX3N0cmVhbV9iZWdpbl9yZWxhdGlvbihpbnQgZmxhZ3MsCiAJUmVhZFN0cmVh
bSAqc3RyZWFtOwogCXNpemVfdAkJc2l6ZTsKIAlpbnQxNgkJcXVldWVfc2l6ZTsKLQlpbnQxNgkJ
bWF4X2lvczsKKwlpbnQJCQltYXhfaW9zOwogCWludAkJCXN0cmF0ZWd5X3Bpbl9saW1pdDsKIAl1
aW50MzIJCW1heF9waW5uZWRfYnVmZmVyczsKIAlPaWQJCQl0YWJsZXNwYWNlX2lkOwpAQCAtNDQ3
LDYgKzQ0Nyw4IEBAIHJlYWRfc3RyZWFtX2JlZ2luX3JlbGF0aW9uKGludCBmbGFncywKIAkJbWF4
X2lvcyA9IGdldF90YWJsZXNwYWNlX21haW50ZW5hbmNlX2lvX2NvbmN1cnJlbmN5KHRhYmxlc3Bh
Y2VfaWQpOwogCWVsc2UKIAkJbWF4X2lvcyA9IGdldF90YWJsZXNwYWNlX2lvX2NvbmN1cnJlbmN5
KHRhYmxlc3BhY2VfaWQpOworCisJLyogQ2FwIHRvIElOVDE2X01BWCB0byBhdm9pZCBvdmVyZmxv
d2luZyBiZWxvdyAqLwogCW1heF9pb3MgPSBNaW4obWF4X2lvcywgUEdfSU5UMTZfTUFYKTsKIAog
CS8qCg==
--000000000000e8f0f10616ce7a2e--