public inbox for [email protected]
help / color / mirror / Atom feedFrom: David Rowley <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Greg Burd <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Wed, 1 Oct 2025 18:00:59 +1300
Message-ID: <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
<[email protected]>
<CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
<[email protected]>
<CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
<[email protected]>
On Wed, 1 Oct 2025 at 16:41, Michael Paquier <[email protected]> wrote:
> Okay. Let's just remove as much code as possible, then. This is
> roughly what you have sent, minus the hardcoded empty set and the free
> calls. I'll just go do that in a bit.
Thanks. Just for reference, you may not need it if you're mostly done
already, but I had to finish this off in my head before moving on.
Feel free to ignore, but there are a couple of typos fixed at the very
least "varrying" should be "varying".
I didn't fully rationalise the tests in test_bitmapset.sql. There are
still a few which are duplicates due to '(b)' and NULL meaning the
same thing.
git diff --stat
.../test_bitmapset/expected/test_bitmapset.out | 400 ++------------
.../modules/test_bitmapset/sql/test_bitmapset.sql | 101 +---
.../modules/test_bitmapset/test_bitmapset--1.0.sql | 2 +-
src/test/modules/test_bitmapset/test_bitmapset.c | 605 +++++----------------
4 files changed, 222 insertions(+), 886 deletions(-)
I didn't look at the coverage report, but on thinking about it,
test_bitmapset.c's "PG_RETURN_NULL(); /* invalid input */" won't be
covered as I stripped out all the tests which purposefully pass
invalid input. You may not want it that way if you're keen to keep the
coverage of the test module high as well as bitmapset.c
David
view thread (81+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Add tests for Bitmapset
In-Reply-To: <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox