MIME-Version: 1.0
References: 
 <CAHut+Pu7LWQB+m9HTf4nf3BQu8bC_-N5c=kuOf=EHHZE_Ctj9Q@mail.gmail.com>
 <aeteISM1k7ZtM4Cs@alvherre.pgsql>
In-Reply-To: <aeteISM1k7ZtM4Cs@alvherre.pgsql>
From: David Rowley <dgrowleyml@gmail.com>
Date: Sat, 25 Apr 2026 00:43:43 +1200
Message-ID: 
 <CAApHDvrMyX4dVfQa11shF8rQxC9EjAQJ0D77gP6LG+ptXnBHFg@mail.gmail.com>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvrMyX4dVfQa11shF8rQxC9EjAQJ0D77gP6LG%2BptXnBHFg%40mail.gmail.com>
Precedence: bulk

On Sat, 25 Apr 2026 at 00:14, =C3=81lvaro Herrera <alvherre@kurilemu.de> wr=
ote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> >
> > Since you now have the list `length`, I wondered why not simplify
> > further to use list_nth indexing? Then you can remove
> > `foreach_current_index` and `lc`.
>
> WFM.

Wouldn't it be simpler to put the comma on the other end of the name
and use that if (foreach_current_index(lc) > 0) ?

Or was this to reuse a translation and you didn't want to swap
"\"%s\", " for , "\"%s\" ?

David