MIME-Version: 1.0
References: 
 <CAApHDvpHzfo92=R4W0+xVua3BUYCKMckWAmo-2t_KiXN-wYH=w@mail.gmail.com>
 <CAApHDvrXnUFNiYQiHv4Eu_rtbMPsKeVT-KG93_dD-ZYs9G5OnA@mail.gmail.com>
 <4493999.1py09z8qHF@aivenronan> <3163474.aeNJFYEL58@aivenronan>
 <CAApHDvqS-p57j++gLMyQXmttk_MM3u243dWQ54FyW-7=4GP+1Q@mail.gmail.com>
 <CAMbWs49hcB-Mj3MJTOesL5=y4oU+md=zEvDYdCBrOSaDvXLRGQ@mail.gmail.com>
 <CAApHDvr3JQv4_H7vfu5Djtw0ubKwGDwvNtPuphtaQY4utgj7bQ@mail.gmail.com>
 <CALNJ-vTqaxPcb1Qfeok7AGpOtTc9CPDdo+qWutBYQU4sAXA29g@mail.gmail.com>
In-Reply-To: 
 <CALNJ-vTqaxPcb1Qfeok7AGpOtTc9CPDdo+qWutBYQU4sAXA29g@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 27 Jul 2022 10:37:26 +1200
Message-ID: 
 <CAApHDvrRGoVRthOvA4CBfFy5Km-dSFGQNnQ_SAN7pCytyxxpMA@mail.gmail.com>
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Richard Guo <guofenglinux@gmail.com>,
 Ronan Dunklau <ronan.dunklau@aiven.io>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
 Ranier Vilela <ranier.vf@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvrRGoVRthOvA4CBfFy5Km-dSFGQNnQ_SAN7pCytyxxpMA%40mail.gmail.com>
Precedence: bulk

On Tue, 26 Jul 2022 at 12:01, Zhihong Yu <zyu@yugabyte.com> wrote:
> sort order the the planner chooses is simply : there is duplicate `the`

I think the first "the" should be "that"

> +                       /* mark this aggregate is covered by 'currpathkeys' */
>
> is covered by -> as covered by

I think it was shortened from "mark that this aggregate", but I
dropped "that" to get the comment to fit on a single line. Swapping
"is" for "as" makes it better. Thanks.

David