Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEaDG-004Aae-2D for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 22:01:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wEaDF-00GWqX-2D for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 22:01:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEaDF-00GWqO-0p for pgsql-hackers@lists.postgresql.org; Sun, 19 Apr 2026 22:01:57 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wEaDD-00000001pM1-0NMS for pgsql-hackers@lists.postgresql.org; Sun, 19 Apr 2026 22:01:56 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso26544335e9.2 for ; Sun, 19 Apr 2026 15:01:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776636113; cv=none; d=google.com; s=arc-20240605; b=jkzbBAB4H8A4D1TshNipp5TzSXQL+9vxIu1cMYxwXcY0oyd1NgKlhO03mujPO+0B9m gYRGos2NSMs/NNs2hv9CVFhKGJ1tnJdm0HOJ8YLpAjbl8lmyrcQkB0sRwb+RM6Cj0myC XXc3F8m/nc7tBvVle7HRhJxV4fgv03dgOs38Q5RSOQmkzieH6FLLydLev2YcNf62lggP MQKwtYqFpcHf0d7MvTibKnNouY9ATYuwMdCbEHiP1xwa9D4KZIxafWAaYFF4jkQ596Q3 q6Vb7OuplHdHcaeTnNsfF6/MMfRXhJnERnLyoh2peC6c8QKTZrD3E9sMRumHut4dS2CI RWPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=x2BwldeKxjIT8G4R/j8H55qtka8sXYuNNUwznNPszJw=; fh=cdiMo7GVJh9dFdmkTuV2kbUD3wn05ueDo8SVOI4spa8=; b=TLQBs7ZiiObIozy20nT9jDGkb+MCWbpbX2F0DaFOfEOIU8Fz0Q3ryuvp4uzAdUn2ms c5zpygQRT2/kKhD1ldnKVxb8xZ6KC+jG9mAek7QE+2AmTbsk1h/RvI0vyZs6JBE4uOvU Pat58lqJhwdB9w1es5cCyD/T9XDg9snlQHwChZvOK0Y93Q6QVrtoS7M2+U7dUfmQ3wLV GdsWoWF4bQyTDkgCPGoeQ/+/O9VwwVn4M8rRKktv2KjW1+i7rNmWE2VUOYas5xsZK6AN Mi+chxmJ9hu3oAqAbhPfJA+vTx3DqvCMIGrAvUvV/u+6BOVKuWpos6d5QIrN4R/cjDvk PSdg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776636113; x=1777240913; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x2BwldeKxjIT8G4R/j8H55qtka8sXYuNNUwznNPszJw=; b=VMHwiFQWTcVmcizUWm1K8226Bxa3tbxTh8ove9UUHMzzLaHr7DuAWncmtngsGTisiq SK+vQ8Cbm9QDIGtbMThgnU/O+EmOVcDH95N6O4LAPizw4CvqwAf4a0ja5ApwxNGQS3Ks KlfG3uHVUXtUHirc1C+4v21cJd8YxPh9KansQUPL2vm/DKCeue8RRb58UTkH4lEDUCuo YqzibJEttrEsr5eeCGcW+78Ihx4YEC++t41eSwDTkHkkdW/Vc0t+HXxPcvpBcGgEys2a OEd/iQMKhdIbAZP7yno1wlsbUxJgVvDfxji1Fm/DzjqOeIstUvV/L8qR2OtMbNQ9RjzQ KRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776636113; x=1777240913; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x2BwldeKxjIT8G4R/j8H55qtka8sXYuNNUwznNPszJw=; b=K/ShstZNgrN7pe7JAI+3B9YcjiZHDHSkC/TleFzjQUxprl0d4pM+qZlI9SAY2zd4Eu 2usIMmzrM1EZg97OMRGZo1NA1bEkHtPa3ZvMVaSEbBb63PWpYM7Dr8qviJoXMQosa3yU ilw/eukqfBKBzzhUZwUdaghVVvolI45brfijL+Q1umt/1XjBMtf8E0A6AGGS/7y/Qkms NXEorgMPnlO49K5jqw+xWnZaSK1AXmUk1MXvX4G+FKfy8RMy3wN9wL/sn3opSWE7Jd48 9wq1w7ja8jeJpsLDfZrV03v+tufAqyKIkBTbmAcVXBt0yCDWFinpbIxv50pBHAmbAN7d y77w== X-Forwarded-Encrypted: i=1; AFNElJ+Z0EI8MlxUakSd2AI/nr0ghgZfYcZ7tKEX8pRVAJrUOP8yA4hF3+7AWWQiaAWw3SazbCCPI50dKJ0R77TH@lists.postgresql.org X-Gm-Message-State: AOJu0YwJddtn2mFJfBcotvlEp35Jsqlcx4+Hv8WN7xOKvI+6/cTjQDG1 XC0d5nS3Rj6ANANtxh8ytnPq7Ks44PDURicTKb8gh6ohoAyjH0fG9e58SocRv6f/OIeFDHaaEip jJZL6Rz3njswZ2D/nJVYuCPgHzXKDYEM= X-Gm-Gg: AeBDietBfG/Qa5MXAywkMkf3UHIQ2zesYtOhiYNpXf3IHrdbvFTBojFZA/0FRJV+tsE gj++cDi4ak7ljEFgQ9ZMbILZFaWl7z9c1Kc8zlCsA8fojPWGsPb79DJKuFTY6N3nyO88Mk36QNQ RdPeqk8P6rnCqvcdVzJi7Ubxh/yNA245Ps8KM01ctQoHRC2KS/WhLHcWOX/UIKZQZpOU4N2Bwhx nb5MV7sR8vzkWRFJzCAfQW1YL9hrYcYKj+bMgbAOp+ngedXQRLPml82HKvDx226U9wiH7Ac58Rv OMuVaNtjMHmrVAIxiFcu5VZ+3PVUQQazAF2yFemqJ78pocQpKBHNEKj9M7X+blmAtM6XZuxmmy/ S4KNZkIdL3RURc7VPkzc= X-Received: by 2002:a05:600c:a00f:b0:486:fe83:8621 with SMTP id 5b1f17b1804b1-488fb788924mr166371735e9.23.1776636112583; Sun, 19 Apr 2026 15:01:52 -0700 (PDT) MIME-Version: 1.0 References: <2D90FFB0-C80A-4189-A5BF-C37F05E271D7@greg.burd.me> <12754d02-855c-4b11-ae7c-48a73124e715@app.fastmail.com> In-Reply-To: <12754d02-855c-4b11-ae7c-48a73124e715@app.fastmail.com> From: David Rowley Date: Mon, 20 Apr 2026 10:01:40 +1200 X-Gm-Features: AQROBzCDY7eL9OMOILlWAvfceiRGMXXUYwVnML6r5VoX6VhhxTRlFsJgfyazk2c Message-ID: Subject: Re: [PATCH] Add tests for Bitmapset To: Greg Burd Cc: Michael Paquier , Ranier Vilela , Daniel Gustafsson , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, 20 Apr 2026 at 02:41, Greg Burd wrote: > I think these changes are reasonable and improve the tests. Now I need to review your new bitmapset feature... :) Many thanks for looking. David