Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ncM9C-0000zn-Tn
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 07:01:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ncM9B-0006wA-R2
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 07:01:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1ncM9B-0006w0-Fo
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 07:01:37 +0000
Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <dgrowleyml@gmail.com>)
	id 1ncM95-0003ye-Gf
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 07:01:36 +0000
Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-de48295467so5450593fac.2
        for <pgsql-hackers@lists.postgresql.org>; Thu, 07 Apr 2022 00:01:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=MSSG3j3lK+ebr2gx+YYn6Ra5p8QPgV477ivYYzTqm1U=;
        b=jbmNEOcOkUtYVcDAe1DI85e9yVWzLJXrFoFQUftvK6lwczaMz/aSG9+3SfMyDMdTn6
         L5PSIUG6CJgnlAa5O2gDTZ4GITcWgYlEhJRpXx4Ftun/hRzBLdkmaU8yGeknq8MSYTV/
         y+iYq35rfkE2dHSdNBVvjigWCiX1eoERJ3xxbhrq0wSlIH2Q7xWC8lmiObMvwQ7qkhmZ
         D0lhPQBimvvVIxtBns/c8CvTe6EAqiqMkeyHQb9Od+bt6TZnIhavTjmNKDiSjMD8nMZk
         aUaT9Jw5uSZzB5ZQL1hFGl/leCXsGLtkqZkAM6oIgWQxin4aS4L5a2emukjOLN23FZtv
         UacA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=MSSG3j3lK+ebr2gx+YYn6Ra5p8QPgV477ivYYzTqm1U=;
        b=L4yew6Is+Kd3g6uuqZF3yt2VOQY2GY2/xSBcxFv4T3G/haEleOSNabK/xpjxI6qIWK
         FlqQ8dJ60P14cAg8pf+z0yru30kW1lAls/GO4Rv1niQUqROfcgUachdVuGuAG16PGrnM
         ooUQNMRf5658cBkmgGnwQ6rYt2VzTauj5fWoqe1rG667GJ2pBgNvyW+btvTSg7vcLsww
         zQ9CCvk3yWaRgMGIfQfXvSmLKXYQOBnCViAGOO1XTTaWNeBSMB+PQFXnzhuqGq9vpVeg
         vzrPL2TI1FxTPYsOW4YCrK33SAEar8rNHBgFCvKwTSNZWkwAjI0eH0DY6QoPRkrJ+dvh
         zybw==
X-Gm-Message-State: AOAM533laiS+QTwLTfi6x9CXojKzWVuMtgc7eYU3n3zqQr8bAHguAGhi
	Xgk5EQ353E7B92Ws3cEReCavADylzkEAjelSFhI=
X-Google-Smtp-Source: ABdhPJxroruWnspeKdKtguvflF2W5DYshxYRX2yPAs+UU8FEsHJTVyeKEfgbLEOWkEI2OBGYBnFwMF/O55P1hJPt8sY=
X-Received: by 2002:a05:6870:d28d:b0:da:b3f:3234 with SMTP id
 d13-20020a056870d28d00b000da0b3f3234mr5585722oae.228.1649314889358; Thu, 07
 Apr 2022 00:01:29 -0700 (PDT)
MIME-Version: 1.0
References: <CAApHDvqvp3At8++yF8ij06sdcoo1S_b2YoaT9D4Nf+MObzsrLQ@mail.gmail.com>
 <CAApHDvrxxkc9dgoRJUHy6U+XmGjSXRF=fQ-_U1-EvzTjCA9XKw@mail.gmail.com>
 <CALNJ-vSRgdOsMx-oiOZcMJzcxoRCo0nJr=U8us4eJR8R6n9ZtA@mail.gmail.com>
 <CAApHDvpiAUmUMTETAua8XCLFJiFhsZkCwuiW50KDvehexA-SLA@mail.gmail.com>
 <CAKU4AWq5MB_inrYUwPQYXU1fCopCwgYK53N2uYGYFBH3QEhZMA@mail.gmail.com>
 <CAApHDvp8PSY3GJXNzzrBPJtzRgQ-C85OPy-bypFGmwaT3AjCjQ@mail.gmail.com>
 <CAKU4AWrWzXFuGW4d3YTu=TJSWQKTB=J3E8S_5zyuLNR7npomAA@mail.gmail.com>
 <CAApHDvqtwE4bZxAdk+LQgVkKM+Em-sHybON_OX4YbFs+sQUKWg@mail.gmail.com>
 <CAApHDvoe=MqH66pDWynUtdammYHiB8m+zE7LvL_CGuxm1yK4BQ@mail.gmail.com>
 <CAApHDvpYYndDJfGCmNA-o60VLb8D9OB1deh-qcsTiDjxVcFg_w@mail.gmail.com>
 <20220329221615.hule724qcaarhe3y@alap3.anarazel.de> <CAApHDvp+rzxGh58hc3Fmr90PR-M=JOg96X0B5tfvY4pTKqNa3g@mail.gmail.com>
 <CAKU4AWoiqPd_DdOA_0PWZ_e9cV6e1yP6F0VmxaLjedwTWQtBJA@mail.gmail.com>
 <CAKU4AWpmDGMxQ3nJfj=awQAgcL-jP2p67MtpiHFZX77NaZ2hxQ@mail.gmail.com>
 <CAApHDvrU132PxjuLakFrQhjR_b40LHAqhCzk-q2iGOST+-6dCw@mail.gmail.com>
 <CAKU4AWrzzC4GCe2Mo_fYxc_SY=Ss1i0x-AEMjP_mxZYe6aMw=w@mail.gmail.com>
 <CAApHDvpou0r+AOT9JZZEsiANQY=w=BTiRXgWR230NzOG7D3VUg@mail.gmail.com> <CALNJ-vTaG0i+Sx4bruXDKNnppfMJS0nt7E=7Roo7VXAuxZFWiw@mail.gmail.com>
In-Reply-To: <CALNJ-vTaG0i+Sx4bruXDKNnppfMJS0nt7E=7Roo7VXAuxZFWiw@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Thu, 7 Apr 2022 19:01:13 +1200
Message-ID: <CAApHDvrqaRrmS6Ee7hQ5NfRpfNGGS+Y0dhootWvkyUxMeoTm7w@mail.gmail.com>
Subject: Re: Window Function "Run Conditions"
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Andy Fan <zhihui.fan1213@gmail.com>, Andres Freund <andres@anarazel.de>, 
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAApHDvrqaRrmS6Ee7hQ5NfRpfNGGS%2BY0dhootWvkyUxMeoTm7w%40mail.gmail.com>
Precedence: bulk

On Thu, 7 Apr 2022 at 15:41, Zhihong Yu <zyu@yugabyte.com> wrote:
> +                * We must keep the original qual in place if there is a
> +                * PARTITION BY clause as the top-level WindowAgg remains in
> +                * pass-through mode and does nothing to filter out unwanted
> +                * tuples.
> +                */
> +               *keep_original = false;
>
> The comment talks about keeping original qual but the assignment uses the value false.
> Maybe the comment can be rephrased so that it matches the assignment.

Thanks. I've just removed that comment locally now. You're right, it
was out of date.

David