MIME-Version: 1.0
From: Joseph Koshakow <koshy44@gmail.com>
Date: Fri, 24 Feb 2023 12:23:27 -0500
Message-ID: <CAAvxfHfJuAaKXVTQ7e3EdDko=qyEh-GwgZe_RqzK9MWgcxp9Xw@mail.gmail.com>
Subject: Inconsistency in ACL error message
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d72c0305f5756306"
Archived-At: <https://www.postgresql.org/message-id/CAAvxfHfJuAaKXVTQ7e3EdDko%3DqyEh-GwgZe_RqzK9MWgcxp9Xw%40mail.gmail.com>
Precedence: bulk

--000000000000d72c0305f5756306
Content-Type: multipart/alternative; boundary="000000000000d72c0105f5756304"

--000000000000d72c0105f5756304
Content-Type: text/plain; charset="UTF-8"

Hi all,

I noticed a very minor inconsistency in some ACL error messages. When
you are try and alter a role, it just says "permission denied":

  postgres=> ALTER ROLE bar NOCREATEDB;
  ERROR:  permission denied
  postgres=> ALTER ROLE bar SET search_path TO 'foo';
  ERROR:  permission denied

For almost all other ACL error, we include what the action was. For
example:

  postgres=> CREATE ROLE r;
  ERROR:  permission denied to create role
  postgres=> DROP ROLE postgres;
  ERROR:  permission denied to drop role
  postgres=> CREATE DATABASE foo;
  ERROR:  permission denied to create database


It's not a huge deal, but it's easy enough to fix that I thought I'd
generate a patch (attached). Let me know if people think that it's
worth merging.

- Joe Koshakow

--000000000000d72c0105f5756304
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi all,<br><br>I noticed a very minor inconsistency in som=
e ACL error messages. When<br>you are try and alter a role, it just says &q=
uot;permission denied&quot;:<br><br>=C2=A0 postgres=3D&gt; ALTER ROLE bar N=
OCREATEDB;<br>=C2=A0 ERROR: =C2=A0permission denied<br>=C2=A0 postgres=3D&g=
t; ALTER ROLE bar SET search_path TO &#39;foo&#39;;<br>=C2=A0 ERROR: =C2=A0=
permission denied<br><br>For almost all other ACL error, we include what th=
e action was. For<br>example:<br><br>=C2=A0 postgres=3D&gt; CREATE ROLE r;<=
br>=C2=A0 ERROR: =C2=A0permission denied to create role<br>=C2=A0 postgres=
=3D&gt; DROP ROLE postgres;<br>=C2=A0 ERROR: =C2=A0permission denied to dro=
p role<br>=C2=A0 postgres=3D&gt; CREATE DATABASE foo;<br>=C2=A0 ERROR: =C2=
=A0permission denied to create database<br><br><br>It&#39;s not a huge deal=
, but it&#39;s easy enough to fix that I thought I&#39;d<br>generate a patc=
h (attached). Let me know if people think that it&#39;s<br>worth merging.<b=
r><br>- Joe Koshakow</div>

--000000000000d72c0105f5756304--
--000000000000d72c0305f5756306
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="v1-0001-Add-details-to-ALTER-ROLE-permission-errors.patch"
Content-Disposition: attachment; 
	filename="v1-0001-Add-details-to-ALTER-ROLE-permission-errors.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_leisxl2k0>
X-Attachment-Id: f_leisxl2k0

RnJvbSAzYWIzMWJjNzU1MDQzOTczY2U1NmVlNjIwYWQ5OWI1Nzg5ZDEyMTExIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKb3NlcGggS29zaGFrb3cgPGtvc2h5NDRAZ21haWwuY29tPgpE
YXRlOiBGcmksIDI0IEZlYiAyMDIzIDEyOjA1OjE5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IGRldGFpbHMgdG8gQUxURVIgUk9MRSBwZXJtaXNzaW9uIGVycm9ycwoKLS0tCiBzcmMvYmFja2Vu
ZC9jb21tYW5kcy91c2VyLmMgICAgICAgICAgICAgICB8IDQgKystLQogc3JjL3Rlc3QvcmVncmVz
cy9leHBlY3RlZC9jcmVhdGVfcm9sZS5vdXQgfCAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDMgaW5z
ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21t
YW5kcy91c2VyLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy91c2VyLmMKaW5kZXggM2E5MmU5MzBj
MC4uMmM3YTQyMDRhNiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdXNlci5jCisr
KyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3VzZXIuYwpAQCAtNzYxLDcgKzc2MSw3IEBAIEFsdGVy
Um9sZShQYXJzZVN0YXRlICpwc3RhdGUsIEFsdGVyUm9sZVN0bXQgKnN0bXQpCiAJCQlkdmFsaWRV
bnRpbCB8fCBkaXNyZXBsaWNhdGlvbiB8fCBkYnlwYXNzUkxTKQogCQkJZXJlcG9ydChFUlJPUiwK
IAkJCQkJKGVycmNvZGUoRVJSQ09ERV9JTlNVRkZJQ0lFTlRfUFJJVklMRUdFKSwKLQkJCQkJIGVy
cm1zZygicGVybWlzc2lvbiBkZW5pZWQiKSkpOworCQkJCQkgZXJybXNnKCJwZXJtaXNzaW9uIGRl
bmllZCB0byBhbHRlciByb2xlIikpKTsKIAogCQkvKiBhbiB1bnByaXZpbGVnZWQgdXNlciBjYW4g
Y2hhbmdlIHRoZWlyIG93biBwYXNzd29yZCAqLwogCQlpZiAoZHBhc3N3b3JkICYmIHJvbGVpZCAh
PSBjdXJyZW50VXNlcklkKQpAQCAtMTAwOCw3ICsxMDA4LDcgQEAgQWx0ZXJSb2xlU2V0KEFsdGVy
Um9sZVNldFN0bXQgKnN0bXQpCiAJCQkJJiYgcm9sZWlkICE9IEdldFVzZXJJZCgpKQogCQkJCWVy
ZXBvcnQoRVJST1IsCiAJCQkJCQkoZXJyY29kZShFUlJDT0RFX0lOU1VGRklDSUVOVF9QUklWSUxF
R0UpLAotCQkJCQkJIGVycm1zZygicGVybWlzc2lvbiBkZW5pZWQiKSkpOworCQkJCQkJIGVycm1z
ZygicGVybWlzc2lvbiBkZW5pZWQgdG8gYWx0ZXIgcm9sZSIpKSk7CiAJCX0KIAogCQlSZWxlYXNl
U3lzQ2FjaGUocm9sZXR1cGxlKTsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0
ZWQvY3JlYXRlX3JvbGUub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jcmVhdGVfcm9s
ZS5vdXQKaW5kZXggOWY0MzFiZDRmNS4uNjkxY2ZmODZkMiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3Qv
cmVncmVzcy9leHBlY3RlZC9jcmVhdGVfcm9sZS5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9l
eHBlY3RlZC9jcmVhdGVfcm9sZS5vdXQKQEAgLTk4LDcgKzk4LDcgQEAgRVJST1I6ICBtdXN0IGhh
dmUgYWRtaW4gb3B0aW9uIG9uIHJvbGUgInJlZ3Jlc3Nfcm9sZV9ub3JtYWwiCiBBTFRFUiBST0xF
IHJlZ3Jlc3Nfcm9sZV9ub3JtYWwgUkVOQU1FIFRPIHJlZ3Jlc3Nfcm9sZV9hYm5vcm1hbDsKIEVS
Uk9SOiAgcGVybWlzc2lvbiBkZW5pZWQgdG8gcmVuYW1lIHJvbGUKIEFMVEVSIFJPTEUgcmVncmVz
c19yb2xlX25vcm1hbCBOT0lOSEVSSVQgTk9MT0dJTiBDT05ORUNUSU9OIExJTUlUIDc7Ci1FUlJP
UjogIHBlcm1pc3Npb24gZGVuaWVkCitFUlJPUjogIHBlcm1pc3Npb24gZGVuaWVkIHRvIGFsdGVy
IHJvbGUKIC0tIG9rLCByZWdyZXNzX3RlbmFudCBjYW4gY3JlYXRlIG9iamVjdHMgd2l0aGluIHRo
ZSBkYXRhYmFzZQogU0VUIFNFU1NJT04gQVVUSE9SSVpBVElPTiByZWdyZXNzX3RlbmFudDsKIENS
RUFURSBUQUJMRSB0ZW5hbnRfdGFibGUgKGkgaW50ZWdlcik7Ci0tIAoyLjM0LjEKCg==
--000000000000d72c0305f5756306--