MIME-Version: 1.0
References: 
 <CANxoLDfjQnhM=E6JSyYo9s9OdjqoN8s_3wE5yL=kaDu_X8j-dA@mail.gmail.com>
 <CANxoLDcxmXNHNyPt5v+LaBJVJmyt=j95D7TDE9SepoM7y15t-w@mail.gmail.com>
 <CAN4CZFNqf41TCg1ENccq6DAYQpArCbnKUSidHnRKaVMWGj5pBA@mail.gmail.com>
 <CANxoLDfL1AxL=k9SsRNReKQ-sJUSy6RvCqeog5HWckFxff=0Pg@mail.gmail.com>
 <CAN4CZFP5-fAGwxMCyKGePgp3N8NCpoFXkruO=5xjTC=gPwqYxw@mail.gmail.com>
 <CANxoLDc6UFMsyzbXKF8SpMoXdoKE=-yRPqtvyBMKKJ2zOUKX4A@mail.gmail.com>
 <CAN4CZFMhnZyQsdLC5iZNego77JHJyP6J_4CpWu=99vKHCd-vzg@mail.gmail.com>
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
In-Reply-To: 
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
From: Marcos Pegoraro <marcos@f10.com.br>
Date: Thu, 11 Jun 2026 10:07:37 -0300
Message-ID: 
 <CAB-JLwY=RYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov+Ktg@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000084682c0653fa0de0"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB-JLwY%3DRYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov%2BKtg%40mail.gmail.com>
Precedence: bulk

--00000000000084682c0653fa0de0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qui., 11 de jun. de 2026 =C3=A0s 04:48, Akshay Joshi <
akshay.joshi@enterprisedb.com> escreveu:

>  Fixed the issue above. The v5 patch is ready for review/testing.
>

One thing I noticed, though I'm not sure if it's the point here, is that
it's not possible to extract only the foreign keys or only the triggers
from the table. So if we want to extract the objects independently by type,
we would need to have all the return types as optional, and we could have
more granularity in the return types.

Just like you have...
if (!ctx->include_indexes)

You could have too
+ if (!ctx->include_create_table)
+ if (!ctx->include_foreign_keys)
+ if (!ctx->include_primary_keys)

Because only in this way can we more or less execute the dump behavior
here, which is to create all the tables beforehand, then primary keys, then
foreign keys, then triggers.

I repeat, sorry if this is not the function's intended purpose.

regards
Marcos

--00000000000084682c0653fa0de0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif;color:rgb(102,102,102)"><span style=3D"font-fam=
ily:Arial,Helvetica,sans-serif;color:rgb(34,34,34)">Em qui., 11 de jun. de =
2026 =C3=A0s 04:48, Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@enterpr=
isedb.com">akshay.joshi@enterprisedb.com</a>&gt; escreveu:</span></div></di=
v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">=C2=A0Fixed the=
 issue above. The v5 patch is ready for review/testing.</div></div></blockq=
uote><div><span class=3D"gmail_default" style=3D"font-family:verdana,sans-s=
erif;color:rgb(102,102,102)"><br></span></div><div><span class=3D"gmail_def=
ault" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"></spa=
n><span style=3D"color:rgb(102,102,102);font-family:verdana,sans-serif">One=
 thing I noticed, though I&#39;m not sure if it&#39;s the point here, is th=
at it&#39;s not possible to extract only the foreign keys or only the trigg=
ers from the table. So if we want to extract the objects independently by t=
ype, we would need to have all the return types as optional, and we could h=
ave more granularity in the return types.</span></div><div class=3D"gmail_d=
efault" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"><br=
></div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif=
;color:rgb(102,102,102)">Just like you have...</div><div class=3D"gmail_def=
ault" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">if (!=
ctx-&gt;include_indexes)</div><div class=3D"gmail_default" style=3D"font-fa=
mily:verdana,sans-serif;color:rgb(102,102,102)"><br></div><div class=3D"gma=
il_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"=
>You could have too</div><div class=3D"gmail_default" style=3D"font-family:=
verdana,sans-serif;color:rgb(102,102,102)">+ if (!ctx-&gt;include_create_ta=
ble)</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-se=
rif;color:rgb(102,102,102)">+ if (!ctx-&gt;include_foreign_keys)</div><div =
class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(1=
02,102,102)">+ if (!ctx-&gt;include_primary_keys)</div><div class=3D"gmail_=
default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"><b=
r></div><div><span style=3D"color:rgb(102,102,102);font-family:verdana,sans=
-serif">Because only in this way can we more or less execute the dump behav=
ior here, which is to create all the tables beforehand, then primary keys, =
then foreign keys, then triggers.</span>=C2=A0</div><div><br></div><div><di=
v class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb=
(102,102,102)">I repeat, sorry if this is not the function&#39;s intended p=
urpose.</div><br></div><div><div class=3D"gmail_default" style=3D"font-fami=
ly:verdana,sans-serif;color:rgb(102,102,102)">regards</div><div class=3D"gm=
ail_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)=
">Marcos</div><br></div></div></div>

--00000000000084682c0653fa0de0--