MIME-Version: 1.0
References: 
 <CANxoLDfjQnhM=E6JSyYo9s9OdjqoN8s_3wE5yL=kaDu_X8j-dA@mail.gmail.com>
 <CANxoLDcxmXNHNyPt5v+LaBJVJmyt=j95D7TDE9SepoM7y15t-w@mail.gmail.com>
 <CAN4CZFNqf41TCg1ENccq6DAYQpArCbnKUSidHnRKaVMWGj5pBA@mail.gmail.com>
 <CANxoLDfL1AxL=k9SsRNReKQ-sJUSy6RvCqeog5HWckFxff=0Pg@mail.gmail.com>
 <CAN4CZFP5-fAGwxMCyKGePgp3N8NCpoFXkruO=5xjTC=gPwqYxw@mail.gmail.com>
 <CANxoLDc6UFMsyzbXKF8SpMoXdoKE=-yRPqtvyBMKKJ2zOUKX4A@mail.gmail.com>
 <CAN4CZFMhnZyQsdLC5iZNego77JHJyP6J_4CpWu=99vKHCd-vzg@mail.gmail.com>
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
 <CAB-JLwY=RYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov+Ktg@mail.gmail.com>
 <CANxoLDdRts-F+QxL+wtM8529Z3+TUJku8PKy3WoxcWBs7zQJ-w@mail.gmail.com>
 <CAB-JLwbyzF+JRPCoLCf-H6dQ_1+-O_wBZcESRdC6_H2z+-d-gg@mail.gmail.com>
 <CANxoLDcWwoWOxvmV_uBBUsbGf+_AZzBV1GkcjoX+omNpcrCNMQ@mail.gmail.com>
 <CAN4CZFM99cGopPJXD_t05+Y9CnocOOTipfXCzoAfBUFSC-i4+A@mail.gmail.com>
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
In-Reply-To: 
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
From: Marcos Pegoraro <marcos@f10.com.br>
Date: Mon, 22 Jun 2026 11:54:38 -0300
Message-ID: 
 <CAB-JLwYLFJ9aroD0V9VWWWfrMQFQVRv4dZgJKmCFEs+JMoNQ7g@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000008401c20654d8d41b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB-JLwYLFJ9aroD0V9VWWWfrMQFQVRv4dZgJKmCFEs%2BJMoNQ7g%40mail.gmail.com>
Precedence: bulk

--0000000000008401c20654d8d41b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em seg., 22 de jun. de 2026 =C3=A0s 03:27, Akshay Joshi <
akshay.joshi@enterprisedb.com> escreveu:

> The documentation paragraph for `includes_foreign_keys` now directs users
> to `only_foreign_keys` as the intended second pass. Regression coverage
> adds three cases: the FK-only emission for your cons example, the zero-ro=
w
> result for a table without FKs, and the error path.
>
>>
I still think this model of only having options for foreign keys is
incomplete, maybe wrong.
Imagine then cloning a schema from a publication server to be executed on a
subscription server. So I don't want any other constraints besides the
primary key, for example. The way you implemented it is not possible.

Furthermore having only_foreign_keys and includes_foreign_keys seems
confuse.

regards
Marcos

--0000000000008401c20654d8d41b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><span style=3D"background-color:tran=
sparent">Em seg., 22 de jun. de 2026 =C3=A0s 03:27, Akshay Joshi &lt;<a hre=
f=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterprisedb.com</a=
>&gt; escreveu:</span></div></div><div class=3D"gmail_quote gmail_quote_con=
tainer"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
<div><span style=3D"background-color:transparent">The documentation paragra=
ph for `includes_foreign_keys` now directs users to `only_foreign_keys` as =
the intended second pass. Regression coverage adds three cases: the FK-only=
 emission for your cons example, the zero-row result for a table without FK=
s, and the error path.=C2=A0</span></div><div></div></div><div class=3D"gma=
il_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote></=
div></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font-=
family:verdana,sans-serif;color:rgb(102,102,102)"><span style=3D"font-famil=
y:Arial,Helvetica,sans-serif;background-color:transparent;color:rgb(34,34,3=
4)">I still think this model of only having options for foreign keys is inc=
omplete, maybe wrong.</span></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif;color:rgb(102,102,102)"><span style=3D"font-fam=
ily:Arial,Helvetica,sans-serif;background-color:transparent;color:rgb(34,34=
,34)">Imagine then cloning a schema from a publication server to be execute=
d on a subscription server. So I=C2=A0</span><span style=3D"background-colo=
r:transparent;color:rgb(34,34,34);font-family:Arial,Helvetica,sans-serif">d=
on&#39;t want any other constraints besides the primary key, for example.=
=C2=A0</span><span style=3D"background-color:transparent;color:rgb(34,34,34=
);font-family:Arial,Helvetica,sans-serif">The way you implemented it is not=
 possible.</span></div><div class=3D"gmail_default" style=3D"font-family:ve=
rdana,sans-serif;color:rgb(102,102,102)"><span style=3D"background-color:tr=
ansparent;color:rgb(34,34,34);font-family:Arial,Helvetica,sans-serif"><br><=
/span></div><span class=3D"gmail_default" style=3D"font-family:verdana,sans=
-serif;color:rgb(102,102,102)"></span><span class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"></span>Furthermo=
re<span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;col=
or:rgb(102,102,102)">=C2=A0</span>having only_foreign_keys and includes_for=
eign_keys seems confuse.=C2=A0</div><div class=3D"gmail_quote gmail_quote_c=
ontainer"><br></div><div class=3D"gmail_quote gmail_quote_container"><div c=
lass=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(10=
2,102,102)">regards</div><div class=3D"gmail_default" style=3D"font-family:=
verdana,sans-serif;color:rgb(102,102,102)">Marcos</div><br></div></div>

--0000000000008401c20654d8d41b--