MIME-Version: 1.0
References: 
 <CANxoLDfjQnhM=E6JSyYo9s9OdjqoN8s_3wE5yL=kaDu_X8j-dA@mail.gmail.com>
 <CANxoLDcxmXNHNyPt5v+LaBJVJmyt=j95D7TDE9SepoM7y15t-w@mail.gmail.com>
 <CAN4CZFNqf41TCg1ENccq6DAYQpArCbnKUSidHnRKaVMWGj5pBA@mail.gmail.com>
 <CANxoLDfL1AxL=k9SsRNReKQ-sJUSy6RvCqeog5HWckFxff=0Pg@mail.gmail.com>
 <CAN4CZFP5-fAGwxMCyKGePgp3N8NCpoFXkruO=5xjTC=gPwqYxw@mail.gmail.com>
 <CANxoLDc6UFMsyzbXKF8SpMoXdoKE=-yRPqtvyBMKKJ2zOUKX4A@mail.gmail.com>
 <CAN4CZFMhnZyQsdLC5iZNego77JHJyP6J_4CpWu=99vKHCd-vzg@mail.gmail.com>
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
 <CAB-JLwY=RYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov+Ktg@mail.gmail.com>
 <CANxoLDdRts-F+QxL+wtM8529Z3+TUJku8PKy3WoxcWBs7zQJ-w@mail.gmail.com>
 <CAB-JLwbyzF+JRPCoLCf-H6dQ_1+-O_wBZcESRdC6_H2z+-d-gg@mail.gmail.com>
 <CANxoLDcWwoWOxvmV_uBBUsbGf+_AZzBV1GkcjoX+omNpcrCNMQ@mail.gmail.com>
 <CAN4CZFM99cGopPJXD_t05+Y9CnocOOTipfXCzoAfBUFSC-i4+A@mail.gmail.com>
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
 <983C7B03-D9C3-4F15-8913-7616EC5E6414@gmail.com>
 <CANxoLDe_GOXyyZs7GN3VUJoT+o1DwqZGhid-TWWvS0D8d5ggYw@mail.gmail.com>
 <20260623.162104.775158751399277188.horikyota.ntt@gmail.com>
 <CANxoLDdq06oXRYuzYfn2gkn3yfoxp=nA14xu5p+qSEOzpHXEMQ@mail.gmail.com>
 <CANxoLDdEBYzKfj3NGrP5PjoTa-eCViWPkFR-sXLq4bUnbokyPA@mail.gmail.com>
 <CAN4CZFPKAr2VfxGMTA4CkMPHVSnpQrRKJcwUH1ZLh4eHG09LSw@mail.gmail.com>
 <CANxoLDe308ogjUZD4DLjaMysJzHZ4z3SOXbUTyC7SAEKvSgqcw@mail.gmail.com>
 <CAHWVJhHW4jcfS=w20Ungecb3A4uWiHe9OM9OLHHBtokhKaCs=w@mail.gmail.com>
 <CANxoLDcAy+46QesKdK95XFM3z9eT6PsiJ4Tx_GSQmtbg1O7Evw@mail.gmail.com>
 <CANxoLDd0KT+5fHOyTi0Fu5Jwme0+a5S2aAVj=iCVsqkpvF_2TA@mail.gmail.com>
 <CAN4CZFPxokhJ2vTiTu9Bhj+v7T+5jZd4pjT7QXdjoZ4Vqv5KhQ@mail.gmail.com>
 <CANxoLDdVEjCCKch1O-5J6ghw89b2fkWC1ADPYTUwxu8WB-hQbw@mail.gmail.com>
 <CAB-JLwY1O-owU39ebG=fJZo0z2j+2z=y5R+w8pmpHx9GNqvnOw@mail.gmail.com>
 <CANxoLDcGVyoRtCLoY4qqJtXDNk4BxsrDz3MZ8vBJJOLRgBZd9A@mail.gmail.com>
In-Reply-To: 
 <CANxoLDcGVyoRtCLoY4qqJtXDNk4BxsrDz3MZ8vBJJOLRgBZd9A@mail.gmail.com>
From: Marcos Pegoraro <marcos@f10.com.br>
Date: Thu, 2 Jul 2026 13:35:41 -0300
Message-ID: 
 <CAB-JLwYy_khadXQxn9Wg1H66F6+sCM7TXNare1oLEW5ZAwrjqQ@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000004414350655a36899"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB-JLwYy_khadXQxn9Wg1H66F6%2BsCM7TXNare1oLEW5ZAwrjqQ%40mail.gmail.com>
Precedence: bulk

--0000000000004414350655a36899
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qui., 2 de jul. de 2026 =C3=A0s 04:49, Akshay Joshi <
akshay.joshi@enterprisedb.com> escreveu:

> *owner* is the one case where it could work, but to make it consistent
> with how owner behaves in pg_get_tablespace_ddl and pg_get_database_ddl, =
we
> should not add it.
>
> *tablespace* doesn't map to a kind at all. It controls the inline
> TABLESPACE clause within the CREATE TABLE statement body it's a sub-claus=
e,
> not a separate statement. If we added tablespace as a kind, except_kinds =
=3D>
> '{table,tablespace}' would be wrong (if you're skipping the table
> statement, there's no inline clause to suppress), and except_kinds =3D>
> '{tablespace}' would imply skipping a standalone statement that doesn't
> exist.
>
> *pretty* and *schema_qualified* are rendering/formatting options, not
> statement filters. They affect how every statement is rendered =E2=80=94
> indentation, name qualification =E2=80=94 not which statements are emitte=
d. Putting
> them in except_kinds conflates two orthogonal axes: filtering (what to
> emit) and formatting (how to emit it).
>
>>
Well, I thought you could continue with the same variable structure, just
assigning them beforehand if those values were used in the kind list.
So, TableDdlContext continues the same, you just add
TABLE_DDL_KIND_NO_OWNER and others to TableDdlKind

And before anything you see if TableDdlKind->TABLE_DDL_KIND_NO_OWNER is set
then TableDdlContext->no_owner receives that value, just that.

regards
Marcos

--0000000000004414350655a36899
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><span style=3D"background-color:tran=
sparent">Em qui., 2 de jul. de 2026 =C3=A0s 04:49, Akshay Joshi &lt;<a href=
=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterprisedb.com</a>=
&gt; escreveu:</span></div></div><div class=3D"gmail_quote gmail_quote_cont=
ainer"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><=
div dir=3D"ltr"><b style=3D"background-color:transparent">owner</b><span st=
yle=3D"background-color:transparent"> is the one case where it could work, =
but to make it consistent with how owner behaves in pg_get_tablespace_ddl a=
nd pg_get_database_ddl, we should not add it.</span></div><div class=3D"gma=
il_quote"><div class=3D"gmail_quote"><br></div><b>tablespace</b> doesn&#39;=
t map to a kind at all. It controls the inline TABLESPACE clause within the=
 CREATE TABLE statement body it&#39;s a sub-clause, not a separate statemen=
t. If we added tablespace as a kind, except_kinds =3D&gt; &#39;{table,table=
space}&#39; would be wrong (if you&#39;re skipping the table statement, the=
re&#39;s no inline clause to suppress), and except_kinds =3D&gt; &#39;{tabl=
espace}&#39; would imply skipping a standalone statement that doesn&#39;t e=
xist.</div><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">=
<b>pretty</b> and <b>schema_qualified</b> are rendering/formatting options,=
 not statement filters. They affect how every statement is rendered =E2=80=
=94 indentation, name qualification =E2=80=94 not which statements are emit=
ted. Putting them in except_kinds conflates two orthogonal axes: filtering =
(what to emit) and formatting (how to emit it).<br><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr=
"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div =
dir=3D"ltr"><div class=3D"gmail_quote"><div style=3D"font-family:verdana,sa=
ns-serif;color:rgb(102,102,102)"></div></div></div></div></div></div></div>=
</div></div></div></blockquote></div></div></blockquote><div><br></div><div=
 class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(=
102,102,102)">Well, I thought you could continue with the same variable str=
ucture, just assigning them beforehand if those values were used in the kin=
d list.</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans=
-serif;color:rgb(102,102,102)">So, TableDdlContext continues the same, you =
just add TABLE_DDL_KIND_NO_OWNER and others to TableDdlKind<br><br></div><d=
iv class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rg=
b(102,102,102)">And before anything you see if=C2=A0<span style=3D"backgrou=
nd-color:transparent">TableDdlKind-&gt;TABLE_DDL_KIND_NO_OWNER is set then=
=C2=A0</span><span style=3D"background-color:transparent">TableDdlContext-&=
gt;no_owner receives that value, just that.</span></div><div class=3D"gmail=
_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"><=
span style=3D"background-color:transparent"><br></span></div><div class=3D"=
gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,10=
2)"><span style=3D"background-color:transparent">regards</span></div><div c=
lass=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(10=
2,102,102)"><span style=3D"background-color:transparent">Marcos</span></div=
></div></div>

--0000000000004414350655a36899--