MIME-Version: 1.0
References: <202508301750.cbohxyy2pcce@alvherre.pgsql>
 <202509251758.t77p7r2ocmej@alvherre.pgsql>
 <CAB-JLwZTViGAi01hC9_G4HNwL59W4tKovFPuoL+7ZLwsiKDiiw@mail.gmail.com>
 <CAJSLCQ38JzwVr+O1G9WhVw+G5MuECCD0T_e55097m9-gc2qfnQ@mail.gmail.com>
In-Reply-To: 
 <CAJSLCQ38JzwVr+O1G9WhVw+G5MuECCD0T_e55097m9-gc2qfnQ@mail.gmail.com>
From: Marcos Pegoraro <marcos@f10.com.br>
Date: Thu, 25 Sep 2025 18:46:48 -0300
Message-ID: 
 <CAB-JLwaVjXzYJxZVbEQuOjNRYz+1XLE-V5oZsT0DAqNJQgUbXw@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Robert Treat <rob@xzilla.net>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>,
	Fujii Masao <masao.fujii@gmail.com>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000065f371063fa71d5b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB-JLwaVjXzYJxZVbEQuOjNRYz%2B1XLE-V5oZsT0DAqNJQgUbXw%40mail.gmail.com>
Precedence: bulk

--00000000000065f371063fa71d5b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qui., 25 de set. de 2025 =C3=A0s 18:31, Robert Treat <rob@xzilla.net>
escreveu:

> This pattern is used because you can pass more than one argument, for
> example, something like


I know that

>
> While I agree that the wording is a little awkward, this follows the same
> pattern as pg_dump and friends.
>

well, I think pg_dump looks wrong too. Because if you explain that it's a
single table or single schema on docs, why you write on plural on usage ?
+        Repack or analyze all tables in
+        <replaceable class=3D"parameter">schema</replaceable> only.  Multi=
ple
+        schemas can be repacked by writing multiple <option>-n</option>
+        switches.

instead of
+ printf(_("  -n, --schema=3DSCHEMA             repack tables in the
specified schema(s) only\n"));
maybe this ?
+ printf(_("  -n, --schema=3DSCHEMA             repack tables in the
specified schema, can be used several times\n"));

regards
Marcos

--00000000000065f371063fa71d5b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Em qui., 25 de set. de 2025 =C3=A0s =
18:31, Robert Treat &lt;<a href=3D"mailto:rob@xzilla.net">rob@xzilla.net</a=
>&gt; escreveu:</div></div><div class=3D"gmail_quote gmail_quote_container"=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex">This pattern is used bec=
ause you can pass more than one argument, for<br>
example, something like</blockquote><div><br></div><div class=3D"gmail_defa=
ult" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">I know=
 that</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
While I agree that the wording is a little awkward<span class=3D"gmail_defa=
ult" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">,=C2=
=A0</span>this follows the same<br>
pattern as pg_dump and friends.<br></blockquote><div><br></div><div class=
=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,10=
2,102)">well, I think pg_dump looks wrong too. Because if you explain that =
it&#39;s a=C2=A0</div><div class=3D"gmail_default" style=3D"font-family:ver=
dana,sans-serif;color:rgb(102,102,102)">single table or single schema on do=
cs, why you write on plural on usage ?</div><div class=3D"gmail_default" st=
yle=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">+ =C2=A0 =C2=
=A0 =C2=A0 =C2=A0Repack or analyze all tables in<br>+ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0&lt;replaceable class=3D&quot;parameter&quot;&gt;schema&lt;/replaceab=
le&gt; only.=C2=A0 Multiple<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0schemas can be =
repacked by writing multiple &lt;option&gt;-n&lt;/option&gt;<br>+ =C2=A0 =
=C2=A0 =C2=A0 =C2=A0switches.<br></div><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)"><br></div><div c=
lass=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(10=
2,102,102)">instead of=C2=A0</div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif;color:rgb(102,102,102)"><span style=3D"color:rg=
b(80,0,80);font-family:Arial,Helvetica,sans-serif">+ printf(_(&quot;=C2=A0 =
-n, --schema=3DSCHEMA=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0repack=
 tables in the specified schema(s) only\n&quot;));</span></div><div class=
=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,10=
2,102)"><span style=3D"color:rgb(80,0,80);font-family:Arial,Helvetica,sans-=
serif">maybe this ?</span></div><div class=3D"gmail_default" style=3D"font-=
family:verdana,sans-serif;color:rgb(102,102,102)"><span style=3D"color:rgb(=
80,0,80);font-family:Arial,Helvetica,sans-serif">+ printf(_(&quot;=C2=A0 -n=
, --schema=3DSCHEMA=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0</span><=
span style=3D"color:rgb(80,0,80);font-family:Arial,Helvetica,sans-serif">re=
pack tables in the specified schema, can be used several times</span><span =
style=3D"color:rgb(80,0,80);font-family:Arial,Helvetica,sans-serif">\n&quot=
;));</span></div><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif;color:rgb(102,102,102)"><br></div><div class=3D"gmail_default" s=
tyle=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">regards</div=
><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color=
:rgb(102,102,102)">Marcos</div></div></div>

--00000000000065f371063fa71d5b--