MIME-Version: 1.0
References: 
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
 <983C7B03-D9C3-4F15-8913-7616EC5E6414@gmail.com>
 <CANxoLDe_GOXyyZs7GN3VUJoT+o1DwqZGhid-TWWvS0D8d5ggYw@mail.gmail.com>
 <20260623.162104.775158751399277188.horikyota.ntt@gmail.com>
 <CANxoLDdq06oXRYuzYfn2gkn3yfoxp=nA14xu5p+qSEOzpHXEMQ@mail.gmail.com>
 <CANxoLDdEBYzKfj3NGrP5PjoTa-eCViWPkFR-sXLq4bUnbokyPA@mail.gmail.com>
In-Reply-To: 
 <CANxoLDdEBYzKfj3NGrP5PjoTa-eCViWPkFR-sXLq4bUnbokyPA@mail.gmail.com>
From: Marcos Pegoraro <marcos@f10.com.br>
Date: Tue, 23 Jun 2026 11:03:08 -0300
Message-ID: 
 <CAB-JLwbc=9iqgNiLFHAM0-ZMDD=reFsbDS+QFsSepfwZEtRFDQ@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, li.evan.chao@gmail.com,
	zsolt.parragi@percona.com, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000002381f90654ec3a7c"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB-JLwbc%3D9iqgNiLFHAM0-ZMDD%3DreFsbDS%2BQFsSepfwZEtRFDQ%40mail.gmail.com>
Precedence: bulk

--0000000000002381f90654ec3a7c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em ter., 23 de jun. de 2026 =C3=A0s 10:34, Akshay Joshi <
akshay.joshi@enterprisedb.com> escreveu:

> A quick note on a design change I made in the *pg_get_table_ddl* option
> surface
>

Much better now.

All options can be present or omitted, so why couldn't the owner also be
part of the include/exclude options too ?

Just one addition, some options are plural and others are not.
We have indexes, policies, triggers, but we also have check, unique,
exclusion.
You don't know how many indices or checks you have, so wouldn't it be
better to have them in singular form ?

regards
Marcos

--0000000000002381f90654ec3a7c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><span style=3D"background-color:tran=
sparent">Em ter., 23 de jun. de 2026 =C3=A0s 10:34, Akshay Joshi &lt;<a hre=
f=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterprisedb.com</a=
>&gt; escreveu:</span></div></div><div class=3D"gmail_quote gmail_quote_con=
tainer"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
<div>A quick note on a design change I made in the <b>pg_get_table_ddl</b> =
option surface</div></div></blockquote><div><br></div><div class=3D"gmail_d=
efault" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">Muc=
h better now. </div><div class=3D"gmail_default" style=3D"font-family:verda=
na,sans-serif;color:rgb(102,102,102)"><span style=3D"font-family:Arial,Helv=
etica,sans-serif;background-color:transparent;color:rgb(34,34,34)"><br></sp=
an></div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-ser=
if;color:rgb(102,102,102)">All options can be present or omitted, so why co=
uldn&#39;t the owner also be part of the include/exclude options too ?</div=
><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color=
:rgb(102,102,102)"><span style=3D"font-family:Arial,Helvetica,sans-serif;ba=
ckground-color:transparent;color:rgb(34,34,34)"><br></span></div><div class=
=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,10=
2,102)">Just one addition, some options are plural and others are not.</div=
><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color=
:rgb(102,102,102)">We have indexes, policies, triggers, but we also have ch=
eck, unique, exclusion.</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif;color:rgb(102,102,102)">You don&#39;t know how many =
indices or checks you=C2=A0have, so wouldn&#39;t it be better to have=C2=A0=
them in singular form ?</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif;color:rgb(102,102,102)"><br></div><div class=3D"gmai=
l_default" style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">=
regards</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans=
-serif;color:rgb(102,102,102)">Marcos</div></div></div>

--0000000000002381f90654ec3a7c--