MIME-Version: 1.0
From: zhanghu <kongbaik228@gmail.com>
Date: Thu, 26 Feb 2026 15:03:23 +0800
Message-ID: <CAB5m2QssN6UO+ckr6ZCcV0A71mKUB6WdiTw1nHo43v4DTW1Dfg@mail.gmail.com>
Subject: guc: make dereference style consistent in check_backtrace_functions
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000001512ce064bb4b8cc"
Archived-At: <https://www.postgresql.org/message-id/CAB5m2QssN6UO%2Bckr6ZCcV0A71mKUB6WdiTw1nHo43v4DTW1Dfg%40mail.gmail.com>
Precedence: bulk

--0000000000001512ce064bb4b8cc
Content-Type: multipart/alternative; boundary="0000000000001512cd064bb4b8ca"

--0000000000001512cd064bb4b8ca
Content-Type: text/plain; charset="UTF-8"

Hi,

In check_backtrace_functions(), most accesses to the input string follow
the pattern (*newval)[i]. However, the empty-string check is currently
written as:

if (*newval[0] == '\0')

While functionally correct due to how the compiler handles the
address-of-address context here, this form is semantically misleading. It
relies on implicit operator precedence rather than explicit intent.

The attached patch rewrites it as:

if ((*newval)[0] == '\0')

This change ensures semantic clarity and maintains a consistent
dereferencing style throughout the function. No functional changes are
introduced.

Regards,
Zhang Hu

--0000000000001512cd064bb4b8ca
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>In check_backtrace_functions(), most accesses t=
o the input string follow the pattern (*newval)[i]. However, the empty-stri=
ng check is currently written as:<br><br>if (*newval[0] =3D=3D &#39;\0&#39;=
)<br><br>While functionally correct due to how the compiler handles the add=
ress-of-address context here, this form is semantically misleading. It reli=
es on implicit operator precedence rather than explicit intent.<br><br>The =
attached patch rewrites it as:<br><br>if ((*newval)[0] =3D=3D &#39;\0&#39;)=
<br><br>This change ensures semantic clarity and maintains a consistent der=
eferencing style throughout the function. No functional changes are introdu=
ced.<br><br>Regards,<br>Zhang Hu</div>

--0000000000001512cd064bb4b8ca--
--0000000000001512ce064bb4b8cc
Content-Type: application/octet-stream; 
	name="v1-0001-guc-make-dereference-style-consistent-in-check_ba.patch"
Content-Disposition: attachment; 
	filename="v1-0001-guc-make-dereference-style-consistent-in-check_ba.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mm342phg0>
X-Attachment-Id: f_mm342phg0

RnJvbSA4NTkxOWZhOGY0NTAwYmU0NjZkYmMyZTBhMzcwNzJlMWI4NzMyNzAwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiB6aGFuZ2h1IDxrb25nYmFpazIyOEBnbWFpbC5jb20+CkRhdGU6
IFRodSwgMjYgRmViIDIwMjYgMTQ6NTQ6MjIgKzA4MDAKU3ViamVjdDogW1BBVENIIHYxXSBndWM6
IG1ha2UgZGVyZWZlcmVuY2Ugc3R5bGUgY29uc2lzdGVudCBpbgogY2hlY2tfYmFja3RyYWNlX2Z1
bmN0aW9ucwoKSW4gY2hlY2tfYmFja3RyYWNlX2Z1bmN0aW9ucygpLCB0aGUgZW1wdHktc3RyaW5n
IGNoZWNrIGlzIGN1cnJlbnRseQppbXBsZW1lbnRlZCBhczoKCiAgICBpZiAoKm5ld3ZhbFswXSA9
PSAnXDAnKQoKd2hpbGUgdGhlIHJlc3Qgb2YgdGhlIGZ1bmN0aW9uIGNvbnNpc3RlbnRseSBhY2Nl
c3NlcyB0aGUgc3RyaW5nIGFzCgogICAgKCpuZXd2YWwpW2ldCgpUaGlzIHBhdGNoIHJld3JpdGVz
IHRoZSBjaGVjayBhczoKCiAgICBpZiAoKCpuZXd2YWwpWzBdID09ICdcMCcpCgpUaGlzIGNoYW5n
ZSBlbnN1cmVzIHNlbWFudGljIGNsYXJpdHkgYW5kIG1haW50YWlucyBhIGNvbnNpc3RlbnQKZGVy
ZWZlcmVuY2luZyBzdHlsZSB0aHJvdWdob3V0IHRoZSBmdW5jdGlvbi4gTm8gZnVuY3Rpb25hbCBj
aGFuZ2VzCmFyZSBpbnRyb2R1Y2VkLgoKQXV0aG9yOiB6aGFuZ2h1IDxrb25nYmFpazIyOEBnbWFp
bC5jb20+Ci0tLQogc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jIHwgMiArLQogMSBmaWxl
IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj
L2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxv
Zy5jCmluZGV4IDBkMGJmMGY2YWE1Li42NTBhNzliN2UxMiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tl
bmQvdXRpbHMvZXJyb3IvZWxvZy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2Vycm9yL2Vsb2cu
YwpAQCAtMjYyNyw3ICsyNjI3LDcgQEAgY2hlY2tfYmFja3RyYWNlX2Z1bmN0aW9ucyhjaGFyICoq
bmV3dmFsLCB2b2lkICoqZXh0cmEsIEd1Y1NvdXJjZSBzb3VyY2UpCiAJCXJldHVybiBmYWxzZTsK
IAl9CiAKLQlpZiAoKm5ld3ZhbFswXSA9PSAnXDAnKQorCWlmICgoKm5ld3ZhbClbMF0gPT0gJ1ww
JykKIAl7CiAJCSpleHRyYSA9IE5VTEw7CiAJCXJldHVybiB0cnVlOwotLSAKMi4zMy4wCgo=
--0000000000001512ce064bb4b8cc--