MIME-Version: 1.0
References: <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
 <aakAmNjKyBWRU1vR@paquier.xyz>
 <e6a27751-8c91-4bff-ba07-2e97de99e34f@pgbackrest.org>
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
 <bc089939-a889-4fd4-bad8-42cc071cd58e@pgbackrest.org>
 <CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
 <8733e942-56fc-4542-9351-63f213f7e23c@pgbackrest.org>
 <CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com>
 <aapxCfGZb3TfzX68@paquier.xyz>
 <CAHGQGwFuXjy7wAkzeDg0cpwsLweyjNO1tACgUWtNdCDtwxZ9hQ@mail.gmail.com>
 <2d228e82-02b5-4e55-a082-1ce26fae5f0f@pgbackrest.org>
In-Reply-To: <2d228e82-02b5-4e55-a082-1ce26fae5f0f@pgbackrest.org>
From: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Date: Mon, 16 Mar 2026 08:44:44 +0100
Message-ID: 
 <CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>
Subject: Re: Improve checks for GUC recovery_target_xid
To: David Steele <david@pgbackrest.org>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001d7073064d1f6526"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB5wL7Y%3DBK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg%40mail.gmail.com>
Precedence: bulk

--0000000000001d7073064d1f6526
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,


David Steele <david@pgbackrest.org>, 6 Mar 2026 Cum, 16:01 tarihinde =C5=9F=
unu yazd=C4=B1:
>
> On 3/6/26 14:05, Fujii Masao wrote:
> > On Fri, Mar 6, 2026 at 3:15=E2=80=AFPM Michael Paquier <michael@paquier=
.xyz> wrote:
> >>
> >> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
> >>> Thanks for the patch! It looks good to me. Barring any objections, I
> >>> will commit it.
> >>
> >> Thanks.
> >
> > I've pushed the patch. Thanks!
>
> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add more
> tests in this area because they are so expensive but now I feel much
> better about it. But that's the last for this CF since there is more
> important stuff to be done.
>
> Regards,
> -David

I tried to create tests with the ALTER SYSTEM approach to validate the GUC.

You can review it if it's the correct approach or not. We can create a
new CF record if required for the patch.

Regards.

--0000000000001d7073064d1f6526
Content-Type: application/octet-stream;
	name="v1-0001-add-regression-tests-for-recovery-target-xid-validation.patch"
Content-Disposition: attachment;
	filename="v1-0001-add-regression-tests-for-recovery-target-xid-validation.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmsvnfnn0>
X-Attachment-Id: f_mmsvnfnn0

RnJvbSBhOGZmNThhNzU2NGI0ZGI3NDM4NWQwMTMwNTMwYzQ1ZGNjNmZkNWM3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIdXNleWluIERlbWlyIDxodXNleWluLmQzckBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgMTYgTWFyIDIwMjYgMDg6Mjc6MjIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBB
ZGQgcmVncmVzc2lvbiB0ZXN0cyBmb3IgcmVjb3ZlcnlfdGFyZ2V0X3hpZCBHVUMgdmFsaWRhdGlv
bgoKQWRkIHR3byB0ZXN0IGNhc2VzIHRvIHNyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5
X3RhcmdldHMucGwgdGhhdAp2ZXJpZnkgdGhlIGNoZWNrX3JlY292ZXJ5X3RhcmdldF94aWQgR1VD
IGhvb2sgY29ycmVjdGx5IHJlamVjdHMgaW52YWxpZAp2YWx1ZXMgdmlhIEFMVEVSIFNZU1RFTToK
CiAgLSBOb24tbnVtZXJpYyB2YWx1ZSAoJ2JvZ3VzJykgLT4gRUlOVkFMIGZyb20gc3RydG91NjQK
ICAtIE92ZXJmbG93IHZhbHVlICgnOTk5OTk5OTk5OTk5OTk5OTk5OTknKSAtPiBFUkFOR0UgZnJv
bSBzdHJ0b3U2NAoKQm90aCB0ZXN0cyB2ZXJpZnkgdGhlIHBzcWwgcmV0dXJuIGNvZGUgYW5kIHRo
ZSBlcnJvciBtZXNzYWdlIHBhdHRlcm4uClVzaW5nIEFMVEVSIFNZU1RFTSBvbiB0aGUgYWxyZWFk
eS1ydW5uaW5nIHByaW1hcnkgbm9kZSBleGVyY2lzZXMgdGhlIHNhbWUKY2hlY2sgaG9vayBjb2Rl
IHBhdGggYXMgdGhlIGNvbmYtZWRpdCArIHBnX2N0bC1zdGFydC1mYWlsdXJlIGFwcHJvYWNoCmJ1
dCBpcyBzaW1wbGVyIGFuZCBmYXN0ZXIgKG5vIHN0YW5kYnkgbm9kZSBjcmVhdGlvbiBuZWVkZWQp
LgotLS0KIHNyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3RhcmdldHMucGwgfCAxOCAr
KysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspCgpkaWZm
IC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDNfcmVjb3ZlcnlfdGFyZ2V0cy5wbCBiL3Ny
Yy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3RhcmdldHMucGwKaW5kZXggZTBkZjFhMjM0
MjMuLmFiYTBkYTE1MGRkIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzAwM19yZWNv
dmVyeV90YXJnZXRzLnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3Rh
cmdldHMucGwKQEAgLTI0MCw0ICsyNDAsMjIgQEAgb2soISRyZXMsICdpbnZhbGlkIHRpbWVsaW5l
IHRhcmdldCAodXBwZXIgYm91bmQgY2hlY2spJyk7CiAkbG9nX3N0YXJ0ID0KICAgJG5vZGVfc3Rh
bmRieS0+d2FpdF9mb3JfbG9nKCJtdXN0IGJlIGJldHdlZW4gMSBhbmQgNDI5NDk2NzI5NSIsICRs
b2dfc3RhcnQpOwogCisjIEludmFsaWQgcmVjb3ZlcnlfdGFyZ2V0X3hpZCB2aWEgQUxURVIgU1lT
VEVNIChub24tbnVtZXJpYykKK215ICRzdGRlcnIgPSAnJzsKKyRyZXQgPSAkbm9kZV9wcmltYXJ5
LT5wc3FsKCdwb3N0Z3JlcycsCisJIkFMVEVSIFNZU1RFTSBTRVQgcmVjb3ZlcnlfdGFyZ2V0X3hp
ZCA9ICdib2d1cyciLAorCXN0ZGVyciA9PiBcJHN0ZGVycik7CitvaygkcmV0ICE9IDAsICdBTFRF
UiBTWVNURU0gcmVqZWN0cyBub24tbnVtZXJpYyByZWNvdmVyeV90YXJnZXRfeGlkJyk7CitsaWtl
KCRzdGRlcnIsIHFyL2ludmFsaWQgdmFsdWUgZm9yIHBhcmFtZXRlciAicmVjb3ZlcnlfdGFyZ2V0
X3hpZCIvLAorCSdlcnJvciBtZXNzYWdlIGZvciBub24tbnVtZXJpYyBYSUQgdmFsdWUnKTsKKwor
IyBJbnZhbGlkIHJlY292ZXJ5X3RhcmdldF94aWQgdmlhIEFMVEVSIFNZU1RFTSAob3ZlcmZsb3cp
Ciskc3RkZXJyID0gJyc7CiskcmV0ID0gJG5vZGVfcHJpbWFyeS0+cHNxbCgncG9zdGdyZXMnLAor
CSJBTFRFUiBTWVNURU0gU0VUIHJlY292ZXJ5X3RhcmdldF94aWQgPSAnOTk5OTk5OTk5OTk5OTk5
OTk5OTknIiwKKwlzdGRlcnIgPT4gXCRzdGRlcnIpOworb2soJHJldCAhPSAwLCAnQUxURVIgU1lT
VEVNIHJlamVjdHMgb3ZlcmZsb3cgcmVjb3ZlcnlfdGFyZ2V0X3hpZCcpOworbGlrZSgkc3RkZXJy
LCBxci9pbnZhbGlkIHZhbHVlIGZvciBwYXJhbWV0ZXIgInJlY292ZXJ5X3RhcmdldF94aWQiLywK
KwknZXJyb3IgbWVzc2FnZSBmb3Igb3ZlcmZsb3cgWElEIHZhbHVlJyk7CisKIGRvbmVfdGVzdGlu
ZygpOwotLSAKMi41MC4xIChBcHBsZSBHaXQtMTU1KQoK
--0000000000001d7073064d1f6526--