MIME-Version: 1.0
References: <20260204213032.15bab46b@ardentperf.com>
 <CAHGQGwH7c5X4OkPaQ6VDaLGoFgJgwf_-HNwUi2uXoiAhkFkkyA@mail.gmail.com>
 <177304694613.1094603.10800724073727441272.pgcf@coridan.postgresql.org>
 <CAHGQGwG_Ud-N1zrULv8fE51-CUd2ZF3eDe7jUdNOm-rt_JgcQQ@mail.gmail.com>
 <017AD77A-21B6-4B0A-8847-207914D53CE0@gmail.com>
 <CAHGQGwEBvWXU4sdu2DMxaUWdPYQvGesr1VPyX-WnSxtW9nN6UA@mail.gmail.com>
 <CAB5wL7YB1my9W5k5i=SY+=sTjeozyJ0YkvGXrVfeDNzuRkoTPg@mail.gmail.com>
 <CAHGQGwGV3ufcdXnW6JLBhejfptCJRGs7Jrp03YPoO7V_b-2MFA@mail.gmail.com>
 <CAB5wL7amNFF3zA=h5R3Wx1aQZR-EKzv485LyYMLbB9X7dhx2Ew@mail.gmail.com>
 <CAHGQGwHPcgESm_cqQ52xeJtLFjfFY4hr+s6byYiojNKOwxO3Mg@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHPcgESm_cqQ52xeJtLFjfFY4hr+s6byYiojNKOwxO3Mg@mail.gmail.com>
From: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Date: Mon, 6 Apr 2026 14:59:49 +0200
Message-ID: 
 <CAB5wL7aSJ5Cw1VdX5V0L4s3t+T2=M=yXo07sC+JLdKggkLCkdA@mail.gmail.com>
Subject: Re: client_connection_check_interval default value
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000009c8b09064eca3ed3"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB5wL7aSJ5Cw1VdX5V0L4s3t%2BT2%3DM%3DyXo07sC%2BJLdKggkLCkdA%40mail.gmail.com>
Precedence: bulk

--0000000000009c8b09064eca3ed3
Content-Type: multipart/alternative; boundary="0000000000009c8b08064eca3ed1"

--0000000000009c8b08064eca3ed1
Content-Type: text/plain; charset="UTF-8"

Hi,


> Thanks for the patch!
>
> Commit 557a9f1e3e6 recently added test for lock stats, which also causes
> lock wait situations. So it seems better to extend that test to cover
> log_lock_waits rather than adding a new TAP test file.
>
> I've prepared a patch to do this. Patch attached. Thought?
>
> Regards,
>

Appreciated for the patch. I reviewed it quickly.

In the test description it says that `still waiting logged exactly once
despite pg_reload_conf() wakeups")` but the test sends via
pg_log_backend_memory_contexts(). It would make sense to update it.

```
  -  1, "still waiting logged exactly once despite pg_reload_conf()
wakeups");
  +  1, "still waiting logged exactly once despite wakeups from
pg_log_backend_memory_contexts()");
```

Secondly, before finishing the test it tries to check that no
log_lock_waits messages are emitted. But the comment has the opposite
meaning.

```
  - 'check that log_lock_waits message is emitted when the lock is acquired
after waiting'
  + 'check that no log_lock_waits message is emitted when the lock is
acquired after waiting'
```

I'm not sure they need to change but these are the only topics I wanted to
add. Otherwise, lgtm and thanks.

I attached the v3 to convey my ideas. You can use it or update the existing
if you think the suggestions are reasonable.


Regards.

--0000000000009c8b08064eca3ed1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>Hi,=
=C2=A0</div><div><br></div><div>=C2=A0</div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">
Thanks for the patch!<br>
<br>
Commit 557a9f1e3e6 recently added test for lock stats, which also causes<br=
>
lock wait situations. So it seems better to extend that test to cover<br>
log_lock_waits rather than adding a new TAP test file.<br>
<br>
I&#39;ve prepared a patch to do this. Patch attached. Thought?<br>
<br>
Regards,<br></blockquote><div><br></div><div>Appreciated for the patch. I r=
eviewed it quickly.</div><div><br></div><div>In the test description it say=
s that `still waiting logged exactly once despite pg_reload_conf() wakeups&=
quot;)` but the test sends via pg_log_backend_memory_contexts(). It would m=
ake sense to update it.=C2=A0</div><div><br></div><div>```</div><div>=C2=A0=
 - =C2=A01, &quot;still waiting logged exactly once despite pg_reload_conf(=
) wakeups&quot;);<br>=C2=A0 + =C2=A01, &quot;still waiting logged exactly o=
nce despite wakeups from pg_log_backend_memory_contexts()&quot;);=C2=A0=C2=
=A0</div><div>```</div><div><br></div><div>Secondly, before finishing the t=
est it tries to check that no log_lock_waits messages are emitted. But the =
comment has the opposite meaning.=C2=A0</div><div><br></div><div>```</div><=
div>=C2=A0 - &#39;check that log_lock_waits message is emitted when the loc=
k is acquired after waiting&#39;<br>=C2=A0 + &#39;check that no log_lock_wa=
its message is emitted when the lock is acquired after waiting&#39;=C2=A0 =
=C2=A0</div><div>```</div><div><br></div><div>I&#39;m not sure they need to=
 change but these are the only topics I wanted to add. Otherwise, lgtm and =
thanks.=C2=A0</div><div><br></div><div>I attached the v3 to convey my ideas=
. You can use it or update the existing if you think the suggestions are re=
asonable.=C2=A0</div><div><br></div><div><br></div><div>Regards.=C2=A0</div=
></div></div>

--0000000000009c8b08064eca3ed1--

--0000000000009c8b09064eca3ed3
Content-Type: application/octet-stream;
	name="v3-0001-Add-TAP-tests-for-log_lock_waits.patch"
Content-Disposition: attachment;
	filename="v3-0001-Add-TAP-tests-for-log_lock_waits.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnn716730>
X-Attachment-Id: f_mnn716730

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDExX2xvY2tfc3RhdHMu
cGwgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfbWlzYy90LzAxMV9sb2NrX3N0YXRzLnBsCmluZGV4
IDU4YTAwNDZhNTJjLi5kOTVmY2Q0YmI0YyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy90
ZXN0X21pc2MvdC8wMTFfbG9ja19zdGF0cy5wbAorKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3Rf
bWlzYy90LzAxMV9sb2NrX3N0YXRzLnBsCkBAIC0xLDEzICsxLDE4IEBACiAKICMgQ29weXJpZ2h0
IChjKSAyMDI2LCBQb3N0Z3JlU1FMIEdsb2JhbCBEZXZlbG9wbWVudCBHcm91cAogCi0jIFRlc3Qg
Zm9yIHRoZSBsb2NrIHN0YXRpc3RpY3MKKyMgVGVzdCBmb3IgdGhlIGxvY2sgc3RhdGlzdGljcyBh
bmQgbG9nX2xvY2tfd2FpdHMKICMKICMgVGhpcyB0ZXN0IGNyZWF0ZXMgbXVsdGlwbGUgbG9ja2lu
ZyBzaXR1YXRpb25zIHdoZW4gYSBzZXNzaW9uIChzMikgaGFzIHRvCiAjIHdhaXQgb24gYSBsb2Nr
IGZvciBsb25nZXIgdGhhbiBkZWFkbG9ja190aW1lb3V0LiBUaGUgZmlyc3QgdGVzdHMgZWFjaCB0
ZXN0IGEKICMgZGVkaWNhdGVkIGxvY2sgdHlwZS4KICMgVGhlIGxhc3Qgb25lIGNoZWNrcyB0aGF0
IGxvZ19sb2NrX3dhaXRzIGhhcyBubyBpbXBhY3Qgb24gdGhlIHN0YXRpc3RpY3MKICMgY291bnRl
cnMuCisjCisjIFRoaXMgdGVzdCBhbHNvIGNoZWNrcyB0aGF0IGxvZ19sb2NrX3dhaXRzIG1lc3Nh
Z2VzIGFyZSBlbWl0dGVkIGJvdGggd2hlbgorIyBhIHdhaXQgb2NjdXJzIGFuZCB3aGVuIHRoZSBs
b2NrIGlzIGFjcXVpcmVkLCBhbmQgdGhhdCB0aGUgInN0aWxsIHdhaXRpbmcgZm9yIgorIyBtZXNz
YWdlIGlzIGxvZ2dlZCBleGFjdGx5IG9uY2UgcGVyIHdhaXQsIGV2ZW4gaWYgdGhlIGJhY2tlbmQg
d2FrZXMgZHVlCisjIHRvIHNpZ25hbHMuCiAKIHVzZSBzdHJpY3Q7CiB1c2Ugd2FybmluZ3MgRkFU
QUwgPT4gJ2FsbCc7CkBAIC05MCw2ICs5NSw4IEBAIElOU0VSVCBJTlRPIHRlc3Rfc3RhdF90YWIo
a2V5LCB2YWx1ZSkgVkFMVUVTKCdrMCcsIDEpOwogCiBzZXR1cF9zZXNzaW9ucygpOwogCitteSAk
bG9nX29mZnNldCA9IC1zICRub2RlLT5sb2dmaWxlOworCiAkczEtPnF1ZXJ5X3NhZmUoCiAJcVsK
IFNFTEVDVCBwZ19zdGF0X3Jlc2V0X3NoYXJlZCgnbG9jaycpOwpAQCAtMTEyLDYgKzExOSwxOCBA
QCBMT0NLIFRBQkxFIHRlc3Rfc3RhdF90YWI7CiAKIHdhaXRfYW5kX2RldGFjaCgkbm9kZSwgJ2Rl
YWRsb2NrLXRpbWVvdXQtZmlyZWQnKTsKIAorIyBDaGVjayB0aGF0IGxvZ19sb2NrX3dhaXRzIG1l
c3NhZ2UgaXMgZW1pdHRlZCBkdXJpbmcgYSBsb2NrIHdhaXQuCiskbm9kZS0+d2FpdF9mb3JfbG9n
KHFyL3N0aWxsIHdhaXRpbmcgZm9yIEFjY2Vzc0V4Y2x1c2l2ZUxvY2sgb24gcmVsYXRpb24vLAor
CSRsb2dfb2Zmc2V0KTsKKworIyBXYWtlIHRoZSBiYWNrZW5kIHdhaXRpbmcgb24gdGhlIGxvY2su
IENvbmZpcm0gaXQgd29rZSBieSBjYWxsaW5nCisjIHBnX2xvZ19iYWNrZW5kX21lbW9yeV9jb250
ZXh0cygpIGFuZCBjaGVja2luZyBmb3IgdGhlIGxvZ2dlZCBtZW1vcnkgY29udGV4dHMuCiskbm9k
ZS0+c2FmZV9wc3FsKAorCSdwb3N0Z3JlcycsIHFbU0VMRUNUIHBnX2xvZ19iYWNrZW5kX21lbW9y
eV9jb250ZXh0cyhwaWQpCisJRlJPTSBwZ19sb2NrcyBXSEVSRSBsb2NrdHlwZSA9ICdyZWxhdGlv
bicgQU5ECisJcmVsYXRpb24gPSAndGVzdF9zdGF0X3RhYic6OnJlZ2NsYXNzIEFORCBOT1QgZ3Jh
bnRlZDtdKTsKKyRub2RlLT53YWl0X2Zvcl9sb2cocXIvbG9nZ2luZyBtZW1vcnkgY29udGV4dHMv
LCAkbG9nX29mZnNldCk7CisKICMgZGVhZGxvY2tfdGltZW91dCBmaXJlZCwgbm93IGNvbW1pdCBp
biBzMSBhbmQgczIKICRzMS0+cXVlcnlfc2FmZShxKENPTU1JVCkpOwogJHMyLT5xdWVyeV9zYWZl
KHEoQ09NTUlUKSk7CkBAIC0xMjAsNiArMTM5LDE4IEBAICRzMi0+cXVlcnlfc2FmZShxKENPTU1J
VCkpOwogd2FpdF9mb3JfcGdfc3RhdF9sb2NrKCRub2RlLCAncmVsYXRpb24nKTsKIG9rKDEsICJM
b2NrIHN0YXRzIG9rIGZvciByZWxhdGlvbiIpOwogCisjIENoZWNrIHRoYXQgbG9nX2xvY2tfd2Fp
dHMgbWVzc2FnZSBpcyBlbWl0dGVkIHdoZW4gdGhlIGxvY2sgaXMgYWNxdWlyZWQKKyMgYWZ0ZXIg
d2FpdGluZy4KKyRub2RlLT53YWl0X2Zvcl9sb2cocXIvYWNxdWlyZWQgQWNjZXNzRXhjbHVzaXZl
TG9jayBvbiByZWxhdGlvbi8sCisJJGxvZ19vZmZzZXQpOworCisjIENoZWNrIHRoYXQgdGhlICJz
dGlsbCB3YWl0aW5nIGZvciIgbWVzc2FnZSBpcyBsb2dnZWQgZXhhY3RseSBvbmNlIHBlciB3YWl0
LAorIyBldmVuIGlmIHRoZSBiYWNrZW5kIHdha2VzIGR1cmluZyB0aGUgd2FpdC4KK215ICRsb2df
Y29udGVudHMgPSBzbHVycF9maWxlKCRub2RlLT5sb2dmaWxlLCAkbG9nX29mZnNldCk7CitteSBA
c3RpbGxfd2FpdGluZyA9ICgkbG9nX2NvbnRlbnRzID1+IC9zdGlsbCB3YWl0aW5nIGZvci9nKTsK
K2lzKHNjYWxhciBAc3RpbGxfd2FpdGluZywKKwkxLCAic3RpbGwgd2FpdGluZyBsb2dnZWQgZXhh
Y3RseSBvbmNlIGRlc3BpdGUgd2FrZXVwcyBmcm9tIHBnX2xvZ19iYWNrZW5kX21lbW9yeV9jb250
ZXh0cygpIik7CisKICMgY2xvc2Ugc2Vzc2lvbnMKICRzMS0+cXVpdDsKICRzMi0+cXVpdDsKQEAg
LTEyOCw2ICsxNTksOCBAQCAkczItPnF1aXQ7CiAKIHNldHVwX3Nlc3Npb25zKCk7CiAKKyRsb2df
b2Zmc2V0ID0gLXMgJG5vZGUtPmxvZ2ZpbGU7CisKICRzMS0+cXVlcnlfc2FmZSgKIAlxWwogU0VM
RUNUIHBnX3N0YXRfcmVzZXRfc2hhcmVkKCdsb2NrJyk7CkBAIC0xNTIsNiArMTg1LDEwIEBAIFVQ
REFURSB0ZXN0X3N0YXRfdGFiIFNFVCB2YWx1ZSA9IHZhbHVlICsgMSBXSEVSRSBrZXkgPSAnazEn
OwogCiB3YWl0X2FuZF9kZXRhY2goJG5vZGUsICdkZWFkbG9jay10aW1lb3V0LWZpcmVkJyk7CiAK
KyMgQ2hlY2sgdGhhdCBsb2dfbG9ja193YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgZHVyaW5nIGEg
bG9jayB3YWl0LgorJG5vZGUtPndhaXRfZm9yX2xvZyhxci9zdGlsbCB3YWl0aW5nIGZvciBTaGFy
ZUxvY2sgb24gdHJhbnNhY3Rpb24vLAorCSRsb2dfb2Zmc2V0KTsKKwogIyBkZWFkbG9ja190aW1l
b3V0IGZpcmVkLCBub3cgY29tbWl0IGluIHMxIGFuZCBzMgogJHMxLT5xdWVyeV9zYWZlKHEoQ09N
TUlUKSk7CiAkczItPnF1ZXJ5X3NhZmUocShDT01NSVQpKTsKQEAgLTE2MCw2ICsxOTcsMTAgQEAg
JHMyLT5xdWVyeV9zYWZlKHEoQ09NTUlUKSk7CiB3YWl0X2Zvcl9wZ19zdGF0X2xvY2soJG5vZGUs
ICd0cmFuc2FjdGlvbmlkJyk7CiBvaygxLCAiTG9jayBzdGF0cyBvayBmb3IgdHJhbnNhY3Rpb25p
ZCIpOwogCisjIENoZWNrIHRoYXQgbG9nX2xvY2tfd2FpdHMgbWVzc2FnZSBpcyBlbWl0dGVkIHdo
ZW4gdGhlIGxvY2sgaXMgYWNxdWlyZWQKKyMgYWZ0ZXIgd2FpdGluZy4KKyRub2RlLT53YWl0X2Zv
cl9sb2cocXIvYWNxdWlyZWQgU2hhcmVMb2NrIG9uIHRyYW5zYWN0aW9uLywgJGxvZ19vZmZzZXQp
OworCiAjIENsb3NlIHNlc3Npb25zCiAkczEtPnF1aXQ7CiAkczItPnF1aXQ7CkBAIC0xNjgsNiAr
MjA5LDggQEAgJHMyLT5xdWl0OwogCiBzZXR1cF9zZXNzaW9ucygpOwogCiskbG9nX29mZnNldCA9
IC1zICRub2RlLT5sb2dmaWxlOworCiAkczEtPnF1ZXJ5X3NhZmUoCiAJcVsKIFNFTEVDVCBwZ19z
dGF0X3Jlc2V0X3NoYXJlZCgnbG9jaycpOwpAQCAtMTkwLDYgKzIzMywxMCBAQCBTRUxFQ1QgcGdf
YWR2aXNvcnlfbG9jaygxKTsKIAogd2FpdF9hbmRfZGV0YWNoKCRub2RlLCAnZGVhZGxvY2stdGlt
ZW91dC1maXJlZCcpOwogCisjIENoZWNrIHRoYXQgbG9nX2xvY2tfd2FpdHMgbWVzc2FnZSBpcyBl
bWl0dGVkIGR1cmluZyBhIGxvY2sgd2FpdC4KKyRub2RlLT53YWl0X2Zvcl9sb2cocXIvc3RpbGwg
d2FpdGluZyBmb3IgRXhjbHVzaXZlTG9jayBvbiBhZHZpc29yeSBsb2NrLywKKwkkbG9nX29mZnNl
dCk7CisKICMgZGVhZGxvY2tfdGltZW91dCBmaXJlZCwgbm93IHVubG9jayBhbmQgY29tbWl0IHMy
CiAkczEtPnF1ZXJ5X3NhZmUocShTRUxFQ1QgcGdfYWR2aXNvcnlfdW5sb2NrKDEpKSk7CiAkczIt
PnF1ZXJ5X3NhZmUoCkBAIC0yMDIsNiArMjQ5LDEwIEBAIENPTU1JVDsKIHdhaXRfZm9yX3BnX3N0
YXRfbG9jaygkbm9kZSwgJ2Fkdmlzb3J5Jyk7CiBvaygxLCAiTG9jayBzdGF0cyBvayBmb3IgYWR2
aXNvcnkiKTsKIAorIyBDaGVjayB0aGF0IGxvZ19sb2NrX3dhaXRzIG1lc3NhZ2UgaXMgZW1pdHRl
ZCB3aGVuIHRoZSBsb2NrIGlzIGFjcXVpcmVkCisjIGFmdGVyIHdhaXRpbmcuCiskbm9kZS0+d2Fp
dF9mb3JfbG9nKHFyL2FjcXVpcmVkIEV4Y2x1c2l2ZUxvY2sgb24gYWR2aXNvcnkgbG9jay8sICRs
b2dfb2Zmc2V0KTsKKwogIyBDbG9zZSBzZXNzaW9ucwogJHMxLT5xdWl0OwogJHMyLT5xdWl0OwpA
QCAtMjEwLDYgKzI2MSw4IEBAICRzMi0+cXVpdDsKIAogc2V0dXBfc2Vzc2lvbnMoKTsKIAorJGxv
Z19vZmZzZXQgPSAtcyAkbm9kZS0+bG9nZmlsZTsKKwogJHMxLT5xdWVyeV9zYWZlKAogCXFbCiBT
RUxFQ1QgcGdfc3RhdF9yZXNldF9zaGFyZWQoJ2xvY2snKTsKQEAgLTI0MSw2ICsyOTQsMTUgQEAg
JHMyLT5xdWVyeV9zYWZlKHEoQ09NTUlUKSk7CiB3YWl0X2Zvcl9wZ19zdGF0X2xvY2soJG5vZGUs
ICdyZWxhdGlvbicpOwogb2soMSwgImxvZ19sb2NrX3dhaXRzIGhhcyBubyBpbXBhY3Qgb24gTG9j
ayBzdGF0cyIpOwogCisjIENoZWNrIHRoYXQgbm8gbG9nX2xvY2tfd2FpdHMgbWVzc2FnZXMgYXJl
IGVtaXR0ZWQKK29rKCAhJG5vZGUtPmxvZ19jb250YWlucygKKwkJInN0aWxsIHdhaXRpbmcgZm9y
IEFjY2Vzc0V4Y2x1c2l2ZUxvY2sgb24gcmVsYXRpb24iLCAkbG9nX29mZnNldCksCisJJ2NoZWNr
IHRoYXQgbm8gbG9nX2xvY2tfd2FpdHMgbWVzc2FnZSBpcyBlbWl0dGVkIGR1cmluZyBhIGxvY2sg
d2FpdCcpOworb2soICEkbm9kZS0+bG9nX2NvbnRhaW5zKAorCQkiYWNxdWlyZWQgQWNjZXNzRXhj
bHVzaXZlTG9jayBvbiByZWxhdGlvbiIsICRsb2dfb2Zmc2V0KSwKKwknY2hlY2sgdGhhdCBubyBs
b2dfbG9ja193YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgd2hlbiB0aGUgbG9jayBpcyBhY3F1aXJl
ZCBhZnRlciB3YWl0aW5nJworKTsKKwogIyBjbG9zZSBzZXNzaW9ucwogJHMxLT5xdWl0OwogJHMy
LT5xdWl0Owo=
--0000000000009c8b09064eca3ed3--