MIME-Version: 1.0
References: <20260204213032.15bab46b@ardentperf.com>
 <CAHGQGwH7c5X4OkPaQ6VDaLGoFgJgwf_-HNwUi2uXoiAhkFkkyA@mail.gmail.com>
 <177304694613.1094603.10800724073727441272.pgcf@coridan.postgresql.org>
 <CAHGQGwG_Ud-N1zrULv8fE51-CUd2ZF3eDe7jUdNOm-rt_JgcQQ@mail.gmail.com>
 <017AD77A-21B6-4B0A-8847-207914D53CE0@gmail.com>
 <CAHGQGwEBvWXU4sdu2DMxaUWdPYQvGesr1VPyX-WnSxtW9nN6UA@mail.gmail.com>
 <CAB5wL7YB1my9W5k5i=SY+=sTjeozyJ0YkvGXrVfeDNzuRkoTPg@mail.gmail.com>
 <CAHGQGwGV3ufcdXnW6JLBhejfptCJRGs7Jrp03YPoO7V_b-2MFA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwGV3ufcdXnW6JLBhejfptCJRGs7Jrp03YPoO7V_b-2MFA@mail.gmail.com>
From: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Date: Tue, 17 Mar 2026 20:59:04 +0100
Message-ID: 
 <CAB5wL7amNFF3zA=h5R3Wx1aQZR-EKzv485LyYMLbB9X7dhx2Ew@mail.gmail.com>
Subject: Re: client_connection_check_interval default value
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000002726df064d3dc58d"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB5wL7amNFF3zA%3Dh5R3Wx1aQZR-EKzv485LyYMLbB9X7dhx2Ew%40mail.gmail.com>
Precedence: bulk

--0000000000002726df064d3dc58d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Fujii Masao <masao.fujii@gmail.com>, 16 Mar 2026 Pzt, 10:22 tarihinde
=C5=9Funu yazd=C4=B1:
>
> On Mon, Mar 16, 2026 at 4:05=E2=80=AFPM H=C3=BCseyin Demir <huseyin.d3r@g=
mail.com> wrote:
> > The new v2 patch looks good to me.
> >
> > One open question from my side is should we include a test for this
> > behaviour ? Because we mentioned adding a different GUC in the future
> > to manage this rate-limiting approach. It can be useful in the future
> > once we consider/re-visit this approach. If the tests and other future
> > ideas can be developed later together we can consider adding tests
> > later.
>
> I agree it's worth adding such tests. From a quick look at the regression=
 tests,
> there don't seem to be any tests for log_lock_waits itself. So before add=
ing
> tests for the behavior introduced by the patch, we might first need to ad=
d
> some basic tests for log_lock_waits.
>
> Regards,
>
> --
> Fujii Masao

I created a regression test for the behaviour we mentioned before
introducing further possible changes.

You can review it. Basically I tried to simulate the desired behaviour
which the current patch introduced.

Regards.

--0000000000002726df064d3dc58d
Content-Type: application/octet-stream;
	name="v1-0001-add-regression-tests-for-still-waiting-on-lock-log-message.patch"
Content-Disposition: attachment;
	filename="v1-0001-add-regression-tests-for-still-waiting-on-lock-log-message.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmv1ado30>
X-Attachment-Id: f_mmv1ado30

RnJvbSA0ZDFjY2VmYmU3YWEyOWZmMzU2OTliZTRhMDYzYTY5MWM0MGU4Yzk0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIdXNleWluIERlbWlyIDxodXNleWluLmQzckBnbWFpbC5jb20+
CkRhdGU6IFR1ZSwgMTcgTWFyIDIwMjYgMjA6Mjg6MDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSBB
ZGQgVEFQIHRlc3QgZm9yIGxvZ19sb2NrX3dhaXRzICJzdGlsbCB3YWl0aW5nIiBvbmNlLXBlci13
YWl0CiBiZWhhdmlvci4KCkFkZHMgc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFfbG9n
X2xvY2tfd2FpdHMucGwsIHdoaWNoIHZlcmlmaWVzIHRoYXQKdGhlICJzdGlsbCB3YWl0aW5nIG9u
IGxvY2siIG1lc3NhZ2UgaXMgZW1pdHRlZCBleGFjdGx5IG9uY2UgcGVyIGxvY2sgd2FpdCBldmVu
CndoZW4gdGhlIGxvY2std2FpdCBzbGVlcCBpcyBpbnRlcnJ1cHRlZCBmcmVxdWVudGx5IGJ5IGEg
dmVyeSBzaG9ydApjbGllbnRfY29ubmVjdGlvbl9jaGVja19pbnRlcnZhbC4KCkFsc28gcmVnaXN0
ZXJzIHRoZSB0ZXN0IGluIHNyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL21lc29uLmJ1aWxkLgot
LS0KIHNyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL21lc29uLmJ1aWxkICAgICAgICB8ICAgMSAr
CiAuLi4vbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFfbG9nX2xvY2tfd2FpdHMucGwgfCAxMTAgKysr
KysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDExMSBpbnNlcnRpb25zKCspCiBjcmVh
dGUgbW9kZSAxMDA3NTUgc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFfbG9nX2xvY2tf
d2FpdHMucGwKCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfbWlzYy9tZXNvbi5i
dWlsZCBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL21lc29uLmJ1aWxkCmluZGV4IDZlOGRi
MTYyMWE3Li4wYzhhOWU3MWJhOSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21p
c2MvbWVzb24uYnVpbGQKKysrIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvbWVzb24uYnVp
bGQKQEAgLTE5LDYgKzE5LDcgQEAgdGVzdHMgKz0gewogICAgICAgJ3QvMDA4X3JlcGxzbG90X3Np
bmdsZV91c2VyLnBsJywKICAgICAgICd0LzAwOV9sb2dfdGVtcF9maWxlcy5wbCcsCiAgICAgICAn
dC8wMTBfaW5kZXhfY29uY3VycmVudGx5X3Vwc2VydC5wbCcsCisgICAgICAndC8wMTFfbG9nX2xv
Y2tfd2FpdHMucGwnLAogICAgIF0sCiAgICAgIyBUaGUgaW5qZWN0aW9uIHBvaW50cyBhcmUgY2x1
c3Rlci13aWRlLCBzbyBkaXNhYmxlIGluc3RhbGxjaGVjawogICAgICdydW5uaW5nY2hlY2snOiBm
YWxzZSwKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDExX2xvZ19s
b2NrX3dhaXRzLnBsIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFfbG9nX2xvY2tf
d2FpdHMucGwKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwMDAuLmJmNWRmOWU0
ZDkyCi0tLSAvZGV2L251bGwKKysrIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFf
bG9nX2xvY2tfd2FpdHMucGwKQEAgLTAsMCArMSwxMTAgQEAKKyMgQ29weXJpZ2h0IChjKSAyMDI2
LCBQb3N0Z3JlU1FMIEdsb2JhbCBEZXZlbG9wbWVudCBHcm91cAorCisjIFZlcmlmeSB0aGF0IGxv
Z19sb2NrX3dhaXRzIGVtaXRzIHRoZSAic3RpbGwgd2FpdGluZyIgbWVzc2FnZSBleGFjdGx5IG9u
Y2UKKyMgcGVyIGxvY2sgd2FpdCwgZXZlbiB3aGVuIHRoZSBsb2NrLXdhaXQgc2xlZXAgaXMgaW50
ZXJydXB0ZWQgYnkgU0lHSFVQCisjIChlLmcuIHZpYSBwZ19yZWxvYWRfY29uZigpKS4KKyMKKyMg
QmFja2dyb3VuZDogYWZ0ZXIgZGVhZGxvY2tfdGltZW91dCBmaXJlcywgZGVhZGxvY2tfc3RhdGUg
aXMgc2V0IHRvCisjIERTX05PX0RFQURMT0NLLCB3aGljaCBpcyAhPSBEU19OT1RfWUVUX0NIRUNL
RUQuICBFdmVyeSBzdWJzZXF1ZW50IHdha2V1cAorIyBmcm9tIFdhaXRMYXRjaCgpIHJlLWVudGVy
cyB0aGUgbG9nZ2luZyBibG9jay4gIFdpdGhvdXQgdGhlIGZpeCwgYSBTSUdIVVAKKyMgd2FrZXVw
IChjb25maWcgcmVsb2FkKSB3b3VsZCByZS1lbWl0ICJzdGlsbCB3YWl0aW5nIiBlYWNoIHRpbWUg
aXQgb2NjdXJyZWQuCisjIFdpdGggdGhlIGZpeCBhIGJvb2xlYW4gZmxhZyBlbnN1cmVzIHRoZSBt
ZXNzYWdlIGlzIGxvZ2dlZCBhdCBtb3N0IG9uY2UgcGVyCisjIFByb2NTbGVlcCgpIGludm9jYXRp
b24uCisKK3VzZSBzdHJpY3Q7Cit1c2Ugd2FybmluZ3MgRkFUQUwgPT4gJ2FsbCc7Cit1c2UgUG9z
dGdyZVNRTDo6VGVzdDo6Q2x1c3RlcjsKK3VzZSBQb3N0Z3JlU1FMOjpUZXN0OjpVdGlsczsKK3Vz
ZSBUZXN0OjpNb3JlOworCitteSAkbm9kZSA9IFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXItPm5l
dygncHJpbWFyeScpOworJG5vZGUtPmluaXQ7Ciskbm9kZS0+YXBwZW5kX2NvbmYoCisJJ3Bvc3Rn
cmVzcWwuY29uZicsIHFxKAorbG9nX2xvY2tfd2FpdHMgPSBvbgorZGVhZGxvY2tfdGltZW91dCA9
ICcyMDBtcycKKykpOworJG5vZGUtPnN0YXJ0OworCiskbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3Jl
cycsICdDUkVBVEUgVEFCTEUgbG9ja190ZXN0IChpZCBpbnQpJyk7CisKKyMgU2Vzc2lvbiBBOiBo
b2xkIEFDQ0VTUyBFWENMVVNJVkUgbG9jaworbXkgJHNlc3NfYSA9ICRub2RlLT5iYWNrZ3JvdW5k
X3BzcWwoJ3Bvc3RncmVzJyk7Ciskc2Vzc19hLT5xdWVyeV9zYWZlKAorCSJCRUdJTjsgTE9DSyBU
QUJMRSBsb2NrX3Rlc3QgSU4gQUNDRVNTIEVYQ0xVU0lWRSBNT0RFOyIpOworCisjIFJlY29yZCBs
b2cgb2Zmc2V0IGJlZm9yZSBTZXNzaW9uIEIgdHJpZXMgdG8gYWNxdWlyZSB0aGUgc2FtZSBsb2Nr
CitteSAkbG9nX29mZnNldCA9IC1zICRub2RlLT5sb2dmaWxlOworCisjIFNlc3Npb24gQjogd2ls
bCBibG9jayBvbiB0aGUgc2FtZSBsb2NrLgorIyBFY2hvIGEgbWFya2VyIGJlZm9yZSB0aGUgYmxv
Y2tpbmcgTE9DSyBzbyBxdWVyeV91bnRpbCBjYW4gcmV0dXJuIHdpdGhvdXQKKyMgd2FpdGluZyBm
b3IgbG9jayBhY3F1aXNpdGlvbi4gIFRoZSBMT0NLIGNvbW1hbmQgcnVucyAoYmxvY2tpbmcpIGlu
IHRoZQorIyBiYWNrZ3JvdW5kLgorbXkgJHNlc3NfYiA9ICRub2RlLT5iYWNrZ3JvdW5kX3BzcWwo
J3Bvc3RncmVzJyk7Ciskc2Vzc19iLT5xdWVyeV91bnRpbCgKKwlxci9ibG9ja2luZ19vbl9sb2Nr
LywKKwkiU0VUIGxvZ19sb2NrX3dhaXRzID0gb247XG4iCisJICAuICJTRVQgZGVhZGxvY2tfdGlt
ZW91dCA9ICcyMDBtcyc7XG4iCisJICAuICJCRUdJTjtcbiIKKwkgIC4gIlxcZWNobyBibG9ja2lu
Z19vbl9sb2NrXG4iCisJICAuICJMT0NLIFRBQkxFIGxvY2tfdGVzdCBJTiBBQ0NFU1MgRVhDTFVT
SVZFIE1PREU7XG4iKTsKKworIyBXYWl0IHVudGlsIFNlc3Npb24gQiBpcyBhY3R1YWxseSB3YWl0
aW5nIGZvciB0aGUgbG9jaworb2soICRub2RlLT5wb2xsX3F1ZXJ5X3VudGlsKAorCQkncG9zdGdy
ZXMnLAorCQkiU0VMRUNUIGNvdW50KCopID0gMSBGUk9NIHBnX3N0YXRfYWN0aXZpdHkgIgorCQkg
IC4gIldIRVJFIHdhaXRfZXZlbnRfdHlwZSA9ICdMb2NrJyBBTkQgc3RhdGUgPSAnYWN0aXZlJzsi
KSwKKwkic2Vzc2lvbiBCIGlzIHdhaXRpbmcgZm9yIHRoZSBsb2NrIik7CisKKyMgV2FpdCBmb3Ig
ZGVhZGxvY2tfdGltZW91dCB0byBmaXJlIHNvIHRoYXQgInN0aWxsIHdhaXRpbmciIGlzIGVtaXR0
ZWQgb25jZQorIyBhbmQgZGVhZGxvY2tfc3RhdGUgdHJhbnNpdGlvbnMgb3V0IG9mIERTX05PVF9Z
RVRfQ0hFQ0tFRC4KKyRub2RlLT53YWl0X2Zvcl9sb2cocXIvc3RpbGwgd2FpdGluZyBmb3IvLCAk
bG9nX29mZnNldCk7CisKKyMgU2VuZCB0d28gU0lHSFVQIHdha2V1cHMgdmlhIHBnX3JlbG9hZF9j
b25mKCkuICBFYWNoIG9uZSB3YWtlcyB1cCBTZXNzaW9uIEIncworIyBXYWl0TGF0Y2goKSBjYWxs
LiAgV2l0aG91dCB0aGUgZml4LCBlYWNoIHdha2V1cCB3b3VsZCByZS1lbnRlciB0aGUgbG9nZ2lu
ZworIyBibG9jayAoZGVhZGxvY2tfc3RhdGUgaXMgbm93IERTX05PX0RFQURMT0NLICE9IERTX05P
VF9ZRVRfQ0hFQ0tFRCkgYW5kCisjIGVtaXQgInN0aWxsIHdhaXRpbmciIGFnYWluLiAgV2l0aCB0
aGUgZml4LCBsb2dnZWRfbG9ja193YWl0cz10cnVlIHN1cHByZXNzZXMKKyMgdGhlIHJlcGVhdGVk
IG1lc3NhZ2UuCisjCisjIEFmdGVyIGVhY2ggcmVsb2FkLCBwb2xsIHVudGlsIEIgaXMgYmFjayBp
biB0aGUgbG9jay13YWl0IHN0YXRlIHNvIHdlIGtub3cKKyMgdGhlIFNJR0hVUCB3YWtldXAgd2Fz
IGZ1bGx5IHByb2Nlc3NlZCBiZWZvcmUgdGhlIG5leHQgb25lIGlzIHNlbnQuCiskbm9kZS0+c2Fm
ZV9wc3FsKCdwb3N0Z3JlcycsICdTRUxFQ1QgcGdfcmVsb2FkX2NvbmYoKScpOworJG5vZGUtPnBv
bGxfcXVlcnlfdW50aWwoCisJJ3Bvc3RncmVzJywKKwkiU0VMRUNUIGNvdW50KCopID0gMSBGUk9N
IHBnX3N0YXRfYWN0aXZpdHkgIgorCSAgLiAiV0hFUkUgd2FpdF9ldmVudF90eXBlID0gJ0xvY2sn
IEFORCBzdGF0ZSA9ICdhY3RpdmUnOyIpOworCiskbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3Jlcycs
ICdTRUxFQ1QgcGdfcmVsb2FkX2NvbmYoKScpOworJG5vZGUtPnBvbGxfcXVlcnlfdW50aWwoCisJ
J3Bvc3RncmVzJywKKwkiU0VMRUNUIGNvdW50KCopID0gMSBGUk9NIHBnX3N0YXRfYWN0aXZpdHkg
IgorCSAgLiAiV0hFUkUgd2FpdF9ldmVudF90eXBlID0gJ0xvY2snIEFORCBzdGF0ZSA9ICdhY3Rp
dmUnOyIpOworCisjIFJlbGVhc2UgdGhlIGxvY2sgc28gU2Vzc2lvbiBCIGNhbiBwcm9jZWVkCisk
c2Vzc19hLT5xdWVyeV9zYWZlKCJDT01NSVQ7Iik7CisKKyMgV2FpdCBmb3IgU2Vzc2lvbiBCIHRv
IGFjcXVpcmUgdGhlIGxvY2sgKHNpZ25hbGxlZCBieSAiYWNxdWlyZWQiIGluIGxvZykKKyRub2Rl
LT53YWl0X2Zvcl9sb2cocXIvYWNxdWlyZWQgQWNjZXNzRXhjbHVzaXZlTG9jay8sICRsb2dfb2Zm
c2V0KTsKKworJHNlc3NfYi0+cXVpdDsKKyRzZXNzX2EtPnF1aXQ7CisKKyMgQ291bnQgInN0aWxs
IHdhaXRpbmciIG1lc3NhZ2VzIGluIHRoZSByZWxldmFudCBsb2cgc2VnbWVudAorbXkgJGxvZ19j
b250ZW50cyA9CisgIFBvc3RncmVTUUw6OlRlc3Q6OlV0aWxzOjpzbHVycF9maWxlKCRub2RlLT5s
b2dmaWxlLCAkbG9nX29mZnNldCk7CitteSBAc3RpbGxfd2FpdGluZyA9ICgkbG9nX2NvbnRlbnRz
ID1+IC9zdGlsbCB3YWl0aW5nIGZvci9nKTsKK215IEBhY3F1aXJlZCAgICAgID0gKCRsb2dfY29u
dGVudHMgPX4gL2FjcXVpcmVkIEFjY2Vzc0V4Y2x1c2l2ZUxvY2svZyk7CisKKyMgV2l0aCB0aGUg
Zml4OiBleGFjdGx5IDEgInN0aWxsIHdhaXRpbmciIChmaXJlZCBhZnRlciBkZWFkbG9ja190aW1l
b3V0KSwKKyMgdGhlbiBzdXBwcmVzc2VkIGZvciBib3RoIHN1YnNlcXVlbnQgcGdfcmVsb2FkX2Nv
bmYoKSB3YWtldXBzLgorIyBXaXRob3V0IHRoZSBmaXg6IDMgbWVzc2FnZXMgKG9uZSBwZXIgd2Fr
ZXVwIHRoYXQgcmUtZW50ZXJlZCB0aGUgbG9nZ2luZworIyBibG9jaykuCitpcyhzY2FsYXIgQHN0
aWxsX3dhaXRpbmcsIDEsCisJInN0aWxsIHdhaXRpbmcgbG9nZ2VkIGV4YWN0bHkgb25jZSBkZXNw
aXRlIHBnX3JlbG9hZF9jb25mKCkgd2FrZXVwcyIpOworCisjIFNhbml0eSBjaGVjazogdGhlICJh
Y3F1aXJlZCIgbWVzc2FnZSBtdXN0IGFwcGVhciBleGFjdGx5IG9uY2UKK2lzKHNjYWxhciBAYWNx
dWlyZWQsIDEsICJhY3F1aXJlZCBsb2dnZWQgb25jZSB3aGVuIGxvY2sgaXMgZ3JhbnRlZCIpOwor
Ciskbm9kZS0+c3RvcCgnZmFzdCcpOworCitkb25lX3Rlc3RpbmcoKTsKLS0gCjIuNTAuMSAoQXBw
bGUgR2l0LTE1NSkKCg==
--0000000000002726df064d3dc58d--