MIME-Version: 1.0
References: <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
 <aakAmNjKyBWRU1vR@paquier.xyz>
 <e6a27751-8c91-4bff-ba07-2e97de99e34f@pgbackrest.org>
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
 <bc089939-a889-4fd4-bad8-42cc071cd58e@pgbackrest.org>
 <CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
 <8733e942-56fc-4542-9351-63f213f7e23c@pgbackrest.org>
 <CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com>
 <aapxCfGZb3TfzX68@paquier.xyz>
 <CAHGQGwFuXjy7wAkzeDg0cpwsLweyjNO1tACgUWtNdCDtwxZ9hQ@mail.gmail.com>
 <2d228e82-02b5-4e55-a082-1ce26fae5f0f@pgbackrest.org>
 <CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>
 <832093c9-27f3-40fe-88d8-ae416927eacb@pgbackrest.org>
In-Reply-To: <832093c9-27f3-40fe-88d8-ae416927eacb@pgbackrest.org>
From: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Date: Tue, 17 Mar 2026 16:18:11 +0100
Message-ID: 
 <CAB5wL7bn-45LMJPuxwGF304VxYzdjrR2RFk-F-E8532b3c_qMQ@mail.gmail.com>
Subject: Re: Improve checks for GUC recovery_target_xid
To: David Steele <david@pgbackrest.org>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000924e83064d39d8ca"
Archived-At: 
 <https://www.postgresql.org/message-id/CAB5wL7bn-45LMJPuxwGF304VxYzdjrR2RFk-F-E8532b3c_qMQ%40mail.gmail.com>
Precedence: bulk

--000000000000924e83064d39d8ca
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the information, I think it's already covered by the previous
commit.

Regards.


David Steele <david@pgbackrest.org>, 17 Mar 2026 Sal, 15:36 tarihinde =C5=
=9Funu
yazd=C4=B1:

> Hi,
>
> On 3/16/26 14:44, H=C3=BCseyin Demir wrote:
> >
> > David Steele <david@pgbackrest.org>, 6 Mar 2026 Cum, 16:01 tarihinde
> =C5=9Funu yazd=C4=B1:
> >>
> >> On 3/6/26 14:05, Fujii Masao wrote:
> >>> On Fri, Mar 6, 2026 at 3:15=E2=80=AFPM Michael Paquier <michael@paqui=
er.xyz>
> wrote:
> >>>>
> >>>> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
> >>>>> Thanks for the patch! It looks good to me. Barring any objections, =
I
> >>>>> will commit it.
> >>>>
> >>>> Thanks.
> >>>
> >>> I've pushed the patch. Thanks!
> >>
> >> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add mo=
re
> >> tests in this area because they are so expensive but now I feel much
> >> better about it. But that's the last for this CF since there is more
> >> important stuff to be done.
> >>
> >> Regards,
> >> -David
> >
> > I tried to create tests with the ALTER SYSTEM approach to validate the
> GUC.
> >
> > You can review it if it's the correct approach or not. We can create a
> > new CF record if required for the patch.
>
> I modified the tests in the patch to use ALTER SYSTEM and that was
> committed at [1].
>
> One of the tests (bogus) you have added here is a duplicate but the
> other one (upper bound) could be added.
>
> You appear to be working against an old version of the master branch so
> I would recommend rebasing and then add your upper bound test following
> the test pattern we have already established.
>
> I personally don't think the upper bound test adds a lot of value here
> since it is handled by strtou64() just like the bogus test so it will
> not extend coverage, but I'm fine with it if others are.
>
> Regards,
> -David
>
> [1]
>
> https://git.postgresql.org/pg/commitdiff/bffd7130e942e2bd45153ab09e5fab70=
e74ece58
> .
>

--000000000000924e83064d39d8ca
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Thanks for the information, I think it&#39;s already =
covered by the previous commit.=C2=A0</div><div><br></div><div>Regards.</di=
v><div><br></div><br><br><div class=3D"gmail_quote gmail_quote_container"><=
div dir=3D"ltr" class=3D"gmail_attr">David Steele &lt;<a href=3D"mailto:dav=
id@pgbackrest.org">david@pgbackrest.org</a>&gt;, 17 Mar 2026 Sal, 15:36 tar=
ihinde =C5=9Funu yazd=C4=B1:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hi,<br>
<br>
On 3/16/26 14:44, H=C3=BCseyin Demir wrote:<br>
&gt; <br>
&gt; David Steele &lt;<a href=3D"mailto:david@pgbackrest.org" target=3D"_bl=
ank">david@pgbackrest.org</a>&gt;, 6 Mar 2026 Cum, 16:01 tarihinde =C5=9Fun=
u yazd=C4=B1:<br>
&gt;&gt;<br>
&gt;&gt; On 3/6/26 14:05, Fujii Masao wrote:<br>
&gt;&gt;&gt; On Fri, Mar 6, 2026 at 3:15=E2=80=AFPM Michael Paquier &lt;<a =
href=3D"mailto:michael@paquier.xyz" target=3D"_blank">michael@paquier.xyz</=
a>&gt; wrote:<br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrot=
e:<br>
&gt;&gt;&gt;&gt;&gt; Thanks for the patch! It looks good to me. Barring any=
 objections, I<br>
&gt;&gt;&gt;&gt;&gt; will commit it.<br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; Thanks.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; I&#39;ve pushed the patch. Thanks!<br>
&gt;&gt;<br>
&gt;&gt; Thank you and great idea on ALTER SYSTEM. I&#39;ve been hesitant t=
o add more<br>
&gt;&gt; tests in this area because they are so expensive but now I feel mu=
ch<br>
&gt;&gt; better about it. But that&#39;s the last for this CF since there i=
s more<br>
&gt;&gt; important stuff to be done.<br>
&gt;&gt;<br>
&gt;&gt; Regards,<br>
&gt;&gt; -David<br>
&gt; <br>
&gt; I tried to create tests with the ALTER SYSTEM approach to validate the=
 GUC.<br>
&gt; <br>
&gt; You can review it if it&#39;s the correct approach or not. We can crea=
te a<br>
&gt; new CF record if required for the patch.<br>
<br>
I modified the tests in the patch to use ALTER SYSTEM and that was <br>
committed at [1].<br>
<br>
One of the tests (bogus) you have added here is a duplicate but the <br>
other one (upper bound) could be added.<br>
<br>
You appear to be working against an old version of the master branch so <br=
>
I would recommend rebasing and then add your upper bound test following <br=
>
the test pattern we have already established.<br>
<br>
I personally don&#39;t think the upper bound test adds a lot of value here =
<br>
since it is handled by strtou64() just like the bogus test so it will <br>
not extend coverage, but I&#39;m fine with it if others are.<br>
<br>
Regards,<br>
-David<br>
<br>
[1] <br>
<a href=3D"https://git.postgresql.org/pg/commitdiff/bffd7130e942e2bd45153ab=
09e5fab70e74ece58" rel=3D"noreferrer" target=3D"_blank">https://git.postgre=
sql.org/pg/commitdiff/bffd7130e942e2bd45153ab09e5fab70e74ece58</a>.<br>
</blockquote></div></div>

--000000000000924e83064d39d8ca--