Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKKqG-0001Z1-Bi for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2023 15:04:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKKqF-0007o5-4S for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2023 15:04:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKKqE-0007nw-Rf for pgsql-hackers@lists.postgresql.org; Tue, 24 Jan 2023 15:04:06 +0000 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pKKqC-0006eB-RN for pgsql-hackers@postgresql.org; Tue, 24 Jan 2023 15:04:06 +0000 Received: by mail-vk1-xa32.google.com with SMTP id l129so7722369vkh.6 for ; Tue, 24 Jan 2023 07:04:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Fgt0rtbI0hA/2MzrjfVyqrIj++uEZ8Vwbeh3EeHFWL8=; b=naV49MZTXj4xm06UycF4+Gy8WciKXsIVnOZxpuXxz1qBiPNgcC4ZTf3hJEAY+G8fPk 2vUy7xl+UHk8VxNHqoUztlhijnsYTMX6NsxhGit9XoUCi1TfOfYYCOAeF73kbjx0cjPS HfAk+r334paSfMVmD3IyTScZlYwbMw7jjcRg+WBfPcEp6Q/zTxfoHdO7uUrj7HkuHSdk f3FT0/zDUWtUYS5oBYNVmfZj36SwCrAIQAdsBDcV4bL+En9/PQixmTSVnq1eJLoP+bq3 iAV1n3Ppe4eJtv1ZvOteH1qSIsWrYGMw88Zb9+fr9/LgskI7Fa6Ns1raUF80wENXTRCo fqqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fgt0rtbI0hA/2MzrjfVyqrIj++uEZ8Vwbeh3EeHFWL8=; b=XVHTZQPKGuB1xivDpPHHIHcJU/sCYvY/mOER+BMkqNKaPvq+6HGSu8dFHk6JhX4OOY ku1D/RlbnmoP4nTJXSdU7vmmrFJJ116KZJJLIAuMHhlhs2TMyTGlugs/k7Klh9Vk2CQN SEGFUaIQaPJPX0espdgx7xE2v0pD/tn22NrtAQ59wFy7mXp2GMCXyhDQpTcSOjGXEwn6 d0DzdbGRDingupJ0yTRoiRMTBurubbRsDRxZG4ZVDBbqHokhX3ggcG7ZplFGeH1hGRRZ 1ZEHp9v4+wwtmj9T/ECxTj98M9UpGwJAqR+aW65UCFPTsC0k/fDAg0mFUzh6D/MzwRWl LHSA== X-Gm-Message-State: AFqh2krikZRBakT8EPHhOXfCddMgU/uixsghf0SP2BldjPV/f6wrXB3I rb9OIrufyO3anmt1wLwyZbUpZGLQiFWIIlOFSDpZzHZxAGxmiQ== X-Google-Smtp-Source: AMrXdXvsvrtPZ36nZ+aNaDRzp+SogZKsh9JQ9MDWPo655rYHTMqOEAREwuG+GUiaE7LyZHuXjOeq8cNSE+Gcfx6hmio= X-Received: by 2002:a1f:7c82:0:b0:3da:fa83:5297 with SMTP id x124-20020a1f7c82000000b003dafa835297mr3654154vkc.6.1674572642930; Tue, 24 Jan 2023 07:04:02 -0800 (PST) MIME-Version: 1.0 References: <1097305.1674334785@sss.pgh.pa.us> <20230121224312.qmwpagrebidr6hi7@awork3.anarazel.de> <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de> <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de> <1495023.1674430107@sss.pgh.pa.us> <20230123001518.6hxyiczhn4kadvmf@awork3.anarazel.de> In-Reply-To: <20230123001518.6hxyiczhn4kadvmf@awork3.anarazel.de> From: Vladimir Sitnikov Date: Tue, 24 Jan 2023 18:03:51 +0300 Message-ID: Subject: Re: run pgindent on a regular basis / scripted manner To: PostgreSQL-development Content-Type: multipart/alternative; boundary="00000000000088542205f303d375" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000088542205f303d375 Content-Type: text/plain; charset="UTF-8" Andres> Of course, but I somehow feel a change of formatting should be reviewable to Andres> at least some degree One way of reviewing the formatting changes is to compare the compiled binaries. If the binaries before and after formatting are the same, then there's a high chance the behaviour is the same. Vladimir --00000000000088542205f303d375 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Andres> Of course, but I somehow feel= a change of formatting should be reviewable to
Andres>=C2=A0at lea= st some degree

One way of revi= ewing the formatting changes is to compare=C2=A0the compiled binaries.

If the binaries before and a= fter formatting are the same, then there's a high chance the behaviour = is the same.

Vladimir

--00000000000088542205f303d375--