MIME-Version: 1.0
References: <7daef094-abf3-4672-bc23-3df4763b16a3@gmail.com>
 <aiP/X1FThlZRCFiN@bdtpg>
 <OS9PR01MB1214908BA67A7811BD6281208F51C2@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <aiaBtENl7tTf2MM8@bdtpg>
 <TYRPR01MB12156677791D04E4E858F3FCCF51D2@TYRPR01MB12156.jpnprd01.prod.outlook.com>
 <aierZPkbtW1OQu8+@bdtpg>
In-Reply-To: <aierZPkbtW1OQu8+@bdtpg>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Tue, 9 Jun 2026 14:13:54 +0800
Message-ID: 
 <CABPTF7UFHTwukHhKQP7u9S7BuyzXvrqq46ZPPoC+T1A4FAoe2Q@mail.gmail.com>
Subject: Re: t/035_standby_logical_decoding.pl might fail on attempt to read
 wrong timeline
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABPTF7UFHTwukHhKQP7u9S7BuyzXvrqq46ZPPoC%2BT1A4FAoe2Q%40mail.gmail.com>
Precedence: bulk

On Tue, Jun 9, 2026 at 1:57=E2=80=AFPM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi Hayato-san,
>
> On Tue, Jun 09, 2026 at 04:04:20AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > Dear Bertrand, Xuneng,
> >
> > Thanks for sharing the reproducer and opinion. I could now understand.
> >
> > While seeing, I felt the same issue can happen even for the streaming c=
ase.
> > Please see attached reproducer and possible fix.

Good catch!

> I just had a quick look and I feel that's probably an issue too (good fin=
d!).
> I think that your fix should use GetWALInsertionTimeLineIfSet() though (b=
ut I
> only did a quick scan on your patch).
>
> > Can you also include that point? Or this thread discusses only for the =
logical case?
> > If separated, I can take initiative for the streaming part, after the l=
ogical decoding
> > case.
>
> I would says it's probably better to keep this thread focusing on Alexand=
er's issue
> (logical decoding). Once this thread is fixed, then I'd suggest to open a=
 dedicated
> thread for the streaming one (mentioning this thread and probably trying =
to mimic
> its fix as close as possible).
>

+1 for starting a dedicated thread. Please CC me in that thread in
case I miss it.

--=20
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.