public inbox for [email protected]  

help / color / mirror / Atom feed

From: Xuneng Zhou <[email protected]>
To: Andreas Karlsson <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Use proc_exit() in WalRcvWaitForStartPosition
Date: Thu, 9 Apr 2026 09:09:08 +0800
Message-ID: <CABPTF7V=y2rHC=gLTeC-42aRc+jcXueomUBjbNiy3pOfhJs3_A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Thu, Apr 9, 2026 at 5:00 AM Andreas Karlsson <[email protected]> wrote:
>
> On 4/8/26 11:08 AM, Chao Li wrote:
> > While working on another patch, I happened to notice that WalRcvWaitForStartPosition() calls raw exit(1). I think this should use proc_exit(1) instead, so that the normal cleanup machinery is not bypassed.
> >
> > This tiny patch just replaces exit(1) with proc_exit(1) in WalRcvWaitForStartPosition().
>
> This looks likely to be correct since when we exit in WalReceiverMain()
> (on WALRCV_STOPPING and WALRCV_STOPPED) we call proc_exit(1). I feel we
> should exit the same way in WalRcvWaitForStartPosition() as we do in
> WalReceiverMain() and if not I would like a comment explaining why those
> two cases are different.

+1

WalRcvWaitForStartPosition, WALRCV_STOPPING before entering wait loop
uses proc_exit(0) for WALRCV_STOPPING, while this path should probably
use proc_exit(0) as well (not proc_exit(1)), since the stop was a
requested shutdown, not an error. Using exit code 1 for a clean
stop-on-request seems inconsistent.

-- 
Best,
Xuneng

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Use proc_exit() in WalRcvWaitForStartPosition
  In-Reply-To: <CABPTF7V=y2rHC=gLTeC-42aRc+jcXueomUBjbNiy3pOfhJs3_A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox