MIME-Version: 1.0
References: 
 <CABPTF7Xs-64GQNjmbimZNhj2YSKbBny+evz6=cp3X2fkJS+vMQ@mail.gmail.com>
 <CABPTF7Ub=w7CRxi3sNv8oMGMh4hCqUTohuiTuP9Y1DpxRuFtRQ@mail.gmail.com>
 <CAPpHfduJKv9-R2HcpyX9RNgteLL0M1MPS1No1WLnTsegsbG4MQ@mail.gmail.com>
 <CABPTF7WWxgAAr5fT9TFciU+PzeRpC3Dp7SO60AV9XWx561TNKA@mail.gmail.com>
 <CABPTF7X0n=R50z2fBpj3EbYYz04Ab0-DHJa+JfoAEny62QmUdg@mail.gmail.com>
 <CABPTF7U+SUnJX_woQYGe==R9Oz+-V6X0VO2stBLPGfJmH_LEhw@mail.gmail.com>
 <CABPTF7UcuVD0L-X=jZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA@mail.gmail.com>
 <CABPTF7Wdq6KbvC3EhLX3Pz=ODCCPEX7qVQ+E=cokkB91an2E-A@mail.gmail.com>
 <CAPpHfdv_BS7csGyg_=pPanRQM9Sf6_wBWNGdVzJRAv0U4eH9cg@mail.gmail.com>
 <CAPpHfds7oSCbZqob7ytT_Lso8fv-NW8LnedUTE4Krde+3rkJeA@mail.gmail.com>
 <CABPTF7WiDtWCR82geyaaaCRV9UiPR5YUHRNDysD_7Ltr1ymfug@mail.gmail.com>
 <CABPTF7Um7oRKBYmek_3gfbaMg5DLzHZmAX-GEacHASfD34xo5g@mail.gmail.com>
 <CABPTF7V-E_e3kQ2vtwUz6Jy7u-8_YeUT0SDoAbu7EKPgNp=ndA@mail.gmail.com>
 <CAPpHfdtNiSqQCu+YtTYcc+K4q9FwtZuAtQ5Qs+KoaZZM4QyYTA@mail.gmail.com>
 <63f6abc9-c0ae-465d-a4e6-667eca6ea008@gmail.com>
 <CABPTF7V=q+OCSHLMV0v78UU=pz6b7rC81vJ5+XKnVkfAebyEwA@mail.gmail.com>
 <CABPTF7X61iuyZT3K3rZssi9qyBsfo+cGs4vWBZ6KexHi1L6hMA@mail.gmail.com>
 <CAPpHfdtQGQpUXoqWpRghhoG_-PbUtxNTgza=am4-HHa=EmXAVQ@mail.gmail.com>
 <CABPTF7XDVHC-FDtZNWep6eCJEiaGOBskmYbVivZGZ2p-V23-QA@mail.gmail.com>
In-Reply-To: 
 <CABPTF7XDVHC-FDtZNWep6eCJEiaGOBskmYbVivZGZ2p-V23-QA@mail.gmail.com>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Sat, 23 May 2026 11:40:30 -0700
Message-ID: 
 <CABPTF7VLWuzHeeRYTb0AWb5639hDcW9P2yYSk7v1ESxCGgiUJA@mail.gmail.com>
Subject: Re: Implement waiting for wal lsn replay: reloaded
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
	Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Chao Li <li.evan.chao@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Michael Paquier <michael@paquier.xyz>, jian he <jian.universality@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: multipart/alternative; boundary="0000000000009aa0e20652807bee"
Archived-At: 
 <https://www.postgresql.org/message-id/CABPTF7VLWuzHeeRYTb0AWb5639hDcW9P2yYSk7v1ESxCGgiUJA%40mail.gmail.com>
Precedence: bulk

--0000000000009aa0e20652807bee
Content-Type: text/plain; charset="UTF-8"

>
>
> > I agree with you.  But do we actually need a
> > wait_for_standby_and_slot_catchup() wrapper.  I think we can call
> > $node->wait_for_slot_catchup() directly and simplify the fix.  Check
> > the attached patch.
> >
>
> The patch looks good to me. I agree that the wait_for_slot_catchup is
> not needed and could be misleading. This change would make the exact
> synchronization point and its intention clearer. The only price we
> need to pay here is bringing back the polling. But it seems acceptable
> since the cost was there in the pre-wait-for-lsn era. And thanks for
> writing the great commit message!
>

Sorry for copy-pasting the wrong function name. It should be
wait_for_catchup().

>

Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

--0000000000009aa0e20652807bee
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div dir=3D"auto"><div dir=3D"auto"><div dir=3D"auto"><di=
v class=3D"gmail_quote" dir=3D"auto"><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; I agree with you.=C2=A0 But do we actually need a<br>
&gt; wait_for_standby_and_slot_catchup() wrapper.=C2=A0 I think we can call=
<br>
&gt; $node-&gt;wait_for_slot_catchup() directly and simplify the fix.=C2=A0=
 Check<br>
&gt; the attached patch.<br>
&gt;<br>
<br>
The patch looks good to me. I agree that the wait_for_slot_catchup is<br>
not needed and could be misleading. This change would make the exact<br>
synchronization point and its intention clearer. The only price we<br>
need to pay here is bringing back the polling. But it seems acceptable<br>
since the cost was there in the pre-wait-for-lsn era. And thanks for<br>
writing the great commit message!<br></blockquote></div><div dir=3D"auto"><=
br></div><div dir=3D"auto">Sorry for copy-pasting the wrong function name. =
It should be wait_for_catchup().</div><div class=3D"gmail_quote" dir=3D"aut=
o"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left=
:1px #ccc solid;padding-left:1ex">
</blockquote></div></div>
<br><br><div data-smartmail=3D"gmail_signature"><div dir=3D"ltr">Regards,<b=
r><font color=3D"#222222">Xuneng Zhou</font><br style=3D"color:rgb(34,34,34=
)"><span style=3D"color:rgb(34,34,34)">HighGo Software Co., Ltd.</span><br>=
</div></div></div>
<br><br></div>
<br><br></div>

--0000000000009aa0e20652807bee--