MIME-Version: 1.0
References: <CABPTF7Xs-64GQNjmbimZNhj2YSKbBny+evz6=cp3X2fkJS+vMQ@mail.gmail.com>
 <202601011659.ikh4ku4p3ovb@alvherre.pgsql> <CAPpHfduDVNo4VXgnQFZUg9=2yHQJfUUqjokbi3qVxuJiKNfcwg@mail.gmail.com>
 <CABPTF7UkwQZGx5ub731Q+=+rU8yx4ruqMdDt__L_dm9_32LsMw@mail.gmail.com> <CAPpHfds-KiZRuCruc0jHxLSxLqzKcHJGwOFFA0b_RgaJvtUOEQ@mail.gmail.com>
In-Reply-To: <CAPpHfds-KiZRuCruc0jHxLSxLqzKcHJGwOFFA0b_RgaJvtUOEQ@mail.gmail.com>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Sun, 4 Jan 2026 00:10:44 +0800
Message-ID: <CABPTF7Vy4A0S0W7=B-fVd9Bo_15XG_FRYfKUF2CB_i=5svwEZQ@mail.gmail.com>
Subject: Re: Implement waiting for wal lsn replay: reloaded
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>, 
	Chao Li <li.evan.chao@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, 
	Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>, 
	jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>, 
	Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CABPTF7Vy4A0S0W7%3DB-fVd9Bo_15XG_FRYfKUF2CB_i%3D5svwEZQ%40mail.gmail.com>
Precedence: bulk

Hi Alexander,

On Sat, Jan 3, 2026 at 6:54=E2=80=AFAM Alexander Korotkov <aekorotkov@gmail=
.com> wrote:
>
> Hi, Xuneng!
>
> On Fri, Jan 2, 2026 at 11:17=E2=80=AFAM Xuneng Zhou <xunengzhou@gmail.com=
> wrote:
> > On Fri, Jan 2, 2026 at 7:42=E2=80=AFAM Alexander Korotkov <aekorotkov@g=
mail.com> wrote:
> > >
> > > On Thu, Jan 1, 2026 at 7:16=E2=80=AFPM =C3=81lvaro Herrera <alvherre@=
kurilemu.de> wrote:
> > > > In 0002 you have this kind of thing:
> > > >
> > > > >                               ereport(ERROR,
> > > > >                                               errcode(ERRCODE_QUE=
RY_CANCELED),
> > > > > -                                             errmsg("timed out w=
hile waiting for target LSN %X/%08X to be replayed; current replay LSN %X/%=
08X",
> > > > > +                                             errmsg("timed out w=
hile waiting for target LSN %X/%08X to be %s; current %s LSN %X/%08X",
> > > > >                                                          LSN_FORM=
AT_ARGS(lsn),
> > > > > -                                                        LSN_FORM=
AT_ARGS(GetXLogReplayRecPtr(NULL))));
> > > > > +                                                        desc->ve=
rb,
> > > > > +                                                        desc->no=
un,
> > > > > +                                                        LSN_FORM=
AT_ARGS(currentLSN)));
> > > > > +                     }
> > > >
> > > >
> > > > I'm afraid this technique doesn't work, for translatability reasons=
.
> > > > Your whole design of having a struct with ->verb and ->noun is not
> > > > workable (which is a pity, but you can't really fight this.) You ne=
ed to
> > > > spell out the whole messages for each case, something like
> > > >
> > > > if (lsntype =3D=3D replay)
> > > >    ereport(ERROR,
> > > >            errcode(ERRCODE_QUERY_CANCELED),
> > > >            errmsg("timed out while waiting for target LSN %X/%08X t=
o be replayed; current standby_replay LSN %X/%08X",
> > > > else if (lsntype =3D=3D flush)
> > > >     ereport( ... )
> > > >
> > > > and so on.  This means four separate messages for translation for e=
ach
> > > > message your patch is adding, which is IMO the correct approach.
> > >
> > > +1
> > > Thank you for catching this, Alvaro.  Yes, I think we need to get rid
> > > of WaitLSNTypeDesc.  It's nice idea, but we support too many language=
s
> > > to have something like this.
> > >
> >
> > Thanks for pointing this out. This approach doesn=E2=80=99t scale to mu=
ltiple
> > languages. While switch statements are more verbose, the extra clarity
> > is justified to preserve proper internationalization. Please check the
> > updated v12.
>
> I've corrected the patchset.  Mostly changed just comments, formatting
> etc.  I'm going to push it if no objections.
>

Thanks for updating the patchset. LGTM.

--=20
Best,
Xuneng