MIME-Version: 1.0
References: <CABPTF7Xs-64GQNjmbimZNhj2YSKbBny+evz6=cp3X2fkJS+vMQ@mail.gmail.com>
 <202601011659.ikh4ku4p3ovb@alvherre.pgsql> <CAPpHfduDVNo4VXgnQFZUg9=2yHQJfUUqjokbi3qVxuJiKNfcwg@mail.gmail.com>
 <CABPTF7UkwQZGx5ub731Q+=+rU8yx4ruqMdDt__L_dm9_32LsMw@mail.gmail.com>
 <CAPpHfds-KiZRuCruc0jHxLSxLqzKcHJGwOFFA0b_RgaJvtUOEQ@mail.gmail.com>
 <CABPTF7Vy4A0S0W7=B-fVd9Bo_15XG_FRYfKUF2CB_i=5svwEZQ@mail.gmail.com>
 <CA+hUKG+L0OQR8dQtsNBSaA3FNNyQeFabdeRVzurm0b7Xtp592g@mail.gmail.com>
 <iuzfab2lr54iarbt5ijxtkdbrkv5qnioykluu7pg53hn7gv2te@hz2bkg4aw7bi>
 <CABPTF7WN_3kDPBYPxaKKcp2kO5BLB5bK_YGz70VTzTCivHibZA@mail.gmail.com>
 <CAPpHfdtu0zPDnpw1meVAeWaBXen245QmVP=NpOv2gcy4O9ObBA@mail.gmail.com>
 <CABPTF7Ub=w7CRxi3sNv8oMGMh4hCqUTohuiTuP9Y1DpxRuFtRQ@mail.gmail.com>
 <CAPpHfduJKv9-R2HcpyX9RNgteLL0M1MPS1No1WLnTsegsbG4MQ@mail.gmail.com>
 <CABPTF7WWxgAAr5fT9TFciU+PzeRpC3Dp7SO60AV9XWx561TNKA@mail.gmail.com>
 <CABPTF7X0n=R50z2fBpj3EbYYz04Ab0-DHJa+JfoAEny62QmUdg@mail.gmail.com>
 <CABPTF7U+SUnJX_woQYGe==R9Oz+-V6X0VO2stBLPGfJmH_LEhw@mail.gmail.com> <CABPTF7UcuVD0L-X=jZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA@mail.gmail.com>
In-Reply-To: <CABPTF7UcuVD0L-X=jZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA@mail.gmail.com>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Tue, 27 Jan 2026 09:14:43 +0800
Message-ID: <CABPTF7Wdq6KbvC3EhLX3Pz=ODCCPEX7qVQ+E=cokkB91an2E-A@mail.gmail.com>
Subject: Re: Implement waiting for wal lsn replay: reloaded
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Peter Eisentraut <peter@eisentraut.org>, 
	Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>, 
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>, 
	Chao Li <li.evan.chao@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, 
	Michael Paquier <michael@paquier.xyz>, jian he <jian.universality@gmail.com>, 
	Tomas Vondra <tomas@vondra.me>, Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: multipart/mixed; boundary="00000000000015a1690649545a73"
Archived-At: <https://www.postgresql.org/message-id/CABPTF7Wdq6KbvC3EhLX3Pz%3DODCCPEX7qVQ%2BE%3DcokkB91an2E-A%40mail.gmail.com>
Precedence: bulk

--00000000000015a1690649545a73
Content-Type: text/plain; charset="UTF-8"

Hi Alexander,

Heikki spotted a misplaced wake-up call for replay waiters in
PerformWalRecovery. He suggested that the WaitLSNWakeup needs to be
invoked immediately after wal record is applied to avoid the potential
missed wake-ups when recovery stops/pauses/promotes. It makes sense to
me. Please check the attached patch to fix that.

-- 
Best,
Xuneng

--00000000000015a1690649545a73
Content-Type: application/octet-stream; 
	name="v1-0001-Wake-LSN-waiters-before-recovery-target-stop.patch"
Content-Disposition: attachment; 
	filename="v1-0001-Wake-LSN-waiters-before-recovery-target-stop.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mkvwjfh40>
X-Attachment-Id: f_mkvwjfh40

RnJvbSAzZTY5MmM2MzY4MzhhOTI4OTE4MjY2MTc0YzNlMTM5Mjc0Mzg0NzAyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBhbHRlcmVnbzY1NSA8ODI0NjYyNTI2QHFxLmNvbT4KRGF0ZTog
VHVlLCAyNyBKYW4gMjAyNiAwOTowMDozOSArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIFdha2Ug
TFNOIHdhaXRlcnMgYmVmb3JlIHJlY292ZXJ5IHRhcmdldCBzdG9wCgogIE1vdmUgV2FpdExTTldh
a2V1cCgpIGltbWVkaWF0ZWx5IGFmdGVyIEFwcGx5V2FsUmVjb3JkKCkgc28gd2FpdGVycyBhcmUK
ICBzaWduYWxlZCBldmVuIHdoZW4gcmVjb3ZlcnlTdG9wc0FmdGVyKCkgYnJlYWtzIG91dCBmb3Ig
cGF1c2UvcHJvbW90aW9uCiAgdGFyZ2V0cy4KLS0tCiBzcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNh
bS94bG9ncmVjb3ZlcnkuYyB8IDE0ICsrKysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBp
bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2Fj
Y2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVyeS5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0v
eGxvZ3JlY292ZXJ5LmMKaW5kZXggYjkzOTNlNTUxYjcuLjM2ZGFhM2Q4NTg3IDEwMDY0NAotLS0g
YS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYworKysgYi9zcmMvYmFj
a2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYwpAQCAtMTc3NywxMyArMTc3Nyw2IEBA
IFBlcmZvcm1XYWxSZWNvdmVyeSh2b2lkKQogCQkJICovCiAJCQlBcHBseVdhbFJlY29yZCh4bG9n
cmVhZGVyLCByZWNvcmQsICZyZXBsYXlUTEkpOwogCi0JCQkvKiBFeGl0IGxvb3AgaWYgd2UgcmVh
Y2hlZCBpbmNsdXNpdmUgcmVjb3ZlcnkgdGFyZ2V0ICovCi0JCQlpZiAocmVjb3ZlcnlTdG9wc0Fm
dGVyKHhsb2dyZWFkZXIpKQotCQkJewotCQkJCXJlYWNoZWRSZWNvdmVyeVRhcmdldCA9IHRydWU7
Ci0JCQkJYnJlYWs7Ci0JCQl9Ci0KIAkJCS8qCiAJCQkgKiBJZiB3ZSByZXBsYXllZCBhbiBMU04g
dGhhdCBzb21lb25lIHdhcyB3YWl0aW5nIGZvciB0aGVuIHdhbGsKIAkJCSAqIG92ZXIgdGhlIHNo
YXJlZCBtZW1vcnkgYXJyYXkgYW5kIHNldCBsYXRjaGVzIHRvIG5vdGlmeSB0aGUKQEAgLTE3OTQs
NiArMTc4NywxMyBAQCBQZXJmb3JtV2FsUmVjb3Zlcnkodm9pZCkKIAkJCQkgcGdfYXRvbWljX3Jl
YWRfdTY0KCZ3YWl0TFNOU3RhdGUtPm1pbldhaXRlZExTTltXQUlUX0xTTl9UWVBFX1NUQU5EQllf
UkVQTEFZXSkpKQogCQkJCVdhaXRMU05XYWtldXAoV0FJVF9MU05fVFlQRV9TVEFOREJZX1JFUExB
WSwgWExvZ1JlY292ZXJ5Q3RsLT5sYXN0UmVwbGF5ZWRFbmRSZWNQdHIpOwogCisJCQkvKiBFeGl0
IGxvb3AgaWYgd2UgcmVhY2hlZCBpbmNsdXNpdmUgcmVjb3ZlcnkgdGFyZ2V0ICovCisJCQlpZiAo
cmVjb3ZlcnlTdG9wc0FmdGVyKHhsb2dyZWFkZXIpKQorCQkJeworCQkJCXJlYWNoZWRSZWNvdmVy
eVRhcmdldCA9IHRydWU7CisJCQkJYnJlYWs7CisJCQl9CisKIAkJCS8qIEVsc2UsIHRyeSB0byBm
ZXRjaCB0aGUgbmV4dCBXQUwgcmVjb3JkICovCiAJCQlyZWNvcmQgPSBSZWFkUmVjb3JkKHhsb2dw
cmVmZXRjaGVyLCBMT0csIGZhbHNlLCByZXBsYXlUTEkpOwogCQl9IHdoaWxlIChyZWNvcmQgIT0g
TlVMTCk7Ci0tIAoyLjUxLjAKCg==
--00000000000015a1690649545a73--