MIME-Version: 1.0
References: 
 <CABPTF7Xs-64GQNjmbimZNhj2YSKbBny+evz6=cp3X2fkJS+vMQ@mail.gmail.com>
 <CABPTF7Ub=w7CRxi3sNv8oMGMh4hCqUTohuiTuP9Y1DpxRuFtRQ@mail.gmail.com>
 <CAPpHfduJKv9-R2HcpyX9RNgteLL0M1MPS1No1WLnTsegsbG4MQ@mail.gmail.com>
 <CABPTF7WWxgAAr5fT9TFciU+PzeRpC3Dp7SO60AV9XWx561TNKA@mail.gmail.com>
 <CABPTF7X0n=R50z2fBpj3EbYYz04Ab0-DHJa+JfoAEny62QmUdg@mail.gmail.com>
 <CABPTF7U+SUnJX_woQYGe==R9Oz+-V6X0VO2stBLPGfJmH_LEhw@mail.gmail.com>
 <CABPTF7UcuVD0L-X=jZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA@mail.gmail.com>
 <CABPTF7Wdq6KbvC3EhLX3Pz=ODCCPEX7qVQ+E=cokkB91an2E-A@mail.gmail.com>
 <CAPpHfdv_BS7csGyg_=pPanRQM9Sf6_wBWNGdVzJRAv0U4eH9cg@mail.gmail.com>
 <CAPpHfds7oSCbZqob7ytT_Lso8fv-NW8LnedUTE4Krde+3rkJeA@mail.gmail.com>
 <CABPTF7WiDtWCR82geyaaaCRV9UiPR5YUHRNDysD_7Ltr1ymfug@mail.gmail.com>
 <CABPTF7Um7oRKBYmek_3gfbaMg5DLzHZmAX-GEacHASfD34xo5g@mail.gmail.com>
 <CABPTF7V-E_e3kQ2vtwUz6Jy7u-8_YeUT0SDoAbu7EKPgNp=ndA@mail.gmail.com>
 <CAPpHfdtNiSqQCu+YtTYcc+K4q9FwtZuAtQ5Qs+KoaZZM4QyYTA@mail.gmail.com>
 <63f6abc9-c0ae-465d-a4e6-667eca6ea008@gmail.com>
 <CABPTF7V=q+OCSHLMV0v78UU=pz6b7rC81vJ5+XKnVkfAebyEwA@mail.gmail.com>
 <CABPTF7X61iuyZT3K3rZssi9qyBsfo+cGs4vWBZ6KexHi1L6hMA@mail.gmail.com>
 <CAPpHfdtQGQpUXoqWpRghhoG_-PbUtxNTgza=am4-HHa=EmXAVQ@mail.gmail.com>
 <CABPTF7XDVHC-FDtZNWep6eCJEiaGOBskmYbVivZGZ2p-V23-QA@mail.gmail.com>
 <CABPTF7VLWuzHeeRYTb0AWb5639hDcW9P2yYSk7v1ESxCGgiUJA@mail.gmail.com>
 <CAPpHfdvu4g2GFOCs9efDv4DV1Of17A2UWQL2S7CQe6rR3m-7_A@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvu4g2GFOCs9efDv4DV1Of17A2UWQL2S7CQe6rR3m-7_A@mail.gmail.com>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Tue, 26 May 2026 09:48:26 +0800
Message-ID: 
 <CABPTF7XxDonXAcz6DsN6AUJB3swYrZkJHq3UCDaD3Q2H+j0gUA@mail.gmail.com>
Subject: Re: Implement waiting for wal lsn replay: reloaded
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
	Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Chao Li <li.evan.chao@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Michael Paquier <michael@paquier.xyz>, jian he <jian.universality@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: multipart/mixed; boundary="000000000000bd35370652aeb124"
Archived-At: 
 <https://www.postgresql.org/message-id/CABPTF7XxDonXAcz6DsN6AUJB3swYrZkJHq3UCDaD3Q2H%2Bj0gUA%40mail.gmail.com>
Precedence: bulk

--000000000000bd35370652aeb124
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 25, 2026 at 5:00=E2=80=AFPM Alexander Korotkov <aekorotkov@gmai=
l.com> wrote:
>
> On Sat, May 23, 2026 at 9:40=E2=80=AFPM Xuneng Zhou <xunengzhou@gmail.com=
> wrote:
> >> > I agree with you.  But do we actually need a
> >> > wait_for_standby_and_slot_catchup() wrapper.  I think we can call
> >> > $node->wait_for_slot_catchup() directly and simplify the fix.  Check
> >> > the attached patch.
> >> >
> >>
> >> The patch looks good to me. I agree that the wait_for_slot_catchup is
> >> not needed and could be misleading. This change would make the exact
> >> synchronization point and its intention clearer. The only price we
> >> need to pay here is bringing back the polling. But it seems acceptable
> >> since the cost was there in the pre-wait-for-lsn era. And thanks for
> >> writing the great commit message!
> >
> >
> > Sorry for copy-pasting the wrong function name. It should be wait_for_c=
atchup().
>
> Good, thank you.  I'll push it if no objections.

While reading 019_replslot_limit.pl, Codex pointed out a few
inconsistencies in the comments. I verified them and they look real.
Would you mind doing a small cleanup as well?

--=20
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

--000000000000bd35370652aeb124
Content-Type: application/octet-stream;
	name="v2-0002-Clean-up-replslot-limit-test-comments.patch"
Content-Disposition: attachment;
	filename="v2-0002-Clean-up-replslot-limit-test-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mplz734j0>
X-Attachment-Id: f_mplz734j0

RnJvbSA0ZjMxMWU3OGUzMTY0MjNkZTkxMTRhZmYxNGQ4NTliYTdjNmFhNzZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBhbHRlcmVnbzY1NSA8ODI0NjYyNTI2QHFxLmNvbT4KRGF0ZTog
VHVlLCAyNiBNYXkgMjAyNiAwOTo0MDowNCArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjIgMi8yXSBD
bGVhbiB1cCByZXBsc2xvdCBsaW1pdCB0ZXN0IGNvbW1lbnRzCgpVcGRhdGUgc3RhbGUgY29tbWVu
dHMgYW5kIHRlc3QgbmFtZXMgaW4gMDE5X3JlcGxzbG90X2xpbWl0LnBsIHRvIG1hdGNoCnRoZSBh
Y3R1YWwgV0FMIGFkdmFuY2VtZW50IGFuZCB3YWxfc3RhdHVzIGNoZWNrcy4gQWxzbyByZW1vdmUg
YSByZWR1bmRhbnQKc3RhbmRieSBzdG9wIGluIHRoZSBpbmFjdGl2ZV9zaW5jZSBjb3ZlcmFnZS4K
LS0tCiBzcmMvdGVzdC9yZWNvdmVyeS90LzAxOV9yZXBsc2xvdF9saW1pdC5wbCB8IDEwICsrKyst
LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMTlfcmVwbHNsb3RfbGltaXQucGwgYi9z
cmMvdGVzdC9yZWNvdmVyeS90LzAxOV9yZXBsc2xvdF9saW1pdC5wbAppbmRleCA0NzJhYTA3NTg3
Zi4uMDk4NGY5OTllMTMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDE5X3JlcGxz
bG90X2xpbWl0LnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDE5X3JlcGxzbG90X2xpbWl0
LnBsCkBAIC02MCw3ICs2MCw3IEBAICRyZXN1bHQgPSAkbm9kZV9wcmltYXJ5LT5zYWZlX3BzcWwo
J3Bvc3RncmVzJywKICk7CiBpcygkcmVzdWx0LCAicmVzZXJ2ZWR8dCIsICdjaGVjayB0aGUgY2F0
Y2hpbmctdXAgc3RhdGUnKTsKIAotIyBBZHZhbmNlIFdBTCBieSBmaXZlIHNlZ21lbnRzICg9IDVN
Qikgb24gcHJpbWFyeQorIyBBZHZhbmNlIFdBTCBieSBvbmUgc2VnbWVudCAoPSAxTUIpIG9uIHBy
aW1hcnkKICRub2RlX3ByaW1hcnktPmFkdmFuY2Vfd2FsKDEpOwogJG5vZGVfcHJpbWFyeS0+c2Fm
ZV9wc3FsKCdwb3N0Z3JlcycsICJDSEVDS1BPSU5UOyIpOwogCkBAIC0xMTAsNyArMTEwLDcgQEAg
JG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJDSEVDS1BPSU5UOyIpOwogJHJl
c3VsdCA9ICRub2RlX3ByaW1hcnktPnNhZmVfcHNxbCgncG9zdGdyZXMnLAogCSJTRUxFQ1Qgd2Fs
X3N0YXR1cyBGUk9NIHBnX3JlcGxpY2F0aW9uX3Nsb3RzIFdIRVJFIHNsb3RfbmFtZSA9ICdyZXAx
JyIpOwogaXMoJHJlc3VsdCwgInJlc2VydmVkIiwKLQknY2hlY2sgdGhhdCBzYWZlX3dhbF9zaXpl
IGdldHMgY2xvc2UgdG8gdGhlIGN1cnJlbnQgTFNOJyk7CisJJ2NoZWNrIHRoYXQgc2xvdCByZW1h
aW5zIHJlc2VydmVkIGFmdGVyIGFkdmFuY2luZyBXQUwnKTsKIAogIyBUaGUgc3RhbmRieSBjYW4g
cmVjb25uZWN0IHRvIHByaW1hcnkKICRub2RlX3N0YW5kYnktPnN0YXJ0OwpAQCAtMTIxLDcgKzEy
MSw3IEBAICRub2RlX3N0YW5kYnktPnN0b3A7CiAjIHdhbF9rZWVwX3NpemUgb3ZlcnJpZGVzIG1h
eF9zbG90X3dhbF9rZWVwX3NpemUKICRyZXN1bHQgPSAkbm9kZV9wcmltYXJ5LT5zYWZlX3BzcWwo
J3Bvc3RncmVzJywKIAkiQUxURVIgU1lTVEVNIFNFVCB3YWxfa2VlcF9zaXplIHRvICc4TUInOyBT
RUxFQ1QgcGdfcmVsb2FkX2NvbmYoKTsiKTsKLSMgQWR2YW5jZSBXQUwgYWdhaW4gdGhlbiBjaGVj
a3BvaW50LCByZWR1Y2luZyByZW1haW4gYnkgNiBNQi4KKyMgQWR2YW5jZSBXQUwgYWdhaW4sIHJl
ZHVjaW5nIHJlbWFpbiBieSA2IE1CLgogJG5vZGVfcHJpbWFyeS0+YWR2YW5jZV93YWwoNik7CiAk
cmVzdWx0ID0gJG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCiAJIlNFTEVDVCB3
YWxfc3RhdHVzIGFzIHJlbWFpbiBGUk9NIHBnX3JlcGxpY2F0aW9uX3Nsb3RzIFdIRVJFIHNsb3Rf
bmFtZSA9ICdyZXAxJyIKQEAgLTE0MSw3ICsxNDEsNyBAQCAkbm9kZV9zdGFuZGJ5LT5zdG9wOwog
IyBBZHZhbmNlIFdBTCBhZ2FpbiB3aXRob3V0IGNoZWNrcG9pbnQsIHJlZHVjaW5nIHJlbWFpbiBi
eSA2IE1CLgogJG5vZGVfcHJpbWFyeS0+YWR2YW5jZV93YWwoNik7CiAKLSMgU2xvdCBnZXRzIGlu
dG8gJ3Jlc2VydmVkJyBzdGF0ZQorIyBTbG90IGdldHMgaW50byAnZXh0ZW5kZWQnIHN0YXRlCiAk
cmVzdWx0ID0gJG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCiAJIlNFTEVDVCB3
YWxfc3RhdHVzIEZST00gcGdfcmVwbGljYXRpb25fc2xvdHMgV0hFUkUgc2xvdF9uYW1lID0gJ3Jl
cDEnIik7CiBpcygkcmVzdWx0LCAiZXh0ZW5kZWQiLCAnY2hlY2sgdGhhdCB0aGUgc2xvdCBzdGF0
ZSBjaGFuZ2VzIHRvICJleHRlbmRlZCInKTsKQEAgLTQ4MCw4ICs0ODAsNiBAQCBpcyggJHByaW1h
cnk0LT5zYWZlX3BzcWwoCiAJJ3QnLAogCSdsYXN0IGluYWN0aXZlIHRpbWUgZm9yIGFuIGluYWN0
aXZlIHBoeXNpY2FsIHNsb3QgaXMgdXBkYXRlZCBjb3JyZWN0bHknKTsKIAotJHN0YW5kYnk0LT5z
dG9wOwotCiAjIFRlc3RjYXNlIGVuZDogQ2hlY2sgaW5hY3RpdmVfc2luY2UgcHJvcGVydHkgb2Yg
dGhlIHN0cmVhbWluZyBzdGFuZGJ5J3Mgc2xvdAogIyA9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQogCi0t
IAoyLjUxLjAKCg==
--000000000000bd35370652aeb124--