public inbox for [email protected]  
help / color / mirror / Atom feed
From: Xuneng Zhou <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Subject: Re: Streamify more code paths
Date: Fri, 13 Mar 2026 10:39:52 +0800
Message-ID: <CABPTF7XxdAA681duGKgWx-eLC1skR3giuebcw4+-0GkOVZm-pw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CABPTF7VtSYmC5LZSnkJWYn9PCkxgOJd9QbtAM79qftBK-fbA4w@mail.gmail.com>
	<CABPTF7UVCkub6jFXVk-qrYd4xjgiwRt1FTFL2=rBVV9SYcgfkQ@mail.gmail.com>
	<[email protected]>
	<dmf5ladi2amq656myv7zjl4pj4u3v2cp3azteliauifxizljej@bmwabkp5hdpi>
	<CABPTF7XFEOHpbju_pjCFHDffP_rWJU-405c6aoQdx4JjCOBimA@mail.gmail.com>
	<CABPTF7X3RBkmOnQAoLbK-tr6o-+27fNpKPgzYZHhQCuYbP=rGA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CABPTF7Wz8OCcr2f1CSdt-jRHfJAAdXZwwBokBD4baZAPyK7CgA@mail.gmail.com>
	<CABPTF7UA3sEw1ZpAj8qAKY6Xs71sk41X-pV43_iZHZz2U_AP=Q@mail.gmail.com>
	<[email protected]>

On Fri, Mar 13, 2026 at 9:50 AM Michael Paquier <[email protected]> wrote:
>
> On Thu, Mar 12, 2026 at 11:35:48PM +0800, Xuneng Zhou wrote:
> > Our io_time metric currently measures only read time and ignores write
> > I/O, which can be misleading. We now separate it into read_time and
> > write_time.
>
> I had a look at the pgstatindex part this morning, running my own test
> under conditions similar to 6c228755add8, and here's one extract with
> io_uring:
> pgstatindex (100k tuples) base=32938.2ms patch=83.3ms 395.60x ( 99.7%)
> (reads=2745->173, io_time=32932.09->59.75ms)

This result looks great!

> There was one issue with a declaration put in the middle of the code,
> that I have fixed.  This one is now done, remains 3 pieces to
> evaluate.

Thanks for fixing this and for taking the time to review and test the patches.

--
Best,
Xuneng





view thread (36+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Streamify more code paths
  In-Reply-To: <CABPTF7XxdAA681duGKgWx-eLC1skR3giuebcw4+-0GkOVZm-pw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox