MIME-Version: 1.0
References: <cb103623-8ee6-4ba5-a2c9-f32e3a4933fa@dunslane.net> <ZmcKMF61K4Ck51dK@nathan>
In-Reply-To: <ZmcKMF61K4Ck51dK@nathan>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 10 Jun 2024 16:52:06 +0200
Message-ID: <CABUevExoQ26jo+aQ9QZq+UMA1aD6gfpm9xBnh_t5e0DhaCeRYA@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e81cec061a8a4b5a"
Archived-At: <https://www.postgresql.org/message-id/CABUevExoQ26jo%2BaQ9QZq%2BUMA1aD6gfpm9xBnh_t5e0DhaCeRYA%40mail.gmail.com>
Precedence: bulk

--000000000000e81cec061a8a4b5a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 4:14=E2=80=AFPM Nathan Bossart <nathandbossart@gmai=
l.com>
wrote:

> On Mon, Jun 10, 2024 at 08:58:49AM -0400, Andrew Dunstan wrote:
> > Tom and Nathan opined recently that providing for non-text mode for
> > pg_dumpall would be a Good Thing (TM). Not having it has been a
> > long-standing complaint, so I've decided to give it a go.
>
> Thank you!
>

Indeed, this has been quite annoying!


> I think we would need to restrict it to directory mode, at least to begin
> > with. I would have a toc.dat with a different magic block (say "PGGLO"
> > instead of "PGDMP") containing the global entries (roles, tablespaces,
> > databases). Then for each database there would be a subdirectory (named
> for
> > its toc entry) with a standard directory mode dump for that database.
> These
> > could be generated in parallel (possibly by pg_dumpall calling pg_dump
> for
> > each database). pg_restore on detecting a global type toc.data would
> restore
> > the globals and then each of the databases (again possibly in parallel)=
.
>
> I'm curious why we couldn't also support the "custom" format.
>

Or maybe even a combo - a directory of custom format files? Plus that one
special file being globals? I'd say that's what most use cases I've seen
would prefer.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000e81cec061a8a4b5a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jun 10, 2024 at 4:14=E2=80=AF=
PM Nathan Bossart &lt;<a href=3D"mailto:nathandbossart@gmail.com">nathandbo=
ssart@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">On Mon, Jun 10, 2024 at 08:58:49AM -0400, Andrew Dunstan wro=
te:<br>
&gt; Tom and Nathan opined recently that providing for non-text mode for<br=
>
&gt; pg_dumpall would be a Good Thing (TM). Not having it has been a<br>
&gt; long-standing complaint, so I&#39;ve decided to give it a go.<br>
<br>
Thank you!<br></blockquote><div><br></div><div>Indeed, this has been quite =
annoying!</div><div><br></div><div><br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">
&gt; I think we would need to restrict it to directory mode, at least to be=
gin<br>
&gt; with. I would have a toc.dat with a different magic block (say &quot;P=
GGLO&quot;<br>
&gt; instead of &quot;PGDMP&quot;) containing the global entries (roles, ta=
blespaces,<br>
&gt; databases). Then for each database there would be a subdirectory (name=
d for<br>
&gt; its toc entry) with a standard directory mode dump for that database. =
These<br>
&gt; could be generated in parallel (possibly by pg_dumpall calling pg_dump=
 for<br>
&gt; each database). pg_restore on detecting a global type toc.data would r=
estore<br>
&gt; the globals and then each of the databases (again possibly in parallel=
).<br>
<br>
I&#39;m curious why we couldn&#39;t also support the &quot;custom&quot; for=
mat.<br></blockquote><div><br></div><div>Or maybe even a combo - a director=
y of custom format files? Plus that one special file being globals? I&#39;d=
 say that&#39;s what most use cases I&#39;ve seen would prefer.</div><div><=
br></div></div><span class=3D"gmail_signature_prefix">-- </span><br><div di=
r=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0Magnus Haga=
nder<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=3D"_blank">ht=
tps://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://www.redpill-li=
npro.com/" target=3D"_blank">https://www.redpill-linpro.com/</a></div></div=
></div></div>

--000000000000e81cec061a8a4b5a--