MIME-Version: 1.0
References: <20230408191007.7lysd42euafwl74f@awork3.anarazel.de>
 <3611416.1680982220@sss.pgh.pa.us> <CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
 <4179373.1681145767@sss.pgh.pa.us>
In-Reply-To: <4179373.1681145767@sss.pgh.pa.us>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 10 Apr 2023 22:39:28 +0200
Message-ID: <CABUevEyHnPPZg15vQpnUJoidxy9riQVgvCpJL8Zw1fW6YPhWJw@mail.gmail.com>
Subject: Re: When to drop src/tools/msvc support
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, 
	pgsql-hackers@postgresql.org, Peter Geoghegan <pg@bowt.ie>, 
	Andrew Dunstan <andrew@dunslane.net>, "Jonathan S. Katz" <jkatz@postgresql.org>, 
	Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CABUevEyHnPPZg15vQpnUJoidxy9riQVgvCpJL8Zw1fW6YPhWJw%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 10, 2023 at 6:56=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Robert Haas <robertmhaas@gmail.com> writes:
> > However, if this is the direction we're going, we probably need to
> > give pgsql-packagers a heads up ASAP, because anybody who is still
> > relying on the MSVC system to build Windows binaries is presumably
> > going to need some time to adjust. If we rip out the build system
> > somebody is using a couple of weeks before beta, that might make it
> > difficult for that person to get the beta out promptly. And I think
> > there's probably more than just EDB who would be in that situation.
>
> Oh ... that's a good point.  Is there anyone besides EDB shipping
> MSVC-built executables?  Would it even be practical to switch to
> meson with a month-or-so notice?  Seems kind of tight, and it's
> not like the packagers volunteered to make this switch.
>
> Maybe we have to bite the bullet and keep MSVC for v16.
> If we drop it as soon as v17 opens, there's probably not that
> much incremental work involved compared to dropping for v16.

Not involved with any such build tasks anymore, but I think we can
definitely assume there are others than EDB who do that. It's also
used by people who build add-on modules to be loaded in the
EDB-installer-installed systems, I'm sure.

It seems a bit aggressive to those to drop the entire build system out
just before beta.

Thus, +1 on actually keeping it up and dropping it immediately as v17
opens, giving them a year of advantage. And probably updating the docs
(if anybody were to read them.. but at least then we tried) stating
that it's deprecated and will be removed in v17.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/