MIME-Version: 1.0
References: <cb103623-8ee6-4ba5-a2c9-f32e3a4933fa@dunslane.net>
 <ZmcKMF61K4Ck51dK@nathan> <CABUevExoQ26jo+aQ9QZq+UMA1aD6gfpm9xBnh_t5e0DhaCeRYA@mail.gmail.com>
 <ZmcVqPOGjoccIh-i@nathan>
In-Reply-To: <ZmcVqPOGjoccIh-i@nathan>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 10 Jun 2024 17:45:19 +0200
Message-ID: <CABUevEyMEaaY37_eMW76F97TX2voxdtPNkm3FGqN9c3ZHy3GMg@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000120632061a8b0ab9"
Archived-At: <https://www.postgresql.org/message-id/CABUevEyMEaaY37_eMW76F97TX2voxdtPNkm3FGqN9c3ZHy3GMg%40mail.gmail.com>
Precedence: bulk

--000000000000120632061a8b0ab9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 5:03=E2=80=AFPM Nathan Bossart <nathandbossart@gmai=
l.com>
wrote:

> On Mon, Jun 10, 2024 at 04:52:06PM +0200, Magnus Hagander wrote:
> > On Mon, Jun 10, 2024 at 4:14=E2=80=AFPM Nathan Bossart <nathandbossart@=
gmail.com
> >
> > wrote:
> >> I'm curious why we couldn't also support the "custom" format.
> >
> > Or maybe even a combo - a directory of custom format files? Plus that o=
ne
> > special file being globals? I'd say that's what most use cases I've see=
n
> > would prefer.
>
> Is there a particular advantage to that approach as opposed to just using
> "directory" mode for everything?  I know pg_upgrade uses "custom" mode fo=
r
> each of the databases, so a combo approach would be a closer match to the
> existing behavior, but that doesn't strike me as an especially strong
> reason to keep doing it that way.
>

A gazillion files to deal with? Much easier to work with individual custom
files if you're moving databases around and things like that.
Much easier to monitor eg sizes/dates if you're using it for backups.

It's not things that are make-it-or-break-it or anything, but there are
some smaller things that definitely can be useful.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000120632061a8b0ab9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jun 10, 2024 at 5:03=E2=80=AF=
PM Nathan Bossart &lt;<a href=3D"mailto:nathandbossart@gmail.com">nathandbo=
ssart@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">On Mon, Jun 10, 2024 at 04:52:06PM +0200, Magnus Hagander wr=
ote:<br>
&gt; On Mon, Jun 10, 2024 at 4:14=E2=80=AFPM Nathan Bossart &lt;<a href=3D"=
mailto:nathandbossart@gmail.com" target=3D"_blank">nathandbossart@gmail.com=
</a>&gt;<br>
&gt; wrote:<br>
&gt;&gt; I&#39;m curious why we couldn&#39;t also support the &quot;custom&=
quot; format.<br>
&gt; <br>
&gt; Or maybe even a combo - a directory of custom format files? Plus that =
one<br>
&gt; special file being globals? I&#39;d say that&#39;s what most use cases=
 I&#39;ve seen<br>
&gt; would prefer.<br>
<br>
Is there a particular advantage to that approach as opposed to just using<b=
r>
&quot;directory&quot; mode for everything?=C2=A0 I know pg_upgrade uses &qu=
ot;custom&quot; mode for<br>
each of the databases, so a combo approach would be a closer match to the<b=
r>
existing behavior, but that doesn&#39;t strike me as an especially strong<b=
r>
reason to keep doing it that way.<br></blockquote><div><br></div><div>A gaz=
illion files to deal with? Much easier to work with individual custom files=
 if you&#39;re moving databases around and things like that. Much=C2=A0easi=
er=C2=A0to monitor eg sizes/dates if you&#39;re using it for backups.</div>=
<div><br></div><div>It&#39;s not things that are make-it-or-break-it or any=
thing, but there are some smaller things that definitely can be useful.</di=
v><div>=C2=A0</div></div><span class=3D"gmail_signature_prefix">-- </span><=
br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0M=
agnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=3D"=
_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://www.=
redpill-linpro.com/" target=3D"_blank">https://www.redpill-linpro.com/</a><=
/div></div></div></div>

--000000000000120632061a8b0ab9--