MIME-Version: 1.0
References: <20230408191007.7lysd42euafwl74f@awork3.anarazel.de>
 <3611416.1680982220@sss.pgh.pa.us> <CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
 <4179373.1681145767@sss.pgh.pa.us> <CA+TgmoZwJ09Aw_igiLV7J-OPikii5PyW_iJyXCFtS1MdcY7hJQ@mail.gmail.com>
 <CA+OCxoxCZ2Q4vz0oznYqDgU4aZYv0GXO4TytkD070OjUp0OJeQ@mail.gmail.com> <20230410222738.57fdxwdrdhwatnr4@awork3.anarazel.de>
In-Reply-To: <20230410222738.57fdxwdrdhwatnr4@awork3.anarazel.de>
From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 11 Apr 2023 09:09:41 +0200
Message-ID: <CABUevEzX1xVDS=tV_MTNcPhJZXZSvXCZVBLp_gv=_kpPPhE-BQ@mail.gmail.com>
Subject: Re: When to drop src/tools/msvc support
To: Andres Freund <andres@anarazel.de>
Cc: Dave Page <dpage@pgadmin.org>, Robert Haas <robertmhaas@gmail.com>, 
	Alvaro Herrera <alvherre@alvh.no-ip.org>, Amit Kapila <amit.kapila16@gmail.com>, 
	Andrew Dunstan <andrew@dunslane.net>, "Jonathan S. Katz" <jkatz@postgresql.org>, Peter Geoghegan <pg@bowt.ie>, 
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CABUevEzX1xVDS%3DtV_MTNcPhJZXZSvXCZVBLp_gv%3D_kpPPhE-BQ%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 11, 2023 at 12:27=E2=80=AFAM Andres Freund <andres@anarazel.de>=
 wrote:
>
> Hi,
>
> On 2023-04-10 19:55:35 +0100, Dave Page wrote:
> > Projects other than the EDB installers use the MSVC build system - e.g.
> > pgAdmin uses it=E2=80=99s own builds of libpq and other tools (psql, pg=
_dump etc)
> > that are pretty heavily baked into a fully automated build system (even=
 the
> > build servers and all their requirements are baked into Ansible).
> >
> > Changing that lot would be non-trivial, though certainly possible, and =
I
> > suspect we=E2=80=99re not the only ones doing that sort of thing.
>
> Do you have a link to the code for that, if it's open? Just to get an
> impression for how hard it'd be to switch over?


The pgadmin docs/readme refers to
https://github.com/pgadmin-org/pgadmin4/tree/master/pkg/win32

It clearly doesn't have the full automation stuff, but appears to have
the parts about building the postgres dependency.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/