MIME-Version: 1.0
References: <96ff23a5d858ff72ca8e823a014d16fe@oss.nttdata.com>
 <20241009120314.118a641fa25148c3d564a6ae@sraoss.co.jp> <CAKFQuwbnNfH0RYcDnwYkhbXi_VK+yKHaMGvRP9J1vFrLHnze0w@mail.gmail.com>
 <2351827.1728447022@sss.pgh.pa.us> <CAKFQuwZ8H9erEpDXO=ucgSLbMJfutZf+d=WQXWoJiB2ziD_Xpg@mail.gmail.com>
 <20241009151508.eb37141e5ad29d0ca1e44eb9@sraoss.co.jp> <18f52adc395bece3c9d4373890560bbd@oss.nttdata.com>
In-Reply-To: <18f52adc395bece3c9d4373890560bbd@oss.nttdata.com>
From: Robert Treat <rob@xzilla.net>
Date: Fri, 17 Jan 2025 10:45:46 -0500
Message-ID: <CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT+eLrSfWE2z7Ra3CQtdXA@mail.gmail.com>
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>, "David G. Johnston" <david.g.johnston@gmail.com>, 
	Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000a4d94e062be8ce8e"
Archived-At: <https://www.postgresql.org/message-id/CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT%2BeLrSfWE2z7Ra3CQtdXA%40mail.gmail.com>
Precedence: bulk

--000000000000a4d94e062be8ce8e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 10, 2024 at 1:56=E2=80=AFAM Shinya Kato
<Shinya11.Kato@oss.nttdata.com> wrote:
> Thank you all for the comments!
<snip>
> While adding to the documentation is sufficient if users use it
> correctly, users often behave unexpectedly. My intention was to
> implement it in a way that works without issues even if misused.
> However, since the prevailing opinion seems to favor simply updating the
> documentation, I will proceed with that approach.
>
> A new patch is attached.
> I am not a native English, so corrections to the texts are welcome.
>

This looks pretty good to me. I think there are a couple of minor
grammar changes that could be made, and I think the pg_dumpall section
could use a couple tweaks, specifically 1) not all incantations of
pg_dumpall emit psql meta commands (-g comes to mind quickly) and ISTR
some non-psql clients honor psql meta commands, so I would lessen the
language around incompatibility, and 2) I think adding an explicit -f
for the database name in the pg_dumpall is clearer, and mirrors the
pg_dump example.

suggested diffs attached, let me know if you would like a consolidated patc=
h


Robert Treat
https://xzilla.net

--000000000000a4d94e062be8ce8e
Content-Type: application/octet-stream; name="xzilla-pg_dump-no-psqlrc.diff"
Content-Disposition: attachment; filename="xzilla-pg_dump-no-psqlrc.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_m60xkove0>
X-Attachment-Id: f_m60xkove0

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9iYWNrdXAuc2dtbCBiL2RvYy9zcmMvc2dtbC9iYWNr
dXAuc2dtbAppbmRleCAyMWFkMzRmNGUwLi4xNWM4Y2RiOGFhIDEwMDY0NAotLS0gYS9kb2Mvc3Jj
L3NnbWwvYmFja3VwLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2JhY2t1cC5zZ21sCkBAIC0xMDYs
NyArMTA2LDcgQEAgcGdfZHVtcCA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+ZGJuYW1l
PC9yZXBsYWNlYWJsZT4gJmd0OyA8cmVwbGFjZWFibGUgY2wKIAogICAgPHBhcmE+CiAgICAgVGV4
dCBmaWxlcyBjcmVhdGVkIGJ5IDxhcHBsaWNhdGlvbj5wZ19kdW1wPC9hcHBsaWNhdGlvbj4gYXJl
IGludGVuZGVkIHRvCi0gICAgYmUgcmVhZCBpbiBieSB0aGUgPGFwcGxpY2F0aW9uPnBzcWw8L2Fw
cGxpY2F0aW9uPiBwcm9ncmFtIHdpdGggaXRzIGRlZmF1bHQKKyAgICBiZSByZWFkIGluIGJ5IHRo
ZSA8YXBwbGljYXRpb24+cHNxbDwvYXBwbGljYXRpb24+IHByb2dyYW0gdXNpbmcgaXRzIGRlZmF1
bHQKICAgICBzZXR0aW5ncy4gVGhlIGdlbmVyYWwgY29tbWFuZCBmb3JtIHRvIHJlc3RvcmUgYSBk
dW1wIGlzCiA8c3lub3BzaXM+CiBwc3FsIC0tbm8tcHNxbHJjIDxyZXBsYWNlYWJsZSBjbGFzcz0i
cGFyYW1ldGVyIj5kYm5hbWU8L3JlcGxhY2VhYmxlPiAmbHQ7IDxyZXBsYWNlYWJsZSBjbGFzcz0i
cGFyYW1ldGVyIj5kdW1wZmlsZTwvcmVwbGFjZWFibGU+CmRpZmYgLS1naXQgYS9kb2Mvc3JjL3Nn
bWwvcmVmL3BnX2R1bXBhbGwuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfZHVtcGFsbC5zZ21s
CmluZGV4IDkyMDgzODdlYzEuLjYzNmMyN2ZlMTcgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9y
ZWYvcGdfZHVtcGFsbC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfZHVtcGFsbC5zZ21s
CkBAIC04MjMsOCArODIzLDggQEAgZXhjbHVkZSBkYXRhYmFzZSA8cmVwbGFjZWFibGUgY2xhc3M9
InBhcmFtZXRlciI+UEFUVEVSTjwvcmVwbGFjZWFibGU+CiAgICB3aGVuIHJlc3RvcmluZyBhIGRh
dGFiYXNlIGZyb20gYSA8YXBwbGljYXRpb24+cGdfZHVtcGFsbDwvYXBwbGljYXRpb24+IHNjcmlw
dAogICAgdG8gZW5zdXJlIGEgY2xlYW4gcmVzdG9yZSBwcm9jZXNzIGFuZCBwcmV2ZW50IHBvdGVu
dGlhbCBjb25mbGljdHMgd2l0aAogICAgZXhpc3RpbmcgPGFwcGxpY2F0aW9uPnBzcWw8L2FwcGxp
Y2F0aW9uPiBjb25maWd1cmF0aW9ucy4gQWRkaXRpb25hbGx5LAotICAgYmVjYXVzZSB0aGUgc2Ny
aXB0IGluY2x1ZGVzIDxhcHBsaWNhdGlvbj5wc3FsPC9hcHBsaWNhdGlvbj4gbWV0YS1jb21tYW5k
cywKLSAgIGl0IGlzIGluY29tcGF0aWJsZSB3aXRoIGNsaWVudHMgb3RoZXIgdGhhbiA8YXBwbGlj
YXRpb24+cHNxbDwvYXBwbGljYXRpb24+LgorICAgYmVjYXVzZSB0aGUgc2NyaXB0IGNhbiBpbmNs
dWRlIDxhcHBsaWNhdGlvbj5wc3FsPC9hcHBsaWNhdGlvbj4gbWV0YS1jb21tYW5kcywKKyAgIGl0
IG1heSBiZSBpbmNvbXBhdGlibGUgd2l0aCBjbGllbnRzIG90aGVyIHRoYW4gPGFwcGxpY2F0aW9u
PnBzcWw8L2FwcGxpY2F0aW9uPi4KICAgPC9wYXJhPgogIDwvcmVmc2VjdDE+CiAKQEAgLTg0Miw5
ICs4NDIsOSBAQCBleGNsdWRlIGRhdGFiYXNlIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVy
Ij5QQVRURVJOPC9yZXBsYWNlYWJsZT4KICAgPHBhcmE+CiAgICBUbyByZXN0b3JlIGRhdGFiYXNl
KHMpIGZyb20gdGhpcyBmaWxlLCB5b3UgY2FuIHVzZToKIDxzY3JlZW4+Ci08cHJvbXB0PiQ8L3By
b21wdD4gPHVzZXJpbnB1dD5wc3FsIC0tbm8tcHNxbHJjIC1mIGRiLm91dCBwb3N0Z3JlczwvdXNl
cmlucHV0PgorPHByb21wdD4kPC9wcm9tcHQ+IDx1c2VyaW5wdXQ+cHNxbCAtLW5vLXBzcWxyYyAt
ZiBkYi5vdXQgLWQgcG9zdGdyZXM8L3VzZXJpbnB1dD4KIDwvc2NyZWVuPgotICAgSXQgaXMgbm90
IGltcG9ydGFudCB0byB3aGljaCBkYXRhYmFzZSB5b3UgY29ubmVjdCBoZXJlIHNpbmNlIHRoZQor
ICAgSXQgaXMgbm90IGltcG9ydGFudCB3aGljaCBkYXRhYmFzZSB5b3UgY29ubmVjdCB0byBoZXJl
IHNpbmNlIHRoZQogICAgc2NyaXB0IGZpbGUgY3JlYXRlZCBieSA8YXBwbGljYXRpb24+cGdfZHVt
cGFsbDwvYXBwbGljYXRpb24+IHdpbGwKICAgIGNvbnRhaW4gdGhlIGFwcHJvcHJpYXRlIGNvbW1h
bmRzIHRvIGNyZWF0ZSBhbmQgY29ubmVjdCB0byB0aGUgc2F2ZWQKICAgIGRhdGFiYXNlcy4gIEFu
IGV4Y2VwdGlvbiBpcyB0aGF0IGlmIHlvdSBzcGVjaWZpZWQgPG9wdGlvbj4tLWNsZWFuPC9vcHRp
b24+LAo=
--000000000000a4d94e062be8ce8e--