MIME-Version: 1.0
References: 
 <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
 <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com>
 <CAHut+PsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg@mail.gmail.com>
 <0B7E46E8-EA1B-48AA-A1A5-BC39B5073D40@gmail.com>
 <CAHut+PuxV8wAULnNv+i1_YKyvDrD7jvWne48Yf82e3hRR=+qQw@mail.gmail.com>
In-Reply-To: 
 <CAHut+PuxV8wAULnNv+i1_YKyvDrD7jvWne48Yf82e3hRR=+qQw@mail.gmail.com>
From: Robert Treat <rob@xzilla.net>
Date: Fri, 10 Apr 2026 09:10:18 -0400
Message-ID: 
 <CABV9wwPNeMM9wrtYtwmG_F6y=-f8hcnPbeVMmgXE4DEaZkFQew@mail.gmail.com>
Subject: Re: Add missing period to HINT messages
To: Peter Smith <smithpb2250@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABV9wwPNeMM9wrtYtwmG_F6y%3D-f8hcnPbeVMmgXE4DEaZkFQew%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 9, 2026 at 9:05=E2=80=AFPM Peter Smith <smithpb2250@gmail.com> =
wrote:
> On Thu, Apr 9, 2026 at 1:34=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> w=
rote:
> >
> ...
> >
> > I am not sure if your scope includes contrib/, if yes, I am sure you wi=
ll find some occurrences there.
> >
>
> Updated one more message found in contrib.
>
> PSA v2.
>

+1 to the general idea here, although at the risk of looking at
patches before the morning coffee has settled in, ISTM you might have
missed some entries? And/or this patch isn't against HEAD?  For
example, you seem to be catching the line here
https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f1137fa3df=
09aac79f/src/test/regress/expected/partition_split.out#L60,
but not the one on line 52, maybe because it looks like a comment (but
istm we should clean these all up. no?)

Also FWIW, it might seem a little weird not to clean up the grammar
issues too, but I think this is the right move, to update these
changes cleanly/separately and do those changes as a separate patch, I
can imagine that some of those will require more futzing, for example

> "To split DEFAULT partition one of the new partition must be DEFAULT."
> missing word? -- "To split the DEFAULT partition"
> should be plural? -- "one of the new partitions"
>

I guess there is a balance wrt terseness, and maybe needs a comma:

"To split DEFAULT partition, one new partition must be DEFAULT."
"To split the DEFAULT partition, one of the new partitions must be DEFAULT.=
"
 "To split a DEFAULT partition, one of the new partitions must be
created as DEFAULT."


Robert Treat
https://xzilla.net